Page MenuHomePhabricator
Differential D93492

[mlir] Add canonicalization from `tensor_cast` to `dim` op.
ClosedPublic
Actions

Authored by mravishankar on Dec 17 2020, 2:34 PM.

Details

Reviewers
rriddle
silvas
nicolasvasilache
Commits
rGde031216bf17: [mlir] Add canonicalization from `tensor_cast` to `dim` op.
Summary

Fold a tensor_cast -> dim to take the dim of the original tensor.

Diff Detail

Event Timeline

mravishankar created this revision.Dec 17 2020, 2:34 PM
Herald added subscribers: teijeong, rdzhabarov, tatianashp and 14 others. · View Herald TranscriptDec 17 2020, 2:34 PM
mravishankar requested review of this revision.Dec 17 2020, 2:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2020, 2:34 PM
Herald added subscribers: limo1996, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
rriddle added a comment.Dec 17 2020, 2:35 PM

nit: Can you remove Linalg from the tags?

mravishankar added reviewers: rriddle, silvas.Dec 17 2020, 2:40 PM
nicolasvasilache accepted this revision.Dec 17 2020, 2:40 PM
This revision is now accepted and ready to land.Dec 17 2020, 2:40 PM
mravishankar added a comment.Dec 17 2020, 2:40 PM
In D93492#2461577, @rriddle wrote:

nit: Can you remove Linalg from the tags?

I dont see where the tag is.

rriddle added a comment.Dec 17 2020, 2:40 PM
In D93492#2461595, @mravishankar wrote:
In D93492#2461577, @rriddle wrote:

nit: Can you remove Linalg from the tags?

I dont see where the tag is.

You have [mlir][Linalg] in the title of the commit.

Harbormaster completed remote builds in B82868: Diff 312619.Dec 17 2020, 2:41 PM
silvas accepted this revision.Dec 17 2020, 2:41 PM
mravishankar retitled this revision from [mlir][Linalg] Add canonicalization from `tensor_cast` to `dim` op. to [mlir] Add canonicalization from `tensor_cast` to `dim` op..Dec 17 2020, 2:43 PM
In D93492#2461598, @rriddle wrote:
In D93492#2461595, @mravishankar wrote:
In D93492#2461577, @rriddle wrote:

nit: Can you remove Linalg from the tags?

I dont see where the tag is.

You have [mlir][Linalg] in the title of the commit.

:D Done.

This revision was landed with ongoing or failed builds.Dec 17 2020, 2:49 PM
Closed by commit rGde031216bf17: [mlir] Add canonicalization from `tensor_cast` to `dim` op. (authored by mravishankar). · Explain Why
This revision was automatically updated to reflect the committed changes.
mravishankar added a commit: rGde031216bf17: [mlir] Add canonicalization from `tensor_cast` to `dim` op..

Revision Contents
Changeset List

PathSize
mlir/
lib/
Dialect/
StandardOps/
IR/
20 lines
test/
Dialect/
Standard/
16 lines

Diff 312622

View Options

mlir/lib/Dialect/StandardOps/IR/Ops.cpp

Loading...
View Options

mlir/test/Dialect/Standard/canonicalize.mlir

Loading...