This is an archive of the discontinued LLVM Phabricator instance.

[builtins] Use %% as the separator for aarch64-*-darwin and ; for powerpc{32,64}
ClosedPublic

Authored by MaskRay on Dec 16 2020, 12:03 AM.

Details

Summary

; is the default comment marker, which is also used by powerpc*-*-elf target triples.
@ is the comment marker of powerpc*-*-darwin but the Darwin support has been deleted for PowerPC (D72063).
%% is the statement separator used by aarch64-*-darwin (see AArch64MCAsmInfoDarwin, it uses ; as the comment marker, which is different from most other targets)

Diff Detail

Event Timeline

MaskRay created this revision.Dec 16 2020, 12:03 AM
MaskRay requested review of this revision.Dec 16 2020, 12:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 16 2020, 12:03 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
MaskRay retitled this revision from [builtins] Use %% as a separator for aarch64-*-darwin and ; for powerpc See AArch64MCAsmInfoDarwin, aarch64-*-darwin uses `%%` as a statement separator and `;` as a comment marker, which is different from other targets. to [builtins] Use %% as a separator for aarch64-*-darwin and ; for powerpc.Dec 16 2020, 12:03 AM
MaskRay edited the summary of this revision. (Show Details)
tambre accepted this revision.Dec 16 2020, 12:11 AM

Fixes the issue, thanks! I'll revert the workaround once this lands.

This revision is now accepted and ready to land.Dec 16 2020, 12:11 AM
MaskRay edited the summary of this revision. (Show Details)Dec 16 2020, 12:11 AM
MaskRay retitled this revision from [builtins] Use %% as a separator for aarch64-*-darwin and ; for powerpc to [builtins] Use %% as the separator for aarch64-*-darwin and ; for powerpc{32,64}.Dec 16 2020, 12:13 AM
This revision was landed with ongoing or failed builds.Dec 16 2020, 12:13 AM
This revision was automatically updated to reflect the committed changes.