This is an archive of the discontinued LLVM Phabricator instance.

GlobalISel: remove assert that memcpy Src and Dst addrspace must be identical
ClosedPublic

Authored by vtjnash on Dec 11 2020, 10:03 PM.

Details

Summary

The LangRef does not require these arguments to have the same type.

Diff Detail

Event Timeline

vtjnash created this revision.Dec 11 2020, 10:03 PM
vtjnash requested review of this revision.Dec 11 2020, 10:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 11 2020, 10:03 PM
vtjnash added a subscriber: Restricted Project.Dec 11 2020, 10:04 PM
vtjnash updated this revision to Diff 311365.Dec 11 2020, 10:11 PM

needed for memmove too

loladiro added a subscriber: loladiro.

LGTM, from an IR legality perspective, but somebody familiar with GlobalISel should take a look from that perspective - adding authors/reviewers of https://reviews.llvm.org/D65167, which added this code. Also, we should have a test.

Harbormaster completed remote builds in B82135: Diff 311365.

Yes, a test would be good.

vtjnash updated this revision to Diff 381349.Oct 21 2021, 11:53 AM

adding test

@aemerson are you happy with this test for approval and merge now?

aemerson accepted this revision.Nov 3 2021, 3:15 PM

LGTM.

This revision is now accepted and ready to land.Nov 3 2021, 3:15 PM
arsenm added a subscriber: arsenm.Nov 3 2021, 3:36 PM
arsenm added inline comments.
llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
7802 ↗(On Diff #381349)

I think the variable names are now more confusing, this is still a PtrTy. SrcPtrTy?

7813 ↗(On Diff #381349)

DstPtrTy?

vtjnash updated this revision to Diff 389623.Nov 24 2021, 2:43 PM

Rename LoadTy to SrcTy and StoreTy to DstTy

This revision was landed with ongoing or failed builds.Nov 24 2021, 5:24 PM
This revision was automatically updated to reflect the committed changes.