Differential D93037

[YAML] Use correct source location for unknown key errors.
ClosedPublic
Actions

Authored by njames93 on Dec 10 2020, 8:21 AM.

Details

Reviewers

silvas

Commits

rGd380c38e3470: [YAML] Use correct source location for unknown key errors.

Summary

Currently unknown keys when inputting mapping traits have the location set to the Value.
Example:

YAML:1:14: error: unknown key 'UnknownKey'
{UnknownKey: SomeValue}
             ^~~~~~~~~

This is unhelpful for a user as it draws them to fix the wrong item.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

njames93 created this revision.Dec 10 2020, 8:21 AM

Herald added subscribers: dexonsmith, hiraditya. · View Herald TranscriptDec 10 2020, 8:21 AM

njames93 requested review of this revision.Dec 10 2020, 8:21 AM

Herald added a project: Restricted Project. · View Herald TranscriptDec 10 2020, 8:21 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster completed remote builds in B81847: Diff 310901.Dec 10 2020, 9:18 AM

Would be nice to find a way to test this (Maybe a FileCheck test? not sure how to set that up though; don't worry if it is too much work.)

This revision is now accepted and ready to land.Dec 10 2020, 9:34 AM

In D93037#2446301, @silvas wrote:

Would be nice to find a way to test this (Maybe a FileCheck test? not sure how to set that up though; don't worry if it is too much work.)

Bit of a pain to set that up explicitly. Thankfully, there are 8 test failures(per platform) introduced by this patch that demonstrate the old unexpected behaviour.
Fixing those should be semi-decent basic coverage.

Fix failing tests introduced with this patch.

Herald added subscribers: cishida, qcolombet. · View Herald TranscriptDec 10 2020, 4:12 PM

Harbormaster completed remote builds in B81929: Diff 311054.Dec 10 2020, 5:43 PM

This revision was landed with ongoing or failed builds.Dec 11 2020, 8:34 AM

Closed by commit rGd380c38e3470: [YAML] Use correct source location for unknown key errors. (authored by njames93). · Explain Why

This revision was automatically updated to reflect the committed changes.

njames93 added a commit: rGd380c38e3470: [YAML] Use correct source location for unknown key errors..