This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] don't build out of line atomics on Darwin or Windows
AbandonedPublic

Authored by t.p.northover on Dec 8 2020, 4:37 AM.

Details

Reviewers
ilinpv
tambre
Summary

The lse.S file uses syntax that only works on ELF targets (e.g. :lo12), so it prevents building compiler-rt for iOS and ARM-based macOS.

Diff Detail

Event Timeline

t.p.northover created this revision.Dec 8 2020, 4:37 AM
t.p.northover requested review of this revision.Dec 8 2020, 4:37 AM

The lse.S file uses syntax that only works on ELF targets (e.g. :lo12:)

That syntax actually is supported by the llvm assembler for windows targets, and these out of line functions at least build successfully for that target (haven't tested actually running them though), so I think only darwin targets are the one that need to be excluded here right now.

ilinpv added a comment.EditedDec 8 2020, 9:16 AM

lse.S syntax could be fixed: https://reviews.llvm.org/D92530
The question is, should outline atomics be in compiler-rt for iOS and ARM-based macOS?

dmajor added a subscriber: dmajor.Dec 10 2020, 10:42 AM
ilinpv requested changes to this revision.Dec 15 2020, 5:07 AM

lse.S syntax fixed, compiler-rt with outline atomics should be built fine. If there are no any other issues can we abandon this patch?

This revision now requires changes to proceed.Dec 15 2020, 5:07 AM
t.p.northover abandoned this revision.Feb 8 2021, 6:45 AM