Page MenuHomePhabricator

Revert "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately"
ClosedPublic

Authored by tambre on Dec 14 2020, 1:42 AM.

Diff Detail

Event Timeline

tambre created this revision.Dec 14 2020, 1:42 AM
tambre requested review of this revision.Dec 14 2020, 1:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 14 2020, 1:42 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Dec 14 2020, 1:42 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.

@ilinpv Any ideas why the Apple buildbots might be failing (example)? The errrors seem to be about explicit relocation types missing, but I can't see anything in my changes that could've caused those.

@ilinpv Any ideas why the Apple buildbots might be failing (example)? The errrors seem to be about explicit relocation types missing, but I can't see anything in my changes that could've caused those.

Fix for lse.S is not landed yet: https://reviews.llvm.org/D92530

@ilinpv Any ideas why the Apple buildbots might be failing (example)? The errrors seem to be about explicit relocation types missing, but I can't see anything in my changes that could've caused those.

Fix for lse.S is not landed yet: https://reviews.llvm.org/D92530

Any reason for that to not have landed yet? If not, I could probably land that prior to recommiting mine.

@ilinpv Any ideas why the Apple buildbots might be failing (example)? The errrors seem to be about explicit relocation types missing, but I can't see anything in my changes that could've caused those.

Fix for lse.S is not landed yet: https://reviews.llvm.org/D92530

Any reason for that to not have landed yet? If not, I could probably land that prior to recommiting mine.

I guess because of patch https://reviews.llvm.org/D92836 removing outline atomics for Apple.
Anyway it would be great to have Apple syntax fix landed, thank you for help.