This is an archive of the discontinued LLVM Phabricator instance.

Differential D92724

[compiler-rt][AArch64] Put outline atomic helpers into dedicated dir.
ClosedPublic

Authored by ilinpv on Dec 5 2020, 1:11 PM.

Details

Reviewers
mstorsjo
kubamracek
Commits
rG377ba7be933f: [compiler-rt][AArch64] Put outline atomic helpers into dedicated dir.

Diff Detail

Unit TestsFailed

TimeTest
280 msx64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases::alloca_constant_size.cpp
270 msx64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases::alloca_loop_unpoisoning.cpp
730 msx64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases::asan_update_allocation.cpp
270 msx64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases::debug_locate.cpp
280 msx64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases::debug_stacks.cpp
View Full Test Results (345 Failed)

Event Timeline

ilinpv created this revision.Dec 5 2020, 1:11 PM
Herald added subscribers: danielkiss, jfb, kristof.beyls and 2 others. · View Herald TranscriptDec 5 2020, 1:11 PM
ilinpv requested review of this revision.Dec 5 2020, 1:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 5 2020, 1:12 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
ilinpv mentioned this in D91156: [AArch64] Compiler-rt interface for out-of-line atomics..Dec 5 2020, 1:35 PM
Harbormaster completed remote builds in B81214: Diff 309746.Dec 5 2020, 1:43 PM
mstorsjo accepted this revision.Dec 6 2020, 1:42 PM

Looks sensible to me, thanks! (Didn't test it myself though.)

This revision is now accepted and ready to land.Dec 6 2020, 1:42 PM
mstorsjo added a subscriber: llvm-commits.Dec 6 2020, 1:43 PM

Adding llvm-commits as subscriber to this one, as I guess it hasn't been visible on any mailing list yet.

This revision was landed with ongoing or failed builds.Dec 6 2020, 4:29 PM
Closed by commit rG377ba7be933f: [compiler-rt][AArch64] Put outline atomic helpers into dedicated dir. (authored by ilinpv). · Explain Why
This revision was automatically updated to reflect the committed changes.
ilinpv added a commit: rG377ba7be933f: [compiler-rt][AArch64] Put outline atomic helpers into dedicated dir..

Revision Contents

PathSize
compiler-rt/
lib/
builtins/
4 lines

Diff 309746

compiler-rt/lib/builtins/CMakeLists.txt

Show First 20 Lines • Show All 507 Lines • ▼ Show 20 Lines
# Generate outline atomics helpers from lse.S base # Generate outline atomics helpers from lse.S base
set(CUSTOM_FLAGS ${CMAKE_C_FLAGS}) set(CUSTOM_FLAGS ${CMAKE_C_FLAGS})
if(NOT ANDROID) if(NOT ANDROID)
append_list_if(COMPILER_RT_HAS_VISIBILITY_HIDDEN_FLAG -DVISIBILITY_HIDDEN CUSTOM_FLAGS) append_list_if(COMPILER_RT_HAS_VISIBILITY_HIDDEN_FLAG -DVISIBILITY_HIDDEN CUSTOM_FLAGS)
endif() endif()
append_list_if(COMPILER_RT_HAS_ASM_LSE -DHAS_ASM_LSE CUSTOM_FLAGS) append_list_if(COMPILER_RT_HAS_ASM_LSE -DHAS_ASM_LSE CUSTOM_FLAGS)
string(REPLACE " " "\t" CUSTOM_FLAGS "${CUSTOM_FLAGS}") string(REPLACE " " "\t" CUSTOM_FLAGS "${CUSTOM_FLAGS}")
set(OA_HELPERS_DIR "${CMAKE_CURRENT_BINARY_DIR}/outline_atomic_helpers.dir")
file(MAKE_DIRECTORY ${OA_HELPERS_DIR})
foreach(pat cas swp ldadd ldclr ldeor ldset) foreach(pat cas swp ldadd ldclr ldeor ldset)
foreach(size 1 2 4 8 16) foreach(size 1 2 4 8 16)
foreach(model 1 2 3 4) foreach(model 1 2 3 4)
if(pat STREQUAL "cas" OR NOT size STREQUAL "16") if(pat STREQUAL "cas" OR NOT size STREQUAL "16")
set(helper_asm outline_atomic_${pat}${size}_${model}.S) set(helper_asm ${OA_HELPERS_DIR}/outline_atomic_${pat}${size}_${model}.S)
add_custom_command( add_custom_command(
OUTPUT ${helper_asm} OUTPUT ${helper_asm}
COMMAND ${CMAKE_C_COMPILER} -E ${CUSTOM_FLAGS} -DL_${pat} -DSIZE=${size} -DMODEL=${model} COMMAND ${CMAKE_C_COMPILER} -E ${CUSTOM_FLAGS} -DL_${pat} -DSIZE=${size} -DMODEL=${model}
${CMAKE_CURRENT_SOURCE_DIR}/aarch64/lse.S -o ${helper_asm} ${CMAKE_CURRENT_SOURCE_DIR}/aarch64/lse.S -o ${helper_asm}
DEPENDS aarch64/lse.S assembly.h DEPENDS aarch64/lse.S assembly.h
) )
set_source_files_properties(${helper_asm} PROPERTIES GENERATED TRUE) set_source_files_properties(${helper_asm} PROPERTIES GENERATED TRUE)
set(aarch64_SOURCES set(aarch64_SOURCES
▲ Show 20 Lines • Show All 203 Lines • Show Last 20 Lines