Page MenuHomePhabricator

Fix for Bug 48055.
ClosedPublic

Authored by yamauchi on Dec 3 2020, 12:22 PM.

Diff Detail

Event Timeline

yamauchi created this revision.Dec 3 2020, 12:22 PM
yamauchi requested review of this revision.Dec 3 2020, 12:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2020, 12:22 PM
yamauchi edited the summary of this revision. (Show Details)Dec 4 2020, 9:31 AM
This revision is now accepted and ready to land.Dec 4 2020, 9:48 AM
davidxl accepted this revision.Dec 4 2020, 9:48 AM

lgtm

echristo added inline comments.Dec 4 2020, 10:16 AM
llvm/lib/Transforms/Utils/Evaluator.cpp
190

You have a dyn_cast here that is immediately dereferenced rather than checked. Might be better to just cast (since we know it's a StructType) or dyn_cast outside of the if?

yamauchi updated this revision to Diff 309576.Dec 4 2020, 10:29 AM
yamauchi marked an inline comment as done.

Address comment.

echristo accepted this revision.Dec 4 2020, 10:34 AM
This revision was landed with ongoing or failed builds.Dec 4 2020, 11:06 AM
Closed by commit rGf9c3954a6ec5: Fix for Bug 48055. (authored by yamauchi). · Explain Why
This revision was automatically updated to reflect the committed changes.