When the operations in the source region are inlined, a list of
attributes can be added to these operations.
Details
Details
- Reviewers
mehdi_amini rriddle
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I'm not really understanding the motivation here. What is the intended use case for this? And why couldn't this be done by the caller instead?
Comment Actions
This is to propagate the attributes, such as "device" and "_tpu_replicate", to the inlined operations. These attributes might be different at different call sites, so we couldn't set them in the src.
An alternative implementation is the inlineCall method returns all the new inlined operations, so the caller can set them.
Comment Actions
I think providing more control to the caller would enable finer-grain decision, I'm more in favor of going this route.
clang-format suggested style edits found: