This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] change shm name to include UID, call unregister_lib on SIGTERM
ClosedPublic

Authored by terdner on Nov 20 2020, 7:05 AM.

Details

Summary

With the change to using shared memory, there were a few problems that need to be fixed.

  1. The previous filename that was used for SHM only used process id. Given that process is

usually based on 16bit number, this was causing some conflicts on machines. Thus we add
UID to the name to prevent this.

  1. It appears under some conditions (SIGTERM, etc) the shared memory files were not getting

cleaned up. Added a call to clean up the shm files under those conditions.

Diff Detail

Event Timeline

terdner created this revision.Nov 20 2020, 7:05 AM
terdner requested review of this revision.Nov 20 2020, 7:05 AM
terdner updated this revision to Diff 306694.Nov 20 2020, 7:49 AM

windows doesn't have gituid call so leave windows env variable alone.

This revision is now accepted and ready to land.Nov 30 2020, 1:25 PM
This revision was landed with ongoing or failed builds.Nov 30 2020, 1:41 PM
This revision was automatically updated to reflect the committed changes.