[libc++] Remove several bots that now exist in Buildkite

[ldionne]

Summary

Our Buildkite pipeline has these bots (and more), and it is executed
both on Phabricator reviews and regularly against the master branch.

[ldionne]

Ping @EricWF

[gkistanova]

Does any worker go away too?

[EricWF]

LGTM.

I don't see a reason to keep the builders.

[ldionne]

Committed as 162771fdf6cadfe94b7205dd079302ff22720e45.

[ldionne]

Accepting to try and close the rev -- it looks like llvm-zorg doesn't have the same automation as other repos.

[gkistanova]

Sorry if I wasn't clear enough with my request.

Please also remove all your abandoned workers from buildbot/osuosl/master/config/workers.py, as well as the docker_workers variable which is not used any more.

[ldionne]

In D91809#2426535, @gkistanova wrote:

Sorry if I wasn't clear enough with my request.

Please also remove all your abandoned workers from buildbot/osuosl/master/config/workers.py, as well as the docker_workers variable which is not used any more.

Oh, I apologize, I thought we were speaking of the actual worker machines in GCE, which I assumed Eric would get rid of. Now it makes more sense -- I didn't understand why you cared about those workers :-).

[ldionne]

See D91809 for the follow up.

[gkistanova]

I guess that's D92426.

[curdeius]

Sorry for late comments. Just stumbled upon this patch.

buildbot/osuosl/master/config/builders.py

1331–1340

Is there really an equivalent in Buildkite? I could not find one.

1398–1407

Same for this one.

[ldionne]

buildbot/osuosl/master/config/builders.py

1331–1340

You're right, this one was dropped. See D92508.

1398–1407

So, about this one. We don't actually want to support all the way back to GCC 5, so that's why I didn't add it on Buildkite. It's actually impossible to build a proper libc++ with such old compilers (for example that compiler doesn't know about char8_t, so it can't generate the RTTI for that fundamental type). As I've said in several places before, we need to straighten our actual compiler support matrix to something that makes sense, and I'm waiting for the runtimes build to become the default way to build libc++ in order to make that change officially.

We're working on that with @phosek.

[curdeius]

OK, that's clear now. Thank you for the answer, Louis.

[ldionne]

Closing since we made the follow-up changes in D92426.

buildbot/osuosl/master/config/builders.py

# Libc++ builders.
     {'name' : 'libcxx-libcxxabi-singlethreaded-x86_64-linux-debian',
     'tags'  : ["libcxx"],
     'workernames' : ['gribozavr4'],
     'builddir': 'libcxx-libcxxabi-singlethreaded-x86_64-linux-debian',
     'factory' : LibcxxAndAbiBuilder.getLibcxxAndAbiBuilder(
                     env={'CC': 'clang', 'CXX': 'clang++'},
                     use_cache='Generic-singlethreaded.cmake')},
 
-    # EricWF's builders
-    {'name' : 'libcxx-libcxxabi-x86_64-linux-ubuntu-cxx03',
-    'tags'  : ["libcxx"],
-    'workernames' : docker_workers,
-    'builddir': 'libcxx-libcxxabi-x86_64-linux-ubuntu-cxx03',
-    'factory' : LibcxxAndAbiBuilder.getLibcxxAndAbiBuilder(
-                    env={
-                        'PATH': '/usr/local/bin:/usr/bin:/bin',
-                        'CC': 'clang', 'CXX': 'clang++'},
-                    use_cache='Generic-cxx03.cmake',
-                    check_libcxx_abilist=True)},
-
-    {'name' : 'libcxx-libcxxabi-x86_64-linux-ubuntu-cxx11',
-    'tags'  : ["libcxx"],
-    'workernames' : docker_workers,
-    'builddir': 'libcxx-libcxxabi-x86_64-linux-ubuntu-cxx11',
-    'factory' : LibcxxAndAbiBuilder.getLibcxxAndAbiBuilder(
-                    env={
-                        'PATH': '/usr/local/bin:/usr/bin:/bin',
-                        'CC': 'clang', 'CXX': 'clang++'},
-                    use_cache='Generic-cxx11.cmake',
-                    check_libcxx_abilist=True)},
-
-    {'name' : 'libcxx-libcxxabi-x86_64-linux-ubuntu-cxx14',
-    'tags'  : ["libcxx"],
-    'workernames' : docker_workers,
-    'builddir': 'libcxx-libcxxabi-x86_64-linux-ubuntu-cxx14',
-    'factory' : LibcxxAndAbiBuilder.getLibcxxAndAbiBuilder(
-                    env={
-                        'PATH': '/usr/local/bin:/usr/bin:/bin',
-                        'CC': 'clang', 'CXX': 'clang++'},
-                    use_cache='Generic-cxx14.cmake',
-                    check_libcxx_abilist=True)},
-
-    {'name' : 'libcxx-libcxxabi-x86_64-linux-ubuntu-cxx17',
-    'tags'  : ["libcxx"],
-    'workernames' : docker_workers,
-    'builddir': 'libcxx-libcxxabi-x86_64-linux-ubuntu-cxx17',
-    'factory' : LibcxxAndAbiBuilder.getLibcxxAndAbiBuilder(
-                    env={
-                        'PATH': '/usr/local/bin:/usr/bin:/bin',
-                        'CC': 'clang', 'CXX': 'clang++'},
-                    cmake_extra_opts={'LIBCXX_BENCHMARK_TEST_ARGS': benchmark_opts},
-                    use_cache='Generic-cxx17.cmake',
-                    check_libcxx_abilist=True,
-                    check_libcxx_benchmarks=True)},
-
-    {'name' : 'libcxx-libcxxabi-x86_64-linux-ubuntu-cxx2a',
-    'tags'  : ["libcxx"],
-    'workernames' : docker_workers,
-    'builddir': 'libcxx-libcxxabi-x86_64-linux-ubuntu-cxx2a',
-    'factory' : LibcxxAndAbiBuilder.getLibcxxAndAbiBuilder(
-                    env={
-                        'PATH': '/usr/local/bin:/usr/bin:/bin',
-                        'CC': 'clang', 'CXX': 'clang++'},
-                    cmake_extra_opts={'LIBCXX_BENCHMARK_TEST_ARGS': benchmark_opts},
-                    use_cache='Generic-cxx2a.cmake',
-                    check_libcxx_abilist=True,
-                    check_libcxx_benchmarks=True)},
-
-    {'name' : 'libcxx-libcxxabi-x86_64-linux-ubuntu-32bit',
-    'tags'  : ["libcxx"],
-    'workernames' : docker_workers,
-    'builddir': 'libcxx-libcxxabi-x86_64-linux-ubuntu-32bit',
-    'factory' : LibcxxAndAbiBuilder.getLibcxxAndAbiBuilder(
-                    env={
-                        'PATH': '/usr/local/bin:/usr/bin:/bin',
-                        'CC': 'clang', 'CXX': 'clang++'},
-                    use_cache='Generic-32bits.cmake',
-                    check_libcxx_abilist=False)},
-
-    {'name' : 'libcxx-libcxxabi-x86_64-linux-ubuntu-asan',
-    'tags'  : ["libcxx"],
-    'workernames' : docker_workers,
-    'builddir': 'libcxx-libcxxabi-x86_64-linux-ubuntu-asan',
-    'factory' : LibcxxAndAbiBuilder.getLibcxxAndAbiBuilder(
-                    env={
-                        'PATH': '/usr/local/bin:/usr/bin:/bin',
-                        'CC': 'clang', 'CXX': 'clang++'},
-                    cmake_extra_opts={'LIBCXX_BENCHMARK_TEST_ARGS': benchmark_opts},
-                    use_cache='Generic-asan.cmake',
-                    check_libcxx_benchmarks=True)},
-
-    {'name' : 'libcxx-libcxxabi-x86_64-linux-ubuntu-ubsan',
-    'tags'  : ["libcxx"],
-    'workernames' : docker_workers,
-    'builddir': 'libcxx-libcxxabi-x86_64-linux-ubuntu-ubsan',
-    'factory' : LibcxxAndAbiBuilder.getLibcxxAndAbiBuilder(
-                    env={
-                        'PATH': '/usr/local/bin:/usr/bin:/bin',
-                        'CC': 'clang', 'CXX': 'clang++'},
-                    cmake_extra_opts={'LIBCXX_BENCHMARK_TEST_ARGS': benchmark_opts},
-                    use_cache='Generic-ubsan.cmake',
-                    check_libcxx_benchmarks=True)},
-
-    {'name' : 'libcxx-libcxxabi-x86_64-linux-ubuntu-msan',
-    'tags'  : ["libcxx"],
-    'workernames' : docker_workers,
-    'builddir': 'libcxx-libcxxabi-x86_64-linux-ubuntu-msan',
-    'factory' : LibcxxAndAbiBuilder.getLibcxxAndAbiBuilder(
-                    env={
-                        'PATH': '/usr/local/bin:/usr/bin:/bin',
-                        'CC': 'clang', 'CXX': 'clang++'},
-                    cmake_extra_opts={'LIBCXX_BENCHMARK_TEST_ARGS': benchmark_opts},
-                    use_cache='Generic-msan.cmake',
-                    check_libcxx_benchmarks=True)},
-
-    {'name' : 'libcxx-libcxxabi-libunwind-x86_64-linux-ubuntu',
-    'tags'  : ["libcxx"],
-    'workernames' : docker_workers,
-    'builddir': 'libcxx-libcxxabi-libunwind-x86_64-linux-ubuntu',
-    'factory' : LibcxxAndAbiBuilder.getLibcxxAndAbiBuilder(
-                    env={
-                        'PATH': '/usr/local/bin:/usr/bin:/bin',
-                        'CC': 'clang', 'CXX': 'clang++'},
-                    cmake_extra_opts={'LIBCXXABI_USE_LLVM_UNWINDER': 'ON'})},
-
-    {'name' : 'libcxx-libcxxabi-x86_64-linux-ubuntu-tsan',
-    'tags'  : ["libcxx"],
-    'workernames' : docker_workers,
-    'builddir': 'libcxx-libcxxabi-x86_64-linux-ubuntu-tsan',
-    'factory' : LibcxxAndAbiBuilder.getLibcxxAndAbiBuilder(
-                    env={
-                        'PATH': '/usr/local/bin:/usr/bin:/bin',
-                        'CC': 'clang', 'CXX': 'clang++'},
-                    use_cache='Generic-tsan.cmake')},
-
-    {'name' : 'libcxx-libcxxabi-x86_64-linux-ubuntu-gcc5-cxx11',
-    'tags'  : ["libcxx"],
-    'workernames' : docker_workers,
-    'builddir': 'libcxx-libcxxabi-x86_64-linux-ubuntu-gcc5-cxx11',
-    'factory' : LibcxxAndAbiBuilder.getLibcxxAndAbiBuilder(
-                    env={
-                        'PATH': '/usr/local/bin:/usr/bin:/bin',
-                        'CC': '/opt/gcc-5/bin/gcc', 'CXX': '/opt/gcc-5/bin/g++'},
-                    use_cache='Generic-cxx11.cmake',
-                    lit_extra_opts={'enable_warnings': 'False'})},
-
-    {'name' : 'libcxx-libcxxabi-x86_64-linux-ubuntu-gcc-tot-latest-std',
-    'tags'  : ["libcxx"],
-    'workernames' : docker_workers,
-    'builddir': 'libcxx-libcxxabi-x86_64-linux-ubuntu-gcc-tot-latest-std',
-    'factory' : LibcxxAndAbiBuilder.getLibcxxAndAbiBuilder(
-                    env={
-                        'PATH': '/usr/local/bin:/usr/bin:/bin',
-                        'CC': '/opt/gcc-tot/bin/gcc', 'CXX': '/opt/gcc-tot/bin/g++'})},
-
     # ARMv7 LibC++ and LibC++abi tests (require Clang+RT)
     {'name' : 'libcxx-libcxxabi-libunwind-armv7-linux',
     'tags'  : ["libcxx"],
     'workernames': ['linaro-tk1-02'],
     'builddir': 'libcxx-libcxxabi-libunwind-armv7-linux',
     'factory' : LibcxxAndAbiBuilder.getLibcxxAndAbiBuilder(
                     cmake_extra_opts={
                         'LIBCXXABI_USE_LLVM_UNWINDER': 'ON',