Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Project - Commits
- rGae4dad2b731e: [libc++] Add a CI job to test libc++ when building for 32 bit
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Rebase to trigger CI again. The docker images should be updated and CI should pass now.
Comment Actions
I suppose that these 2 tests were always failing on 32-bit.
The old builder history doesn't go very far, but it shows these tests always failing: http://lab.llvm.org:8011/#/builders/34?numbuilds=300.
Not sure if it was intended or not, but it seems that trivial_abi is only tested on arm64-apple-ios11 triple.
Cf. D41039.
Comment Actions
FYI, https://bugs.llvm.org/show_bug.cgi?id=48939.
I think these two failing tests should be disabled on 32-bit x86.
I'm pretty sure for weak_ptr_ret.pass.cpp, cf.:
#ifndef __arm__ // On ARM32, structs larger than 4 bytes cannot be returned in registers. // Thus, weak_ptr will be passed indrectly even if it is trivial. assert((void*)&ret != local_addr); #endif
Not sure for unique_ptr_ret.pass.cpp though.