Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| mlir/include/mlir/Dialect/Linalg/Utils/Utils.h | ||
|---|---|---|
| 120 | nit: Maybe a comment to explain what is the shape of an op ? | |
| mlir/include/mlir/Dialect/Linalg/Utils/Utils.h | ||
|---|---|---|
| 120 | It says its the static version of the getShape method above. That explains what shape is. | |
| mlir/lib/Dialect/Linalg/Utils/Utils.cpp | ||
| 162 | The comment in the header files says it returns -1 for the dynamic shapes. Might worth returning that in case clients want to check which dim is dynamic. | |
nit: Maybe a comment to explain what is the shape of an op ?