Page MenuHomePhabricator

[PowerPC] Handle FP physical register in inline asm constraint.
ClosedPublic

Authored by sfertile on Nov 17 2020, 7:06 AM.

Details

Summary

Do not defer to the base class when the register constraint is a physical fpr. The base class will select SPILLTOVSX as the register class and register allocation will fail on subtargets without VSX registers.

Diff Detail

Event Timeline

sfertile created this revision.Nov 17 2020, 7:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 17 2020, 7:06 AM
sfertile requested review of this revision.Nov 17 2020, 7:06 AM
ZarkoCA accepted this revision.Wed, Feb 10, 1:19 PM

LGTM, only some question about a comment.

llvm/lib/Target/PowerPC/PPCISelLowering.cpp
15111

I think this should be SPILLTOVSRRC instead of SPILLTOVSX

This revision is now accepted and ready to land.Wed, Feb 10, 1:19 PM
This revision was landed with ongoing or failed builds.Wed, Feb 17, 6:29 AM
This revision was automatically updated to reflect the committed changes.