[mlir] Simplify std.alloc lowering to LLVM.
ClosedPublic
Actions

Authored by csigg on Nov 16 2020, 8:32 AM.

Details

Reviewers

nicolasvasilache
mravishankar
antiagainst
ftynse

Commits

rGbedaad44953a: [mlir] Simplify std.alloc lowering to LLVM.

Summary

std.alloc only supports memrefs with identity layout, which means we can simplify the lowering to LLVM and compute strides only from (static and dynamic) sizes.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

csigg created this revision.Nov 16 2020, 8:32 AM

Herald added a reviewer: mravishankar. · View Herald TranscriptNov 16 2020, 8:32 AM

Herald added a reviewer: antiagainst. · View Herald Transcript

Herald added a reviewer: ftynse. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: teijeong, rdzhabarov, tatianashp and 17 others. · View Herald Transcript

csigg requested review of this revision.Nov 16 2020, 8:32 AM

Herald added a subscriber: stephenneuendorffer. · View Herald TranscriptNov 16 2020, 8:32 AM

Harbormaster completed remote builds in B78972: Diff 305531.Nov 16 2020, 9:18 AM

Nice!

mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h
525	Nit: could we also document that it emits instructions necessary to compute the strides and the total size?
mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
1115	Cool trick!
1139–1140	This seems like it would properly support cases with vectors due to padding an alignment, e.g., `memref<4 x vector<3 x f32>>`, right?

This revision is now accepted and ready to land.Nov 17 2020, 5:45 AM

Extend documentation.

csigg marked an inline comment as done.Nov 17 2020, 9:02 AM

csigg added inline comments.

mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
1115	It's a shame that clang-tidy doesn't format the goes-to operator correctly.
1139–1140	Yes, see for example the `%t4` example here: https://llvm.org/docs/LangRef.html#getelementptr-instruction