[llvm-readobj] [ARMWinEH] Clearly print an invalid case of packed unwind info as such

[mstorsjo]

Summary

As the actual windows unwinder doesn't support this case, don't pretend that it is supported when dumping the generated unwind info either, even if it would be possible to interpret it as something sensible.

This should reduce the risk of us emitting such a case in code (although it's unlikely as long as the unwind info is generated through the SEH opcodes, as the opcodes can't describe this case).

[mstorsjo]

Ping - as @efriedma doesn't seem to be around much at the moment, could maybe @rnk give this one an ack?

[rnk]

lgtm

llvm/test/tools/llvm-readobj/COFF/arm64-packed-unwind.s

 // CHECK-NEXT:     FunctionLength: 24
 // CHECK-NEXT:     RegF: 0
 // CHECK-NEXT:     RegI: 1
 // CHECK-NEXT:     HomedParameters: No
 // CHECK-NEXT:     CR: 1
 // CHECK-NEXT:     FrameSize: 32
 // CHECK-NEXT:     Prologue [
 // CHECK-NEXT:       sub sp, sp, #16
-// CHECK-NEXT:       stp x19, lr, [sp, #-16]!
+// CHECK-NEXT:       INVALID!
 // CHECK-NEXT:       end
 // CHECK-NEXT:     ]
 // CHECK-NEXT:   }
 // CHECK-NEXT:   RuntimeFunction {
 // CHECK-NEXT:     Function: func9
 // CHECK-NEXT:     Fragment: No
 // CHECK-NEXT:     FunctionLength: 32
 // CHECK-NEXT:     RegF: 0

llvm/tools/llvm-readobj/ARMWinEHPrinter.cpp

       SW.startLine() << format("str lr, [sp, #-%d]!\n", SavSZ);
     else
       SW.startLine() << format("str lr, [sp, #%d]\n", IntSZ - 8);
   }
   for (int I = (RF.RegI() + 1) / 2 - 1; I >= 0; I--) {
     if (I == (RF.RegI() + 1) / 2 - 1 && RF.RegI() % 2 == 1) {
       // The last register, an odd register without a pair
       if (RF.CR() == 1) {
-        if (I == 0) // If this is the only register pair
-          SW.startLine() << format("stp x%d, lr, [sp, #-%d]!\n", 19 + 2 * I,
-                                   SavSZ);
-        else
+        if (I == 0) { // If this is the only register pair
+          // CR=1 combined with RegI=1 doesn't map to a documented case;
+          // it doesn't map to any regular unwind info opcode, and the
+          // actual unwinder doesn't support it.
+          SW.startLine() << "INVALID!\n";
+        } else
           SW.startLine() << format("stp x%d, lr, [sp, #%d]\n", 19 + 2 * I,
                                    16 * I);
       } else {
         if (I == 0)
           SW.startLine() << format("str x%d, [sp, #-%d]!\n", 19 + 2 * I, SavSZ);
         else
           SW.startLine() << format("str x%d, [sp, #%d]\n", 19 + 2 * I, 16 * I);
       }