This is an archive of the discontinued LLVM Phabricator instance.

Differential D91520

[MachO] Fix enum-int mismatch warning
ClosedPublic

Authored by ehjogab on Nov 16 2020, 12:57 AM.

Details

Reviewers
dsanders
arsenm
qcolombet
ab
bjope
rovka
Commits
rG496fb70b141c: [MachO] Fix enum-int mismatch warning
Summary

Change-Id: Ie637dc7761144e5552b05a9c286f1e736579823d

Diff Detail

Event Timeline

ehjogab created this revision.Nov 16 2020, 12:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2020, 12:57 AM
ehjogab requested review of this revision.Nov 16 2020, 12:57 AM
Herald added a subscriber: wdng. · View Herald TranscriptNov 16 2020, 12:57 AM
Harbormaster completed remote builds in B78929: Diff 305425.Nov 16 2020, 1:24 AM
arsenm accepted this revision.Dec 24 2020, 7:48 AM
This revision is now accepted and ready to land.Dec 24 2020, 7:48 AM
Closed by commit rG496fb70b141c: [MachO] Fix enum-int mismatch warning (authored by ehjogab, committed by uabelho). · Explain WhyDec 28 2020, 8:40 AM
This revision was automatically updated to reflect the committed changes.
uabelho added a commit: rG496fb70b141c: [MachO] Fix enum-int mismatch warning.
uabelho added a subscriber: uabelho.Dec 28 2020, 8:40 AM

I submitted this for @ehjogab

Revision Contents

PathSize
lld/
lib/
ReaderWriter/
MachO/
2 lines

Diff 313859

lld/lib/ReaderWriter/MachO/MachONormalizedFileFromAtoms.cpp

Show First 20 Lines • Show All 1,555 Lines • ▼ Show 20 Lines for (const AtomInfo &info : sect->atomsAndOffsets) {
nFile.exportInfo.push_back(exprt); nFile.exportInfo.push_back(exprt);
} }
} }
} }
uint32_t Util::fileFlags() { uint32_t Util::fileFlags() {
// FIXME: these need to determined at runtime. // FIXME: these need to determined at runtime.
if (_ctx.outputMachOType() == MH_OBJECT) { if (_ctx.outputMachOType() == MH_OBJECT) {
return _subsectionsViaSymbols ? MH_SUBSECTIONS_VIA_SYMBOLS : 0; return _subsectionsViaSymbols ? (uint32_t)MH_SUBSECTIONS_VIA_SYMBOLS : 0;
} else { } else {
uint32_t flags = MH_DYLDLINK; uint32_t flags = MH_DYLDLINK;
if (!_ctx.useFlatNamespace()) if (!_ctx.useFlatNamespace())
flags |= MH_TWOLEVEL | MH_NOUNDEFS; flags |= MH_TWOLEVEL | MH_NOUNDEFS;
if ((_ctx.outputMachOType() == MH_EXECUTE) && _ctx.PIE()) if ((_ctx.outputMachOType() == MH_EXECUTE) && _ctx.PIE())
flags |= MH_PIE; flags |= MH_PIE;
if (_hasTLVDescriptors) if (_hasTLVDescriptors)
flags |= (MH_PIE | MH_HAS_TLV_DESCRIPTORS); flags |= (MH_PIE | MH_HAS_TLV_DESCRIPTORS);
▲ Show 20 Lines • Show All 85 Lines • Show Last 20 Lines