Page MenuHomePhabricator

MLIR: add SinOp Lowering to __ocml_sin_f32 and __ocml_sin_f64
ClosedPublic

Authored by akuegel on Nov 11 2020, 5:18 AM.

Details

Summary

This mimics the recent similar patch for GPUToNVVM.

Diff Detail

Event Timeline

akuegel created this revision.Nov 11 2020, 5:18 AM
akuegel requested review of this revision.Nov 11 2020, 5:18 AM

Thanks for fixing this!

Can you use [mlir][gpu] in the subject and make it clear that this applies to the rocm lowering only?

mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
75

Just wondering, why is there no TanOp here? Could you add this, as well?

118

Can you keep these sorted?

akuegel updated this revision to Diff 304490.Nov 11 2020, 5:29 AM

Address review comments.

akuegel marked an inline comment as done.Nov 11 2020, 5:30 AM

Thanks for the review comments :)

mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
75

Yes, looks like this was an oversight. I have added it now as well.

herhut accepted this revision.Nov 11 2020, 5:32 AM

Thank you!

This revision is now accepted and ready to land.Nov 11 2020, 5:32 AM
This revision was landed with ongoing or failed builds.Nov 11 2020, 5:39 AM
This revision was automatically updated to reflect the committed changes.