Page MenuHomePhabricator

[mlir] Fix exports in mlir_async_runtime.
ClosedPublic

Authored by plietar on Nov 10 2020, 11:41 AM.

Details

Summary

The MLIR_ASYNCRUNTIME_EXPORT macro was being defined to be either __declspec(dllexport) or __declspec(dllimport), depending on whether
mlir_c_runner_utils_EXPORTS is defined. The latter was a copy/paste error and should have been mlir_async_runtime_EXPORTS.

Additionally, the uses of that macro in the .cpp file were unnecessary, as only function declarations need to be exported, not their definitions.

Diff Detail

Event Timeline

plietar created this revision.Nov 10 2020, 11:41 AM
plietar requested review of this revision.Nov 10 2020, 11:41 AM
ezhulenev accepted this revision.Nov 10 2020, 1:34 PM

Thanks!

This revision is now accepted and ready to land.Nov 10 2020, 1:34 PM
plietar edited the summary of this revision. (Show Details)Nov 11 2020, 12:54 AM
plietar retitled this revision from Fix exports in mlir_async_runtime. to [mlir] Fix exports in mlir_async_runtime..Nov 11 2020, 3:36 AM
This revision was automatically updated to reflect the committed changes.