We used cast where we should use dyn_cast. So, change it this time.
Old code cause problems if I implement brind instruction and compile
openmp using new compiler.
Details
Details
- Reviewers
simoll k-ishizaka jdoerfert - Commits
- rG543b30db06bf: [VE][NFC] Change cast to dyn_cast
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Can you add a test case for this change?
If this change is not testable (eg: if all "Addr" that can reach this code are ConstantSDNodes) then it may be more suitable to remove the conditional and leave the cast in until code is committed that makes this live - that way we can be sure test coverage is added when the code is added.