[SmallVector] Add range versions of append/assign.

[silvas]

Summary

These are convenient in a lot of cases, such as when the thing you want
to append/assign is someReallyLongFunctionName() that you'd rather not
write twice or assign to a variable for the paired begin/end calls.

[mehdi_amini]

LGTM, but it be nice to have another reviewer checking this!

[dblaikie]

Maybe these would be more effective as generic range-based functions? (is "append(begin, end)" part of the container concept? Not 100% clear to me on a quick check) - would make it usable with a variety of containers in one go instead of adding it to individual containers (& not being able to add it to standard containers)?

[silvas]

This comment was removed by silvas.

[dexonsmith]

In D90882#2377636, @silvas wrote:

Use 64 byte fixed upper limit.

Did you intend to update https://reviews.llvm.org/D90884?

[silvas]

update

[silvas]

In D90882#2377643, @dexonsmith wrote:

In D90882#2377636, @silvas wrote:

Use 64 byte fixed upper limit.

Did you intend to update https://reviews.llvm.org/D90884?

Yeah, sorry. My scripts crossed the streams somehow.

[silvas]

In D90882#2377528, @dblaikie wrote:

Maybe these would be more effective as generic range-based functions? (is "append(begin, end)" part of the container concept? Not 100% clear to me on a quick check) - would make it usable with a variety of containers in one go instead of adding it to individual containers (& not being able to add it to standard containers)?

Good point! I added such a function to STLExtras.h here: https://reviews.llvm.org/D90894
(I didn't add one for "assign" since I didn't have an immediate use case. I handled it in assign for this patch for consistency since it seemed there was parallel functionality there for SmallVector in particular)

[silvas]

Abandoning. Replaced by https://reviews.llvm.org/D90894

llvm/include/llvm/ADT/SmallVector.h

void append(size_type NumInputs, const T &Elt) {
     std::uninitialized_fill_n(this->end(), NumInputs, Elt);
     this->set_size(this->size() + NumInputs);
   }
 
   void append(std::initializer_list<T> IL) {
     append(IL.begin(), IL.end());
   }
 
+  template <typename ContainerTy> void append(ContainerTy &&C) {
+    append(C.begin(), C.end());
+  }
+
   // FIXME: Consider assigning over existing elements, rather than clearing &
   // re-initializing them - for all assign(...) variants.
 
   void assign(size_type NumElts, const T &Elt) {
     clear();
     if (this->capacity() < NumElts)
       this->grow(NumElts);
     this->set_size(NumElts);
void assign(in_iter in_start, in_iter in_end) {
     append(in_start, in_end);
   }
 
   void assign(std::initializer_list<T> IL) {
     clear();
     append(IL);
   }
 
+  template <typename ContainerTy> void assign(ContainerTy &&C) {
+    assign(C.begin(), C.end());
+  }
+
   iterator erase(const_iterator CI) {
     // Just cast away constness because this is a non-const member function.
     iterator I = const_cast<iterator>(CI);
 
     assert(I >= this->begin() && "Iterator to erase is out of bounds.");
     assert(I < this->end() && "Erasing at past-the-end iterator.");
 
     iterator N = I;

llvm/unittests/ADT/SmallVectorTest.cpp

 TYPED_TEST(SmallVectorTest, AppendNonIterTest) {
   SCOPED_TRACE("AppendRepeatedTest");
 
   this->theVector.push_back(Constructable(1));
   this->theVector.append(2, 7);
   this->assertValuesInOrder(this->theVector, 3u, 1, 7, 7);
 }
 
+// Append container test.
+TYPED_TEST(SmallVectorTest, AppendContainerTest) {
+  SCOPED_TRACE("AppendContainerTest");
+
+  std::array<Constructable, 2> Array = {1, 2};
+  std::vector<Constructable> Vector = {3, 4};
+  ArrayRef<Constructable> TheArrayRef(Vector);
+
+  this->theVector.append(Array);
+  this->theVector.append(Vector);
+  this->theVector.append(TheArrayRef);
+  this->assertValuesInOrder(this->theVector, 6u, 1, 2, 3, 4, 3, 4);
+}
+
 struct output_iterator {
   typedef std::output_iterator_tag iterator_category;
   typedef int value_type;
   typedef int difference_type;
   typedef value_type *pointer;
   typedef value_type &reference;
   operator int() { return 2; }
   operator Constructable() { return 7; }

 TYPED_TEST(SmallVectorTest, AssignNonIterTest) {
   SCOPED_TRACE("AssignTest");
 
   this->theVector.push_back(Constructable(1));
   this->theVector.assign(2, 7);
   this->assertValuesInOrder(this->theVector, 2u, 7, 7);
 }
 
+// Assign container test.
+TYPED_TEST(SmallVectorTest, AssignContainerTest) {
+  SCOPED_TRACE("AssignContainerTest");
+
+  std::array<Constructable, 2> Array = {1, 2};
+  std::vector<Constructable> Vector = {3, 4};
+  ArrayRef<Constructable> TheArrayRef(Vector);
+
+  this->theVector.assign(Array);
+  this->assertValuesInOrder(this->theVector, 2u, 1, 2);
+  this->theVector.assign(Vector);
+  this->assertValuesInOrder(this->theVector, 2u, 3, 4);
+  this->theVector.assign(TheArrayRef);
+  this->assertValuesInOrder(this->theVector, 2u, 3, 4);
+}
+
 // Move-assign test
 TYPED_TEST(SmallVectorTest, MoveAssignTest) {
   SCOPED_TRACE("MoveAssignTest");
 
   // Set up our vector with a single element, but enough capacity for 4.
   this->theVector.reserve(4);
   this->theVector.push_back(Constructable(1));