[MLIR] Remove NoSideEffect from std.global_memref op.

[jurahul]

Summary

• Also spell "isUninitialized" correctly.

mlir/include/mlir/Dialect/StandardOps/IR/Ops.td

def FPTruncOp : CastOp<"fptrunc">, Arguments<(ins AnyType:$in)> {
 
   let hasFolder = 0;
 }
 
 //===----------------------------------------------------------------------===//
 // GlobalMemrefOp
 //===----------------------------------------------------------------------===//
 
-def GlobalMemrefOp : Std_Op<"global_memref", [NoSideEffect, Symbol]> {
+def GlobalMemrefOp : Std_Op<"global_memref", [Symbol]> {
   let summary = "declare or define a global memref variable";
   let description = [{
     The `global_memref` operation declares or defines a named global variable.
     The backing memory for the variable is allocated statically and is described
     by the type of the variable (which should be a statically shaped memref
     type). The operation is a declaration if no `inital_value` is specified,
     else it is a definition. The `initial_value` can either be a unit attribute
     to represent a definition of an uninitialized global variable, or an
let assemblyFormat = [{
        (`constant` $constant^)?
        $sym_name `:`
        custom<GlobalMemrefOpTypeAndInitialValue>($type, $initial_value)
        attr-dict
   }];
 
   let extraClassDeclaration = [{
      bool isExternal() { return !initial_value(); }
-     bool isUnitialized() {
+     bool isUninitialized() {
        return !isExternal() && initial_value().getValue().isa<UnitAttr>();
      }
   }];
 }
 
 //===----------------------------------------------------------------------===//
 // GetGlobalMemrefOp
 //===----------------------------------------------------------------------===//

mlir/lib/Dialect/StandardOps/IR/Ops.cpp

 
 static void printGlobalMemrefOpTypeAndInitialValue(OpAsmPrinter &p,
                                                    GlobalMemrefOp op,
                                                    TypeAttr type,
                                                    Attribute initialValue) {
   p << type;
   if (!op.isExternal()) {
     p << " = ";
-    if (op.isUnitialized())
+    if (op.isUninitialized())
       p << "uninitialized";
     else
       p.printAttributeWithoutType(initialValue);
   }
 }
 
 static ParseResult
 parseGlobalMemrefOpTypeAndInitialValue(OpAsmParser &parser, TypeAttr &typeAttr,