Separate the AMDGPU memory model description into separate sections
for each architecture.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Time | Test | |
---|---|---|
390 ms | linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp |
Event Timeline
- Unify further similar rows.
- Clarify s_waicnt lgkmcnt(0) at workgroup scope to ensure LDS operation is complete.
Some small nits, and a note that we had discussed already about widening the table
llvm/docs/AMDGPUUsage.rst | ||
---|---|---|
4151 | management | |
4151 | instructions | |
4192 | accesses | |
4224 | Remove extra space | |
4229 | Remove extra space | |
4307 | used | |
4309 | Should this be either "constant" or const (not sure how to include literal backticks in Phabricator markup) | |
4384 | Can avoid wrapping this | |
4837–4846 | It can be something we do down the line, but I think making the table wider would make it easier to digest. My screen is wider than it is tall, so I would gladly sacrifice some horizontal real-estate in order to see each row in its entirety without scrolling. This would also make it easier to read some of these longer bullets, and it would compress the number of lines in the file each table takes up. For example, wrapping at 120 columns this table shrinks from ~1200 source lines to ~600. | |
5560 | used | |
5562 | Same question as above | |
5769 | Is the change from "the" to "a" significant? | |
5900 | Same question here | |
6300 | Redundant, delete | |
6395 | lgkmcnt |
management