Page MenuHomePhabricator

[clangd] Respect codeAction.isPreferredSupport in client capabilities
AcceptedPublic

Authored by kadircet on Oct 30 2020, 3:44 AM.

Diff Detail

Event Timeline

kadircet created this revision.Oct 30 2020, 3:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 30 2020, 3:44 AM
kadircet requested review of this revision.Oct 30 2020, 3:44 AM
adamcz accepted this revision.Oct 30 2020, 5:17 AM
This revision is now accepted and ready to land.Oct 30 2020, 5:17 AM

Hang on - why do we need to do this?

In general we don't do client feature detection for every piece of functionality we have, only when it causes us to behave incompatibly.
And again in general we assume that setting extra properties on JSON objects is compatible. (e.g. score extensions on code completion).

I hadn't seen the bug, will ask here what the problem is.