Page MenuHomePhabricator
Differential D90370

[mlir][gpu] Fix leaked stream and module when lowering gpu.launch_func to runtime calls.
ClosedPublic
Actions

Authored by csigg on Oct 29 2020, 12:18 AM.

Details

Reviewers
ftynse
herhut
mehdi_amini
Commits
rG97b351a82767: [mlir][gpu] Fix leaked stream and module when lowering gpu.launch_func to…

Diff Detail

Event Timeline

csigg created this revision.Oct 29 2020, 12:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 29 2020, 12:18 AM
Herald added subscribers: rdzhabarov, tatianashp, msifontes and 14 others. · View Herald Transcript
csigg requested review of this revision.Oct 29 2020, 12:18 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptOct 29 2020, 12:18 AM
mehdi_amini accepted this revision.Oct 29 2020, 12:38 AM
This revision is now accepted and ready to land.Oct 29 2020, 12:38 AM
Harbormaster completed remote builds in B76871: Diff 301530.Oct 29 2020, 12:40 AM
Closed by commit rG97b351a82767: [mlir][gpu] Fix leaked stream and module when lowering gpu.launch_func to… (authored by csigg). · Explain WhyOct 29 2020, 12:41 AM
This revision was automatically updated to reflect the committed changes.
csigg added a commit: rG97b351a82767: [mlir][gpu] Fix leaked stream and module when lowering gpu.launch_func to….
csigg added a comment.Oct 29 2020, 12:41 AM

Thanks Mehdi for the quick review!

Revision Contents
Changeset List

PathSize
mlir/
lib/
Conversion/
GPUCommon/
4 lines
test/
Conversion/
GPUCommon/
2 lines
tools/
mlir-cuda-runner/
4 lines
mlir-rocm-runner/
4 lines

Diff 301532

View Options

mlir/lib/Conversion/GPUCommon/ConvertLaunchFuncToRuntimeCalls.cpp

Loading...
View Options

mlir/test/Conversion/GPUCommon/lower-launch-func-to-gpu-runtime-calls.mlir

Loading...
View Options

mlir/tools/mlir-cuda-runner/cuda-runtime-wrappers.cpp

Loading...
View Options

mlir/tools/mlir-rocm-runner/rocm-runtime-wrappers.cpp

Loading...