Page MenuHomePhabricator

[mlir][Bufferize] Rename TestBufferPlacement to TestFinalizingBufferize
ClosedPublic

Authored by silvas on Oct 22 2020, 12:51 PM.

Details

Summary

NOTE: this is an updated version of https://reviews.llvm.org/D89923

BufferPlacement is no longer part of bufferization. However, this test
is an important test of "finalizing" bufferize passes.
A "finalizing" bufferize conversion is one that performs a "full"
conversion and expects all tensors to be gone from the program. This in
particular involves rewriting funcs (including block arguments of the
contained region), calls, and returns. The unique property of finalizing
bufferization passes is that they cannot be done via a local
transformation with suitable materializations to ensure composability
(as other bufferization passes do). For example, if a call is
rewritten, the callee needs to be rewritten otherwise the IR will end up
invalid. Thus, finalizing bufferization passes require an atomic change
to the entire program (e.g. the whole module).

This new designation makes it clear also that it shouldn't be testing
bufferization of linalg ops, so the tests have been updated to not use
linalg.generic ops. (linalg.copy is still used as the "copy" op for
copying into out-params)

Diff Detail

Event Timeline

silvas created this revision.Oct 22 2020, 12:51 PM
silvas requested review of this revision.Oct 22 2020, 12:51 PM
silvas edited the summary of this revision. (Show Details)
silvas edited the summary of this revision. (Show Details)
silvas edited the summary of this revision. (Show Details)
dfki-albo accepted this revision.Mon, Nov 2, 1:01 AM

Some of the updated tests dont do anything useful anymore. @dfki-heme and I, we refactored the tests in https://reviews.llvm.org/D90037. The renaming should be fine.

This revision is now accepted and ready to land.Mon, Nov 2, 1:01 AM