Page MenuHomePhabricator

dfki-mako (Marcel Koester)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 9 2020, 1:29 AM (46 w, 6 d)

Recent Activity

Thu, Nov 12

dfki-mako accepted D91360: [mlir][bufferize] Fix buffer promotion to stack for index types.
Thu, Nov 12, 2:33 PM · Restricted Project
dfki-mako accepted D90899: [mlir] Add DecomposeCallGraphTypes pass..

Awesome work 🚀 I don't see any problems to land this CL after addressing the nits 🤓

Thu, Nov 12, 1:28 AM · Restricted Project

Wed, Nov 11

dfki-mako accepted D90675: [MLIR] Added documentation and manual to use bufferization features..
Wed, Nov 11, 6:31 AM · Restricted Project

Fri, Nov 6

dfki-mako added reviewers for D90899: [mlir] Add DecomposeCallGraphTypes pass.: dfki-albo, dfki-heme.
Fri, Nov 6, 7:45 AM · Restricted Project

Thu, Nov 5

dfki-mako added a reviewer for D90675: [MLIR] Added documentation and manual to use bufferization features.: mehdi_amini.
Thu, Nov 5, 1:33 AM · Restricted Project
dfki-mako accepted D90778: [mlir] Remove AppendToArgumentsList functionality from BufferizeTypeConverter..
Thu, Nov 5, 1:10 AM · Restricted Project
dfki-mako added a comment to D89990: [mlir] Remove notion of "decompose values" from BufferizeTypeConverter.

Actually, it sounds like the direction we want to go with this is to split this functionality out. I'll do that in a separate patch.

Thu, Nov 5, 1:09 AM · Restricted Project

Oct 30 2020

dfki-mako added inline comments to D90205: [mlir] Add func-bufferize pass..
Oct 30 2020, 4:07 PM · Restricted Project

Oct 29 2020

dfki-mako accepted D90071: [mlir] Add BufferResultsToOutParams pass..
Oct 29 2020, 5:39 PM · Restricted Project
dfki-mako added a comment to D90071: [mlir] Add BufferResultsToOutParams pass..

Awesome work +1. I guess this should be ready to go after replacing some autos with their underlying types.

Oct 29 2020, 3:58 PM · Restricted Project
dfki-mako added inline comments to D90071: [mlir] Add BufferResultsToOutParams pass..
Oct 29 2020, 3:55 PM · Restricted Project
dfki-mako added a comment to D90071: [mlir] Add BufferResultsToOutParams pass..

For example, FunctionLike doesn't guarantee that the op has a FunctionType, so all the code here where we modify the function type can't be written generically (see this thread for a similar issue:

Unfortunately, we cannot use this trait for the reasons you mentioned.

Oct 29 2020, 3:52 PM · Restricted Project

Oct 28 2020

dfki-mako requested changes to D90071: [mlir] Add BufferResultsToOutParams pass..
Oct 28 2020, 5:42 AM · Restricted Project
dfki-mako added a comment to D90071: [mlir] Add BufferResultsToOutParams pass..

I guess this approach introduces a limitation with respect to applicability to arbitrary dialects. We are now able to match ReturnOp and CallOps only while the previous version supported a generic customization to arbitrary dialects, right?
I would recommend that we should try to match CallOpInterface and ReturnLike implementations to make this code more generic in favor of standard CallOp and ReturnOp-based matchers from the Std dialect.

Oct 28 2020, 5:41 AM · Restricted Project

Oct 27 2020

dfki-mako added inline comments to D90071: [mlir] Add BufferResultsToOutParams pass..
Oct 27 2020, 4:41 PM · Restricted Project
dfki-mako added a comment to D89990: [mlir] Remove notion of "decompose values" from BufferizeTypeConverter.

The basic idea behind these generic type converts was to provide a highly customizable way to decompose and rewrite tuple types.
However, if there are no real users and as you are currently refactoring these parts into a separate pass anyway, it might be a good idea to simplify these conversion patterns.
See this CL for additional comments on the general refactoring process.

Oct 27 2020, 4:24 PM · Restricted Project

Oct 19 2020

dfki-mako committed rG1b1c61ff47f8: [mlir] Refactored BufferPlacement transformation. (authored by dfki-mako).
[mlir] Refactored BufferPlacement transformation.
Oct 19 2020, 3:55 AM
dfki-mako closed D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting..
Oct 19 2020, 3:54 AM · Restricted Project

Oct 16 2020

dfki-mako updated the diff for D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting..

Addressed reviewer comments.

Oct 16 2020, 3:46 AM · Restricted Project

Oct 14 2020

dfki-mako added inline comments to D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting..
Oct 14 2020, 6:06 AM · Restricted Project
dfki-mako updated the diff for D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting..

Refactored code and addressed reviewer comments.

Oct 14 2020, 6:06 AM · Restricted Project

Oct 13 2020

dfki-mako accepted D89271: [mlir][bufferize] Rename BufferAssignment* to Bufferize*.
Oct 13 2020, 4:33 AM · Restricted Project
dfki-mako updated the diff for D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting..

Refined all parts of this PR and addressed all reviewer comments.

Oct 13 2020, 4:24 AM · Restricted Project

Sep 30 2020

dfki-mako added inline comments to D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting..
Sep 30 2020, 7:39 AM · Restricted Project
dfki-mako updated the diff for D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting..

Addressed reviewer comments and changed the BufferAllocationHoisting pass to pay attention to escaping buffers via backedges.

Sep 30 2020, 7:37 AM · Restricted Project

Sep 16 2020

dfki-mako added reviewers for D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting.: herhut, pifon2a.
Sep 16 2020, 3:53 AM · Restricted Project
dfki-mako requested review of D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting..
Sep 16 2020, 3:51 AM · Restricted Project

Sep 9 2020

dfki-mako committed rGfeb0b9c3bba7: [mlir] Added support for loops to BufferPlacement transformation. (authored by dfki-mako).
[mlir] Added support for loops to BufferPlacement transformation.
Sep 9 2020, 1:55 AM
dfki-mako closed D85513: [mlir] Added support for loops in BufferPlacement transformation..
Sep 9 2020, 1:55 AM · Restricted Project

Sep 8 2020

dfki-mako added inline comments to D85513: [mlir] Added support for loops in BufferPlacement transformation..
Sep 8 2020, 2:06 AM · Restricted Project
dfki-mako updated the diff for D85513: [mlir] Added support for loops in BufferPlacement transformation..

Addressed reviewer comments regarding tests, comments and invariants.

Sep 8 2020, 2:06 AM · Restricted Project

Sep 2 2020

dfki-mako retitled D85513: [mlir] Added support for loops in BufferPlacement transformation. from [mlir] WIP: Added support for loops in BufferPlacement transformation. to [mlir] Added support for loops in BufferPlacement transformation..
Sep 2 2020, 3:46 AM · Restricted Project
dfki-mako added inline comments to D85513: [mlir] Added support for loops in BufferPlacement transformation..
Sep 2 2020, 3:46 AM · Restricted Project

Aug 25 2020

dfki-mako updated the diff for D85513: [mlir] Added support for loops in BufferPlacement transformation..

Completed support for loops using structured control flow and addressed reviewer comments.

Aug 25 2020, 2:53 AM · Restricted Project

Aug 7 2020

dfki-mako retitled D85513: [mlir] Added support for loops in BufferPlacement transformation. from [mlir] Added support for loops in BufferPlacement transformation. to [mlir] WIP: Added support for loops in BufferPlacement transformation..
Aug 7 2020, 3:39 AM · Restricted Project
dfki-mako requested review of D85513: [mlir] Added support for loops in BufferPlacement transformation..
Aug 7 2020, 3:39 AM · Restricted Project

Jun 26 2020

dfki-mako added inline comments to D81926: [mlir] Extended BufferPlacement to support nested region control flow..
Jun 26 2020, 4:52 AM · Restricted Project
dfki-mako updated the diff for D81926: [mlir] Extended BufferPlacement to support nested region control flow..

Addressed reviewer comments.

Jun 26 2020, 4:51 AM · Restricted Project

Jun 25 2020

dfki-mako updated the diff for D81926: [mlir] Extended BufferPlacement to support nested region control flow..

Added support for region-region control flow within operations that implement the RegionBranchOpInterface.
Added new test operations to verify more advanced region-region control-flow scenarios.

Jun 25 2020, 3:44 AM · Restricted Project

Jun 24 2020

dfki-mako retitled D81926: [mlir] Extended BufferPlacement to support nested region control flow. from [mlir] WIP: Extended BufferPlacement to support nested region control flow. to [mlir] Extended BufferPlacement to support nested region control flow..
Jun 24 2020, 4:16 AM · Restricted Project

Jun 23 2020

dfki-mako added inline comments to D81926: [mlir] Extended BufferPlacement to support nested region control flow..
Jun 23 2020, 6:21 AM · Restricted Project
dfki-mako updated the diff for D81926: [mlir] Extended BufferPlacement to support nested region control flow..

Refactored implementation and simplified the iteration over all successor regions.

Jun 23 2020, 6:21 AM · Restricted Project

Jun 19 2020

dfki-mako updated the diff for D81926: [mlir] Extended BufferPlacement to support nested region control flow..

Added extended support for the RegionOpInterface to query successor bindings for successor regions

Jun 19 2020, 5:53 AM · Restricted Project

Jun 17 2020

dfki-mako retitled D81926: [mlir] Extended BufferPlacement to support nested region control flow. from [mlir] Extended BufferPlacement to support nested region control flow. to [mlir] WIP: Extended BufferPlacement to support nested region control flow..
Jun 17 2020, 4:16 AM · Restricted Project

Jun 16 2020

dfki-mako added reviewers for D81926: [mlir] Extended BufferPlacement to support nested region control flow.: pifon2a, herhut.
Jun 16 2020, 4:23 AM · Restricted Project
dfki-mako created D81926: [mlir] Extended BufferPlacement to support nested region control flow..
Jun 16 2020, 4:23 AM · Restricted Project

Jun 15 2020

dfki-mako committed rG33879aa0bf00: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS. (authored by dfki-mako).
[mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS.
Jun 15 2020, 7:01 AM
dfki-mako closed D81839: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS..
Jun 15 2020, 7:01 AM · Restricted Project
dfki-mako updated the diff for D81839: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS..

Refactored access to getSuccessorOperands to distinguish between read-only and write-enabled accesses.

Jun 15 2020, 6:28 AM · Restricted Project
dfki-mako added inline comments to D81839: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS..
Jun 15 2020, 6:28 AM · Restricted Project
dfki-mako updated the diff for D81839: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS..

Added an additional comment and change to code to use the implicit OperandRange conversion operator.

Jun 15 2020, 5:24 AM · Restricted Project
dfki-mako updated the summary of D81839: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS..
Jun 15 2020, 5:24 AM · Restricted Project
dfki-mako created D81839: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS..
Jun 15 2020, 5:24 AM · Restricted Project
dfki-mako committed rGff4c51033766: [mlir] Extended BufferPlacement to support more sophisticated scenarios in… (authored by dfki-mako).
[mlir] Extended BufferPlacement to support more sophisticated scenarios in…
Jun 15 2020, 3:47 AM
dfki-mako closed D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..
Jun 15 2020, 3:47 AM · Restricted Project, Restricted Project

Jun 9 2020

dfki-mako added inline comments to D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..
Jun 9 2020, 3:15 AM · Restricted Project, Restricted Project
dfki-mako updated the diff for D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..

Resolved merge conflicts and integrated an additional test case into an existing one in order to capture an additional special case.

Jun 9 2020, 3:15 AM · Restricted Project, Restricted Project

Jun 3 2020

dfki-mako updated the diff for D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..

Updated processing of aliases to avoid the aggressive insertion of copy operations in special cases.
Reformatted test cases.

Jun 3 2020, 3:48 AM · Restricted Project, Restricted Project

May 27 2020

dfki-mako added inline comments to D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..
May 27 2020, 4:17 AM · Restricted Project, Restricted Project
dfki-mako updated the diff for D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..

Fixed corner cases in which no copies have been created due to aliasing (see reviewer comments).
Added additional test cases to simulate such special control-flow scenarios.
Changed behavior of the BufferPlacement pass to ignore Alloc operations with multiple allocation results.

May 27 2020, 4:17 AM · Restricted Project, Restricted Project

May 20 2020

dfki-mako added inline comments to D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..
May 20 2020, 1:02 AM · Restricted Project, Restricted Project

May 19 2020

dfki-mako added inline comments to D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..
May 19 2020, 8:07 AM · Restricted Project, Restricted Project
dfki-mako updated the diff for D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..

Implemented a fix-point iteration to reduce the number of required copies.
Fixed minor issues (see review comments).

May 19 2020, 8:07 AM · Restricted Project, Restricted Project

May 18 2020

dfki-mako added a comment to D78917: [mlir] Updated SideEffect interface definitions to support tablegen Resource objects..

@mehdi_amini Thanks a lot for your feedback. Unfortunately, I haven't received some comments from him.

May 18 2020, 1:01 AM · Restricted Project, Restricted Project

May 13 2020

dfki-mako committed rG881c3bb6a732: [mlir] Adapted standard Alloc and Alloca ops to use new side-effect resources. (authored by dfki-mako).
[mlir] Adapted standard Alloc and Alloca ops to use new side-effect resources.
May 13 2020, 5:22 AM
dfki-mako closed D79620: [mlir] Adapted standard Alloc and Alloca ops to use different side-effect resources..
May 13 2020, 5:21 AM · Restricted Project, Restricted Project
dfki-mako retitled D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow. from Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow. to [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..
May 13 2020, 4:48 AM · Restricted Project, Restricted Project
dfki-mako created D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..
May 13 2020, 4:48 AM · Restricted Project, Restricted Project

May 8 2020

dfki-mako created D79620: [mlir] Adapted standard Alloc and Alloca ops to use different side-effect resources..
May 8 2020, 1:34 AM · Restricted Project, Restricted Project
dfki-mako added reviewers for D79620: [mlir] Adapted standard Alloc and Alloca ops to use different side-effect resources.: rriddle, herhut, mehdi_amini.
May 8 2020, 1:34 AM · Restricted Project, Restricted Project
dfki-mako committed rG568787f81e07: [mlir] Updated SideEffect interface definitions to use tablegen Resource… (authored by dfki-mako).
[mlir] Updated SideEffect interface definitions to use tablegen Resource…
May 8 2020, 1:02 AM
dfki-mako closed D78917: [mlir] Updated SideEffect interface definitions to support tablegen Resource objects..
May 8 2020, 1:01 AM · Restricted Project, Restricted Project

May 4 2020

dfki-mako committed rG67b466deda1d: [mlir] Removed tight coupling of BufferPlacement pass to Alloc and Dealloc. (authored by dfki-mako).
[mlir] Removed tight coupling of BufferPlacement pass to Alloc and Dealloc.
May 4 2020, 5:50 AM
dfki-mako closed D78993: [mlir] Removed tight coupling of BufferPlacement pass to Alloc and Dealloc operations by using MemoryEffectOpInterface queries..
May 4 2020, 5:50 AM · Restricted Project, Restricted Project

Apr 30 2020

dfki-mako added inline comments to D78993: [mlir] Removed tight coupling of BufferPlacement pass to Alloc and Dealloc operations by using MemoryEffectOpInterface queries..
Apr 30 2020, 7:55 AM · Restricted Project, Restricted Project
dfki-mako updated the diff for D78993: [mlir] Removed tight coupling of BufferPlacement pass to Alloc and Dealloc operations by using MemoryEffectOpInterface queries..

Addressed reviewer comments.

Apr 30 2020, 7:55 AM · Restricted Project, Restricted Project

Apr 29 2020

dfki-mako added a comment to D78917: [mlir] Updated SideEffect interface definitions to support tablegen Resource objects..

All right; let's wait for @rriddle's comments

Apr 29 2020, 5:19 AM · Restricted Project, Restricted Project

Apr 28 2020

dfki-mako created D78993: [mlir] Removed tight coupling of BufferPlacement pass to Alloc and Dealloc operations by using MemoryEffectOpInterface queries..
Apr 28 2020, 4:15 AM · Restricted Project, Restricted Project
dfki-mako added reviewers for D78993: [mlir] Removed tight coupling of BufferPlacement pass to Alloc and Dealloc operations by using MemoryEffectOpInterface queries.: mehdi_amini, herhut, pifon2a.
Apr 28 2020, 4:15 AM · Restricted Project, Restricted Project
dfki-mako updated the diff for D78993: [mlir] Removed tight coupling of BufferPlacement pass to Alloc and Dealloc operations by using MemoryEffectOpInterface queries..

Removed todo comment.

Apr 28 2020, 4:15 AM · Restricted Project, Restricted Project
dfki-mako committed rG5c352e69e76a: Providing buffer assignment for MLIR (authored by dfki-ehna).
Providing buffer assignment for MLIR
Apr 28 2020, 1:35 AM
dfki-mako closed D78484: Providing buffer assignment for MLIR.
Apr 28 2020, 1:35 AM · Restricted Project, Restricted Project

Apr 27 2020

dfki-mako committed rG8e640ca5a838: [mlir] Fixed warning related to unused variable in Liveness. (authored by dfki-mako).
[mlir] Fixed warning related to unused variable in Liveness.
Apr 27 2020, 5:20 AM
dfki-mako closed D78912: [mlir] Fixed warning related to unused variable in Liveness..
Apr 27 2020, 5:20 AM · Restricted Project, Restricted Project
dfki-mako updated the summary of D78917: [mlir] Updated SideEffect interface definitions to support tablegen Resource objects..
Apr 27 2020, 5:19 AM · Restricted Project, Restricted Project
dfki-mako added reviewers for D78917: [mlir] Updated SideEffect interface definitions to support tablegen Resource objects.: rriddle, herhut.
Apr 27 2020, 5:19 AM · Restricted Project, Restricted Project
dfki-mako created D78917: [mlir] Updated SideEffect interface definitions to support tablegen Resource objects..
Apr 27 2020, 5:19 AM · Restricted Project, Restricted Project
dfki-mako added a reviewer for D78912: [mlir] Fixed warning related to unused variable in Liveness.: herhut.
Apr 27 2020, 3:42 AM · Restricted Project, Restricted Project
dfki-mako created D78912: [mlir] Fixed warning related to unused variable in Liveness..
Apr 27 2020, 3:42 AM · Restricted Project, Restricted Project

Apr 23 2020

dfki-mako committed rGc79227cabb30: [mlir] Extended Liveness analysis to support nested regions. (authored by dfki-mako).
[mlir] Extended Liveness analysis to support nested regions.
Apr 23 2020, 7:34 AM
dfki-mako closed D77714: Extended Liveness analysis to support nested regions..
Apr 23 2020, 7:34 AM · Restricted Project, Restricted Project
dfki-mako added inline comments to D78484: Providing buffer assignment for MLIR.
Apr 23 2020, 4:49 AM · Restricted Project, Restricted Project

Apr 22 2020

dfki-mako added inline comments to D78484: Providing buffer assignment for MLIR.
Apr 22 2020, 4:49 AM · Restricted Project, Restricted Project
dfki-mako added inline comments to D78484: Providing buffer assignment for MLIR.
Apr 22 2020, 1:03 AM · Restricted Project, Restricted Project

Apr 21 2020

dfki-mako updated the diff for D77714: Extended Liveness analysis to support nested regions..

Reformatted and upated comments.

Apr 21 2020, 3:44 AM · Restricted Project, Restricted Project
dfki-mako added a project to D77714: Extended Liveness analysis to support nested regions.: Restricted Project.
Apr 21 2020, 2:07 AM · Restricted Project, Restricted Project

Apr 16 2020

dfki-mako added a comment to D77714: Extended Liveness analysis to support nested regions..

We have introduced a new utility function

Block *Region::findAncestorBlockInRegion(Block &block)

in order to remove the findInCurrent implementation.

Apr 16 2020, 5:36 AM · Restricted Project, Restricted Project
dfki-mako updated the diff for D77714: Extended Liveness analysis to support nested regions..

Applied comments and refactored findInCurrent functionality.

Apr 16 2020, 5:36 AM · Restricted Project, Restricted Project

Apr 15 2020

dfki-mako added inline comments to D77714: Extended Liveness analysis to support nested regions..
Apr 15 2020, 4:20 AM · Restricted Project, Restricted Project

Apr 9 2020

dfki-mako updated the diff for D77714: Extended Liveness analysis to support nested regions..

Applied comments and adapted test cases.

Apr 9 2020, 3:45 AM · Restricted Project, Restricted Project