Page MenuHomePhabricator

dfki-mako (Marcel Koester)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 9 2020, 1:29 AM (99 w, 3 d)

Recent Activity

Sep 28 2021

dfki-mako added inline comments to D109350: [mlir] Added new AllocationOpInterface and adapted BufferDeallocation pass to use the new interface..
Sep 28 2021, 5:30 AM · Restricted Project
dfki-mako updated the diff for D109350: [mlir] Added new AllocationOpInterface and adapted BufferDeallocation pass to use the new interface..

Updated error handling to propagate errors upwards in order to signal pass failures.

Sep 28 2021, 5:30 AM · Restricted Project

Sep 22 2021

dfki-mako added inline comments to D109350: [mlir] Added new AllocationOpInterface and adapted BufferDeallocation pass to use the new interface..
Sep 22 2021, 3:58 AM · Restricted Project
dfki-mako updated the diff for D109350: [mlir] Added new AllocationOpInterface and adapted BufferDeallocation pass to use the new interface..

Addressed reviewer comments and enhanced error handling.

Sep 22 2021, 3:57 AM · Restricted Project

Sep 21 2021

dfki-mako added inline comments to D109350: [mlir] Added new AllocationOpInterface and adapted BufferDeallocation pass to use the new interface..
Sep 21 2021, 3:08 AM · Restricted Project
dfki-mako updated the diff for D109350: [mlir] Added new AllocationOpInterface and adapted BufferDeallocation pass to use the new interface..

Addressed reviewer comments and added support for failing interface functions.

Sep 21 2021, 3:06 AM · Restricted Project

Sep 14 2021

dfki-mako added inline comments to D109350: [mlir] Added new AllocationOpInterface and adapted BufferDeallocation pass to use the new interface..
Sep 14 2021, 4:06 AM · Restricted Project
dfki-mako updated the summary of D109350: [mlir] Added new AllocationOpInterface and adapted BufferDeallocation pass to use the new interface..
Sep 14 2021, 4:00 AM · Restricted Project
dfki-mako updated the diff for D109350: [mlir] Added new AllocationOpInterface and adapted BufferDeallocation pass to use the new interface..

Added new buildClone operation to the newly introduced AllocationOpInterface.
Made Op interface methods static.
Added support for automatic building of "compatible" deallocation/clone operations based on inverse alias information.
Added support for building "default" DeallocOp/CloneOp values in the case of unknown value sources (e.g. function parameters).
Refined verification part to work on logical result values.

Sep 14 2021, 3:56 AM · Restricted Project

Sep 7 2021

dfki-mako added reviewers for D109350: [mlir] Added new AllocationOpInterface and adapted BufferDeallocation pass to use the new interface.: herhut, silvas, mehdi_amini, rriddle, pifon2a, dfki-jugr.
Sep 7 2021, 3:27 AM · Restricted Project
dfki-mako updated the summary of D109350: [mlir] Added new AllocationOpInterface and adapted BufferDeallocation pass to use the new interface..
Sep 7 2021, 3:26 AM · Restricted Project
dfki-mako retitled D109350: [mlir] Added new AllocationOpInterface and adapted BufferDeallocation pass to use the new interface. from Introduced AllocationOpInterface to create deallocation operations on-the-fly that are compatible with the allocation operation implementing this interface. Added interface implementations for AllocOp and CloneOp defined in the MemRef diallect. to [mlir] Added new AllocationOpInterface and adapted BufferDeallocation pass to use the new interface..
Sep 7 2021, 3:26 AM · Restricted Project
dfki-mako requested review of D109350: [mlir] Added new AllocationOpInterface and adapted BufferDeallocation pass to use the new interface..
Sep 7 2021, 3:24 AM · Restricted Project

Jul 25 2021

dfki-mako committed rG0425332015f4: [mlir] Added new RegionBranchTerminatorOpInterface and adapted uses of… (authored by dfki-mako).
[mlir] Added new RegionBranchTerminatorOpInterface and adapted uses of…
Jul 25 2021, 9:50 PM
dfki-mako closed D105018: Added new RegionBranchTerminatorOpInterface and adapted uses of hasTrait<ReturnLike>..
Jul 25 2021, 9:50 PM · Restricted Project

Jul 23 2021

dfki-mako updated the diff for D105018: Added new RegionBranchTerminatorOpInterface and adapted uses of hasTrait<ReturnLike>..

Addressed reviewer comments from @rriddle.

Jul 23 2021, 3:15 AM · Restricted Project

Jul 22 2021

dfki-mako updated the diff for D105018: Added new RegionBranchTerminatorOpInterface and adapted uses of hasTrait<ReturnLike>..

Changed namespace qualifiers to explicitly reference the llvm/mlir namespaces.

Jul 22 2021, 2:48 AM · Restricted Project

Jul 21 2021

dfki-mako added a comment to D105018: Added new RegionBranchTerminatorOpInterface and adapted uses of hasTrait<ReturnLike>..

@herhut I think it might be beneficial to either remove the ReturnLike trait or to change it in a way such that it automatically provides a "default implementation" of the newly added RegionBranchTerminatorOpInterface.

Jul 21 2021, 1:35 AM · Restricted Project

Jul 14 2021

dfki-mako updated the diff for D105018: Added new RegionBranchTerminatorOpInterface and adapted uses of hasTrait<ReturnLike>..

Adatped ForwardDataFlowSolver to support the newly added RegionBranchTerminatorOpInterface.

Jul 14 2021, 6:13 AM · Restricted Project

Jul 13 2021

dfki-mako added a comment to D105018: Added new RegionBranchTerminatorOpInterface and adapted uses of hasTrait<ReturnLike>..

@rriddle there is also another use of the ReturnLike trait in the scope of the DataFlowAnalysis. Currently, you check whether a terminator is ReturnLike. If not, you mark the following region successors to have reached a pessimistic fixpoint. This raises the question of whether we want to change this behavior to propagate lattice information in the context of "more return-like" operations.

Jul 13 2021, 1:16 AM · Restricted Project
dfki-mako retitled D105018: Added new RegionBranchTerminatorOpInterface and adapted uses of hasTrait<ReturnLike>. from RFC: Added new RegionBranchTerminatorOpInterface and provided a sample implementation for the SCF.ConditionOp. to Added new RegionBranchTerminatorOpInterface and adapted uses of hasTrait<ReturnLike>..
Jul 13 2021, 1:10 AM · Restricted Project
dfki-mako updated the diff for D105018: Added new RegionBranchTerminatorOpInterface and adapted uses of hasTrait<ReturnLike>..

Addressed reviewer comments and refined RegionBranchTerminatorOpInterface.
Adapted uses of hasTrait<ReturnLike> to use newly added functions (if possible).

Jul 13 2021, 1:09 AM · Restricted Project

Jun 28 2021

dfki-mako updated the summary of D105018: Added new RegionBranchTerminatorOpInterface and adapted uses of hasTrait<ReturnLike>..
Jun 28 2021, 5:57 AM · Restricted Project
dfki-mako updated the summary of D105018: Added new RegionBranchTerminatorOpInterface and adapted uses of hasTrait<ReturnLike>..
Jun 28 2021, 5:56 AM · Restricted Project
dfki-mako requested review of D105018: Added new RegionBranchTerminatorOpInterface and adapted uses of hasTrait<ReturnLike>..
Jun 28 2021, 5:55 AM · Restricted Project

May 10 2021

dfki-mako added a comment to D100838: [mlir] Split BufferAliasAnalysis into 2 classes.

Awesome work, thanks a lot :-)

May 10 2021, 3:39 AM · Restricted Project

May 7 2021

dfki-mako added a comment to D100838: [mlir] Split BufferAliasAnalysis into 2 classes.

I've worked around this issue in my own code now, so what do you think about me just doing this rename? Then there will be no confusion between this pass and the new AliasAnalysis (and their definitions of aliasing). I think that confusion is good to avoid, and since I have a different solution for my own use case, I can avoid creating more confusion by creating another Analysis at this time.

+1 to renaming it to avoid confusion in the future.

May 7 2021, 3:32 AM · Restricted Project

May 5 2021

dfki-mako added a comment to D100838: [mlir] Split BufferAliasAnalysis into 2 classes.

I have to admit that my comment regarding all aliases of A was a bit misleading :-( At the time of writing, I accidentally had the "flow"-property (required by the BufferDeallocation phase) in mind. My comment was meant to address potentially "inconsistent" results of two "alias analyses" (of course, aliasing is a symmetric property!) :-)

May 5 2021, 2:20 AM · Restricted Project

Apr 29 2021

dfki-mako added inline comments to D100838: [mlir] Split BufferAliasAnalysis into 2 classes.
Apr 29 2021, 5:07 AM · Restricted Project
dfki-mako added a comment to D100838: [mlir] Split BufferAliasAnalysis into 2 classes.

I have to admit that I am not convinced by the general notion of a "dependency". In my opinion, BufferDependencyAnalysis::resolve(B) => {B, C, D}, does not give any guarantees about whether C and D actually depend on B in the sense of true "data dependencies". Instead, C and D can also be block arguments that are pure aliases without any read/write dependencies. Also, BufferAliasAnalysis::resolve(B) => {A, B, C, D} feels to me like A can be an alias of B, which is not actually the case, right? B has two aliases, namely C and D on the one hand. On the other hand, A has three aliases, namely B, C and D. Returning A as an alias of B could cause confusion in the future. What do you think about this?

Apr 29 2021, 5:06 AM · Restricted Project

Dec 22 2020

dfki-mako abandoned D92562: [MLIR] Refactored BufferDeallocation pass to enable support for individual alloc/clone/free operations..

@silvas @mehdi_amini @herhut based on the feedback and the discussion in the public Discourse forums, we will close this PR for now until there is a better solution to overcome these limitations in the future.

Dec 22 2020, 1:30 AM · Restricted Project

Dec 7 2020

dfki-mako added a reviewer for D92562: [MLIR] Refactored BufferDeallocation pass to enable support for individual alloc/clone/free operations.: mehdi_amini.
Dec 7 2020, 2:42 AM · Restricted Project
dfki-mako added a comment to D92562: [MLIR] Refactored BufferDeallocation pass to enable support for individual alloc/clone/free operations..

@silvas Our intention was not to "bypass anything", sorry for the confusion. As you have mentioned, the discussion went a bit "idle" and we had to more forwards to simplify the integration of the BufferDeallocation pass into other third-party sub projects. Therefore, we proposed this CL that realizes an extremely light-weight version of the Pass Interface being discussed in the forums. However, the proposed solution in the scope of this CL is meant to unblock others on the one hand and being minimally invasive on the other hand. In other words: as soon as we can come up with a better solution based on the Discourse discussion, we can easily "revert" or "update" this pass interface. Please note further that existing code will not break or require further updates after merging this CL.

Dec 7 2020, 2:33 AM · Restricted Project

Dec 3 2020

dfki-mako added reviewers for D92562: [MLIR] Refactored BufferDeallocation pass to enable support for individual alloc/clone/free operations.: herhut, silvas, dfki-jugr.
Dec 3 2020, 3:02 AM · Restricted Project
dfki-mako requested review of D92562: [MLIR] Refactored BufferDeallocation pass to enable support for individual alloc/clone/free operations..
Dec 3 2020, 3:01 AM · Restricted Project

Nov 12 2020

dfki-mako accepted D91360: [mlir][bufferize] Fix buffer promotion to stack for index types.
Nov 12 2020, 2:33 PM · Restricted Project
dfki-mako accepted D90899: [mlir] Add DecomposeCallGraphTypes pass..

Awesome work 🚀 I don't see any problems to land this CL after addressing the nits 🤓

Nov 12 2020, 1:28 AM · Restricted Project

Nov 11 2020

dfki-mako accepted D90675: [MLIR] Added documentation and manual to use bufferization features..
Nov 11 2020, 6:31 AM · Restricted Project

Nov 6 2020

dfki-mako added reviewers for D90899: [mlir] Add DecomposeCallGraphTypes pass.: dfki-albo, dfki-heme.
Nov 6 2020, 7:45 AM · Restricted Project

Nov 5 2020

dfki-mako added a reviewer for D90675: [MLIR] Added documentation and manual to use bufferization features.: mehdi_amini.
Nov 5 2020, 1:33 AM · Restricted Project
dfki-mako accepted D90778: [mlir] Remove AppendToArgumentsList functionality from BufferizeTypeConverter..
Nov 5 2020, 1:10 AM · Restricted Project
dfki-mako added a comment to D89990: [mlir] Remove notion of "decompose values" from BufferizeTypeConverter.

Actually, it sounds like the direction we want to go with this is to split this functionality out. I'll do that in a separate patch.

Nov 5 2020, 1:09 AM · Restricted Project

Oct 30 2020

dfki-mako added inline comments to D90205: [mlir] Add func-bufferize pass..
Oct 30 2020, 4:07 PM · Restricted Project

Oct 29 2020

dfki-mako accepted D90071: [mlir] Add BufferResultsToOutParams pass..
Oct 29 2020, 5:39 PM · Restricted Project
dfki-mako added a comment to D90071: [mlir] Add BufferResultsToOutParams pass..

Awesome work +1. I guess this should be ready to go after replacing some autos with their underlying types.

Oct 29 2020, 3:58 PM · Restricted Project
dfki-mako added inline comments to D90071: [mlir] Add BufferResultsToOutParams pass..
Oct 29 2020, 3:55 PM · Restricted Project
dfki-mako added a comment to D90071: [mlir] Add BufferResultsToOutParams pass..

For example, FunctionLike doesn't guarantee that the op has a FunctionType, so all the code here where we modify the function type can't be written generically (see this thread for a similar issue:

Unfortunately, we cannot use this trait for the reasons you mentioned.

Oct 29 2020, 3:52 PM · Restricted Project

Oct 28 2020

dfki-mako requested changes to D90071: [mlir] Add BufferResultsToOutParams pass..
Oct 28 2020, 5:42 AM · Restricted Project
dfki-mako added a comment to D90071: [mlir] Add BufferResultsToOutParams pass..

I guess this approach introduces a limitation with respect to applicability to arbitrary dialects. We are now able to match ReturnOp and CallOps only while the previous version supported a generic customization to arbitrary dialects, right?
I would recommend that we should try to match CallOpInterface and ReturnLike implementations to make this code more generic in favor of standard CallOp and ReturnOp-based matchers from the Std dialect.

Oct 28 2020, 5:41 AM · Restricted Project

Oct 27 2020

dfki-mako added inline comments to D90071: [mlir] Add BufferResultsToOutParams pass..
Oct 27 2020, 4:41 PM · Restricted Project
dfki-mako added a comment to D89990: [mlir] Remove notion of "decompose values" from BufferizeTypeConverter.

The basic idea behind these generic type converts was to provide a highly customizable way to decompose and rewrite tuple types.
However, if there are no real users and as you are currently refactoring these parts into a separate pass anyway, it might be a good idea to simplify these conversion patterns.
See this CL for additional comments on the general refactoring process.

Oct 27 2020, 4:24 PM · Restricted Project

Oct 19 2020

dfki-mako committed rG1b1c61ff47f8: [mlir] Refactored BufferPlacement transformation. (authored by dfki-mako).
[mlir] Refactored BufferPlacement transformation.
Oct 19 2020, 3:55 AM
dfki-mako closed D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting..
Oct 19 2020, 3:54 AM · Restricted Project

Oct 16 2020

dfki-mako updated the diff for D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting..

Addressed reviewer comments.

Oct 16 2020, 3:46 AM · Restricted Project

Oct 14 2020

dfki-mako added inline comments to D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting..
Oct 14 2020, 6:06 AM · Restricted Project
dfki-mako updated the diff for D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting..

Refactored code and addressed reviewer comments.

Oct 14 2020, 6:06 AM · Restricted Project

Oct 13 2020

dfki-mako accepted D89271: [mlir][bufferize] Rename BufferAssignment* to Bufferize*.
Oct 13 2020, 4:33 AM · Restricted Project
dfki-mako updated the diff for D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting..

Refined all parts of this PR and addressed all reviewer comments.

Oct 13 2020, 4:24 AM · Restricted Project

Sep 30 2020

dfki-mako added inline comments to D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting..
Sep 30 2020, 7:39 AM · Restricted Project
dfki-mako updated the diff for D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting..

Addressed reviewer comments and changed the BufferAllocationHoisting pass to pay attention to escaping buffers via backedges.

Sep 30 2020, 7:37 AM · Restricted Project

Sep 16 2020

dfki-mako added reviewers for D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting.: herhut, pifon2a.
Sep 16 2020, 3:53 AM · Restricted Project
dfki-mako requested review of D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting..
Sep 16 2020, 3:51 AM · Restricted Project

Sep 9 2020

dfki-mako committed rGfeb0b9c3bba7: [mlir] Added support for loops to BufferPlacement transformation. (authored by dfki-mako).
[mlir] Added support for loops to BufferPlacement transformation.
Sep 9 2020, 1:55 AM
dfki-mako closed D85513: [mlir] Added support for loops in BufferPlacement transformation..
Sep 9 2020, 1:55 AM · Restricted Project

Sep 8 2020

dfki-mako added inline comments to D85513: [mlir] Added support for loops in BufferPlacement transformation..
Sep 8 2020, 2:06 AM · Restricted Project
dfki-mako updated the diff for D85513: [mlir] Added support for loops in BufferPlacement transformation..

Addressed reviewer comments regarding tests, comments and invariants.

Sep 8 2020, 2:06 AM · Restricted Project

Sep 2 2020

dfki-mako retitled D85513: [mlir] Added support for loops in BufferPlacement transformation. from [mlir] WIP: Added support for loops in BufferPlacement transformation. to [mlir] Added support for loops in BufferPlacement transformation..
Sep 2 2020, 3:46 AM · Restricted Project
dfki-mako added inline comments to D85513: [mlir] Added support for loops in BufferPlacement transformation..
Sep 2 2020, 3:46 AM · Restricted Project

Aug 25 2020

dfki-mako updated the diff for D85513: [mlir] Added support for loops in BufferPlacement transformation..

Completed support for loops using structured control flow and addressed reviewer comments.

Aug 25 2020, 2:53 AM · Restricted Project

Aug 7 2020

dfki-mako retitled D85513: [mlir] Added support for loops in BufferPlacement transformation. from [mlir] Added support for loops in BufferPlacement transformation. to [mlir] WIP: Added support for loops in BufferPlacement transformation..
Aug 7 2020, 3:39 AM · Restricted Project
dfki-mako requested review of D85513: [mlir] Added support for loops in BufferPlacement transformation..
Aug 7 2020, 3:39 AM · Restricted Project

Jun 26 2020

dfki-mako added inline comments to D81926: [mlir] Extended BufferPlacement to support nested region control flow..
Jun 26 2020, 4:52 AM · Restricted Project
dfki-mako updated the diff for D81926: [mlir] Extended BufferPlacement to support nested region control flow..

Addressed reviewer comments.

Jun 26 2020, 4:51 AM · Restricted Project

Jun 25 2020

dfki-mako updated the diff for D81926: [mlir] Extended BufferPlacement to support nested region control flow..

Added support for region-region control flow within operations that implement the RegionBranchOpInterface.
Added new test operations to verify more advanced region-region control-flow scenarios.

Jun 25 2020, 3:44 AM · Restricted Project

Jun 24 2020

dfki-mako retitled D81926: [mlir] Extended BufferPlacement to support nested region control flow. from [mlir] WIP: Extended BufferPlacement to support nested region control flow. to [mlir] Extended BufferPlacement to support nested region control flow..
Jun 24 2020, 4:16 AM · Restricted Project

Jun 23 2020

dfki-mako added inline comments to D81926: [mlir] Extended BufferPlacement to support nested region control flow..
Jun 23 2020, 6:21 AM · Restricted Project
dfki-mako updated the diff for D81926: [mlir] Extended BufferPlacement to support nested region control flow..

Refactored implementation and simplified the iteration over all successor regions.

Jun 23 2020, 6:21 AM · Restricted Project

Jun 19 2020

dfki-mako updated the diff for D81926: [mlir] Extended BufferPlacement to support nested region control flow..

Added extended support for the RegionOpInterface to query successor bindings for successor regions

Jun 19 2020, 5:53 AM · Restricted Project

Jun 17 2020

dfki-mako retitled D81926: [mlir] Extended BufferPlacement to support nested region control flow. from [mlir] Extended BufferPlacement to support nested region control flow. to [mlir] WIP: Extended BufferPlacement to support nested region control flow..
Jun 17 2020, 4:16 AM · Restricted Project

Jun 16 2020

dfki-mako added reviewers for D81926: [mlir] Extended BufferPlacement to support nested region control flow.: pifon2a, herhut.
Jun 16 2020, 4:23 AM · Restricted Project
dfki-mako created D81926: [mlir] Extended BufferPlacement to support nested region control flow..
Jun 16 2020, 4:23 AM · Restricted Project

Jun 15 2020

dfki-mako committed rG33879aa0bf00: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS. (authored by dfki-mako).
[mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS.
Jun 15 2020, 7:01 AM
dfki-mako closed D81839: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS..
Jun 15 2020, 7:01 AM · Restricted Project
dfki-mako updated the diff for D81839: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS..

Refactored access to getSuccessorOperands to distinguish between read-only and write-enabled accesses.

Jun 15 2020, 6:28 AM · Restricted Project
dfki-mako added inline comments to D81839: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS..
Jun 15 2020, 6:28 AM · Restricted Project
dfki-mako updated the diff for D81839: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS..

Added an additional comment and change to code to use the implicit OperandRange conversion operator.

Jun 15 2020, 5:24 AM · Restricted Project
dfki-mako updated the summary of D81839: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS..
Jun 15 2020, 5:24 AM · Restricted Project
dfki-mako created D81839: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS..
Jun 15 2020, 5:24 AM · Restricted Project
dfki-mako committed rGff4c51033766: [mlir] Extended BufferPlacement to support more sophisticated scenarios in… (authored by dfki-mako).
[mlir] Extended BufferPlacement to support more sophisticated scenarios in…
Jun 15 2020, 3:47 AM
dfki-mako closed D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..
Jun 15 2020, 3:47 AM · Restricted Project, Restricted Project

Jun 9 2020

dfki-mako added inline comments to D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..
Jun 9 2020, 3:15 AM · Restricted Project, Restricted Project
dfki-mako updated the diff for D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..

Resolved merge conflicts and integrated an additional test case into an existing one in order to capture an additional special case.

Jun 9 2020, 3:15 AM · Restricted Project, Restricted Project

Jun 3 2020

dfki-mako updated the diff for D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..

Updated processing of aliases to avoid the aggressive insertion of copy operations in special cases.
Reformatted test cases.

Jun 3 2020, 3:48 AM · Restricted Project, Restricted Project

May 27 2020

dfki-mako added inline comments to D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..
May 27 2020, 4:17 AM · Restricted Project, Restricted Project
dfki-mako updated the diff for D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..

Fixed corner cases in which no copies have been created due to aliasing (see reviewer comments).
Added additional test cases to simulate such special control-flow scenarios.
Changed behavior of the BufferPlacement pass to ignore Alloc operations with multiple allocation results.

May 27 2020, 4:17 AM · Restricted Project, Restricted Project

May 20 2020

dfki-mako added inline comments to D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..
May 20 2020, 1:02 AM · Restricted Project, Restricted Project

May 19 2020

dfki-mako added inline comments to D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..
May 19 2020, 8:07 AM · Restricted Project, Restricted Project
dfki-mako updated the diff for D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..

Implemented a fix-point iteration to reduce the number of required copies.
Fixed minor issues (see review comments).

May 19 2020, 8:07 AM · Restricted Project, Restricted Project

May 18 2020

dfki-mako added a comment to D78917: [mlir] Updated SideEffect interface definitions to support tablegen Resource objects..

@mehdi_amini Thanks a lot for your feedback. Unfortunately, I haven't received some comments from him.

May 18 2020, 1:01 AM · Restricted Project, Restricted Project

May 13 2020

dfki-mako committed rG881c3bb6a732: [mlir] Adapted standard Alloc and Alloca ops to use new side-effect resources. (authored by dfki-mako).
[mlir] Adapted standard Alloc and Alloca ops to use new side-effect resources.
May 13 2020, 5:22 AM