This is an archive of the discontinued LLVM Phabricator instance.

[LoopRotate][NPM] Disable header duplication under -Oz
ClosedPublic

Authored by aeubanks on Oct 21 2020, 10:14 PM.

Details

Summary

It was already disabled under -Oz in
buildFunctionSimplificationPipeline(), but not in
buildModuleOptimizationPipeline()/addPGOInstrPasses().

Diff Detail

Event Timeline

aeubanks created this revision.Oct 21 2020, 10:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 21 2020, 10:14 PM
aeubanks requested review of this revision.Oct 21 2020, 10:14 PM
fhahn accepted this revision.Oct 22 2020, 5:34 AM
fhahn added a subscriber: fhahn.

LGTM, thanks! This should be in-line with the behavior of the legacy PM pipeline.

llvm/lib/Passes/PassBuilder.cpp
837

might be good to add a comment like Header duplication is disabled for Oz, like in the legacy PM.

This revision is now accepted and ready to land.Oct 22 2020, 5:34 AM
aeubanks updated this revision to Diff 299986.Oct 22 2020, 8:28 AM

add comments

This revision was landed with ongoing or failed builds.Oct 22 2020, 8:39 AM
This revision was automatically updated to reflect the committed changes.