This is an archive of the discontinued LLVM Phabricator instance.

[ValuteTracking] Handle alignment assume bundles
ClosedPublic

Authored by arichardson on Oct 20 2020, 3:20 PM.

Details

Summary

I noticed that alignment was no longer inferred as well after I recently merged
our CHERI fork from upstream. It seems this was caused by the change to move
IRBuilder's alignment assumptions over to assume bundles instead of
icmp+ptrtoint+mask (D71739).

Diff Detail

Event Timeline

arichardson created this revision.Oct 20 2020, 3:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2020, 3:20 PM
arichardson requested review of this revision.Oct 20 2020, 3:20 PM
jdoerfert accepted this revision.Oct 21 2020, 4:11 PM

LGTM "but" already "fixed" in D88669. we need to merge one of the two, they basically do the same thing. We should make sure to merge all tests ;)

llvm/lib/Analysis/ValueTracking.cpp
1965

Unrelated but LGTM.

This revision is now accepted and ready to land.Oct 21 2020, 4:11 PM

Can you merge D88669, and then your unrelated change as well as your unit test?

Can you merge D88669, and then your unrelated change as well as your unit test?

Sure. Alternatively you could commit D88669 and I'll update this to just add the test + the unrelated cleanup?

Can you merge D88669, and then your unrelated change as well as your unit test?

Sure. Alternatively you could commit D88669 and I'll update this to just add the test + the unrelated cleanup?

I don't have a clean master to test right now. Still trying to hunt down a different problem. Can try to do it later today but feel free to go ahead w/o me.
D88669 has the author's name/email in a comment.

This revision was landed with ongoing or failed builds.Oct 27 2020, 5:17 AM
This revision was automatically updated to reflect the committed changes.