[clangd] Rename edge name for filesymbols to slabs in memorytree

[kadircet]

Summary

This was causing duplicate symbols components on the path as both the
edge from an index to filesymbols and filesymbols to symbolslabs were named
symbols.

clang-tools-extra/clangd/index/Background.cpp

for (auto &LS : Result) {
     // for this TU, i.e TU was deleted after we performed indexing.
     TUsToIndex.insert(TUForFile);
   }
 
   return {TUsToIndex.begin(), TUsToIndex.end()};
 }
 
 void BackgroundIndex::profile(MemoryTree &MT) const {
-  IndexedSymbols.profile(MT.child("symbols"));
+  IndexedSymbols.profile(MT.child("slabs"));
   // We don't want to mix memory used by index and symbols, so call base class.
   MT.child("index").addUsage(SwapIndex::estimateMemoryUsage());
 }
 } // namespace clangd
 } // namespace clang

clang-tools-extra/clangd/index/FileIndex.cpp

auto NewIndex = MainFileSymbols.buildIndex(
     vlog(
         "Build dynamic index for main-file symbols with estimated memory usage "
         "of {0} bytes",
         MainFileIndex.estimateMemoryUsage());
   }
 }
 
 void FileIndex::profile(MemoryTree &MT) const {
-  PreambleSymbols.profile(MT.child("preamble").child("symbols"));
+  PreambleSymbols.profile(MT.child("preamble").child("slabs"));
   MT.child("preamble")
       .child("index")
       .addUsage(PreambleIndex.estimateMemoryUsage());
-  MainFileSymbols.profile(MT.child("main_file").child("symbols"));
+  MainFileSymbols.profile(MT.child("main_file").child("slabs"));
   MT.child("main_file")
       .child("index")
       .addUsage(MainFileIndex.estimateMemoryUsage());
 }
 } // namespace clangd
 } // namespace clang

clang-tools-extra/clangd/test/memory_tree.test

 # CHECK-NEXT:         "_total": {{[0-9]+}},
 # CHECK-NEXT:         "main_file": {
 # CHECK-NEXT:           "_self": {{[0-9]+}},
 # CHECK-NEXT:           "_total": {{[0-9]+}},
 # CHECK-NEXT:           "index": {
 # CHECK-NEXT:             "_self": {{[0-9]+}},
 # CHECK-NEXT:             "_total": {{[0-9]+}}
 # CHECK-NEXT:           },
-# CHECK-NEXT:           "symbols": {
+# CHECK-NEXT:           "slabs": {
 # CHECK-NEXT:             "{{.*}}main.cpp": {
 # CHECK-NEXT:               "_self": {{[0-9]+}},
 # CHECK-NEXT:               "_total": {{[0-9]+}},
 # CHECK-NEXT:               "references": {
 # CHECK-NEXT:                 "_self": {{[0-9]+}},
 # CHECK-NEXT:                 "_total": {{[0-9]+}}
 # CHECK-NEXT:               },
 # CHECK-NEXT:               "relations": {

 # CHECK-NEXT:         },
 # CHECK-NEXT:         "preamble": {
 # CHECK-NEXT:           "_self": {{[0-9]+}},
 # CHECK-NEXT:           "_total": {{[0-9]+}},
 # CHECK-NEXT:           "index": {
 # CHECK-NEXT:             "_self": {{[0-9]+}},
 # CHECK-NEXT:             "_total": {{[0-9]+}}
 # CHECK-NEXT:           },
-# CHECK-NEXT:           "symbols": {
+# CHECK-NEXT:           "slabs": {
 # CHECK-NEXT:             "_self": {{[0-9]+}},
 # CHECK-NEXT:             "_total": {{[0-9]+}}
 # CHECK-NEXT:           }
 # CHECK-NEXT:         }
 # CHECK-NEXT:       },
 # CHECK-NEXT:       "tuscheduler": {
 # CHECK-NEXT:         "{{.*}}main.cpp": {
 # CHECK-NEXT:           "_self": {{[0-9]+}},

clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp

TEST(BackgroundIndex, Profile) {
   MockCompilationDatabase CDB;
   BackgroundIndex Idx(FS, CDB, [](llvm::StringRef) { return nullptr; },
                       /*Opts=*/{});
 
   llvm::BumpPtrAllocator Alloc;
   MemoryTree MT(&Alloc);
   Idx.profile(MT);
   ASSERT_THAT(MT.children(),
-              UnorderedElementsAre(Pair("symbols", _), Pair("index", _)));
+              UnorderedElementsAre(Pair("slabs", _), Pair("index", _)));
 }
 
 } // namespace clangd
 } // namespace clang

clang-tools-extra/clangd/unittests/FileIndexTests.cpp

TEST(FileIndexTest, Profile) {
 
   llvm::BumpPtrAllocator Alloc;
   MemoryTree MT(&Alloc);
   FI.profile(MT);
   ASSERT_THAT(MT.children(),
               UnorderedElementsAre(Pair("preamble", _), Pair("main_file", _)));
 
   ASSERT_THAT(MT.child("preamble").children(),
-              UnorderedElementsAre(Pair("index", _), Pair("symbols", _)));
+              UnorderedElementsAre(Pair("index", _), Pair("slabs", _)));
   ASSERT_THAT(MT.child("main_file").children(),
-              UnorderedElementsAre(Pair("index", _), Pair("symbols", _)));
+              UnorderedElementsAre(Pair("index", _), Pair("slabs", _)));
 
   ASSERT_THAT(MT.child("preamble").child("index").total(), Gt(0U));
   ASSERT_THAT(MT.child("main_file").child("index").total(), Gt(0U));
 }
 
 TEST(FileSymbolsTest, Profile) {
   FileSymbols FS;
   FS.update("f1", numSlab(1, 2), nullptr, nullptr, false);