This is an archive of the discontinued LLVM Phabricator instance.

Differential D89592

[Inliner][NPM] Properly pass callee AAResults
ClosedPublic

Authored by aeubanks on Oct 16 2020, 1:48 PM.

Details

Reviewers
ychen
asbirlea
davidxl
mtrofin
Commits
rGba22c403b2b3: [Inliner][NPM] Properly pass callee AAResults
Summary

Fixes noalias-calls.ll under NPM.

Diff Detail

Unit TestsFailed

TimeTest
30 mslinux > LLVM.CodeGen/AArch64::fast-isel-dbg.ll
620 mslinux > libomp.tasking::omp_task_red_taskloop.c
50 mswindows > LLVM.CodeGen/AArch64::fast-isel-dbg.ll

Event Timeline

aeubanks created this revision.Oct 16 2020, 1:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 16 2020, 1:48 PM
Herald added subscribers: llvm-commits, hiraditya, eraman. · View Herald Transcript
aeubanks requested review of this revision.Oct 16 2020, 1:48 PM
Harbormaster completed remote builds in B75373: Diff 298746.Oct 16 2020, 3:05 PM
aeubanks added a reviewer: mtrofin.Oct 23 2020, 2:23 PM
mtrofin accepted this revision.Oct 23 2020, 2:27 PM

lgtm

This revision is now accepted and ready to land.Oct 23 2020, 2:27 PM
This revision was landed with ongoing or failed builds.Oct 23 2020, 3:53 PM
Closed by commit rGba22c403b2b3: [Inliner][NPM] Properly pass callee AAResults (authored by aeubanks). · Explain Why
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rGba22c403b2b3: [Inliner][NPM] Properly pass callee AAResults.

Revision Contents

PathSize
llvm/
lib/
Transforms/
IPO/
3 lines
test/
Transforms/
Inline/
1 line

Diff 298746

llvm/lib/Transforms/IPO/Inliner.cpp

Show First 20 Lines • Show All 842 Lines • ▼ Show 20 Lines for (; I < (int)Calls.size() && Calls[I].first->getCaller() == &F; ++I) {
// Setup the data structure used to plumb customization into the // Setup the data structure used to plumb customization into the
// `InlineFunction` routine. // `InlineFunction` routine.
InlineFunctionInfo IFI( InlineFunctionInfo IFI(
/*cg=*/nullptr, GetAssumptionCache, PSI, /*cg=*/nullptr, GetAssumptionCache, PSI,
&FAM.getResult<BlockFrequencyAnalysis>(*(CB->getCaller())), &FAM.getResult<BlockFrequencyAnalysis>(*(CB->getCaller())),
&FAM.getResult<BlockFrequencyAnalysis>(Callee)); &FAM.getResult<BlockFrequencyAnalysis>(Callee));
InlineResult IR = InlineFunction(*CB, IFI); InlineResult IR =
InlineFunction(*CB, IFI, &FAM.getResult<AAManager>(*CB->getCaller()));
if (!IR.isSuccess()) { if (!IR.isSuccess()) {
Advice->recordUnsuccessfulInlining(IR); Advice->recordUnsuccessfulInlining(IR);
continue; continue;
} }
DidInline = true; DidInline = true;
InlinedCallees.insert(&Callee); InlinedCallees.insert(&Callee);
++NumInlined; ++NumInlined;
▲ Show 20 Lines • Show All 215 Lines • Show Last 20 Lines

llvm/test/Transforms/Inline/noalias-calls.ll

; RUN: opt -basic-aa -inline -enable-noalias-to-md-conversion -S < %s | FileCheck %s ; RUN: opt -basic-aa -inline -enable-noalias-to-md-conversion -S < %s | FileCheck %s
; RUN: opt -aa-pipeline=basic-aa -passes=inline -enable-noalias-to-md-conversion -S < %s | FileCheck %s
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128" target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu" target triple = "x86_64-unknown-linux-gnu"
declare void @llvm.memcpy.p0i8.p0i8.i64(i8* nocapture, i8* nocapture readonly, i64, i1) #0 declare void @llvm.memcpy.p0i8.p0i8.i64(i8* nocapture, i8* nocapture readonly, i64, i1) #0
declare void @hey() #0 declare void @hey() #0
define void @hello(i8* noalias nocapture %a, i8* noalias nocapture readonly %c, i8* nocapture %b) #1 { define void @hello(i8* noalias nocapture %a, i8* noalias nocapture readonly %c, i8* nocapture %b) #1 {
entry: entry:
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines