This is an archive of the discontinued LLVM Phabricator instance.

[benchmark][PowerPC] Rename mftbl to mftb
ClosedPublic

Authored by stevewan on Oct 15 2020, 3:24 PM.

Details

Summary

mftb and mftbl are equivalent, yet mftbl is not recognized on AIX. Therefore, rename mftbl to only have mftb.

For extra reference: Linux Kernel Mailing List reference for replacing mftbl with mftb, https://lkml.org/lkml/2020/10/1/1048.

Diff Detail

Event Timeline

stevewan created this revision.Oct 15 2020, 3:24 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
stevewan requested review of this revision.Oct 15 2020, 3:24 PM
stevewan edited the summary of this revision. (Show Details)Oct 15 2020, 3:28 PM
lebedev.ri requested changes to this revision.Oct 15 2020, 11:18 PM

Please can you submit this upstream first, so it doesn't get lost?

This revision now requires changes to proceed.Oct 15 2020, 11:18 PM
stevewan edited the summary of this revision. (Show Details)Oct 20 2020, 12:49 PM
stevewan added a comment.EditedNov 2 2020, 8:43 AM

Please can you submit this upstream first, so it doesn't get lost?

Upstream patch submitted at https://github.com/google/benchmark/pull/1069.
Status: Merged.

ldionne accepted this revision as: Restricted Project.Nov 2 2020, 2:07 PM
ldionne added a subscriber: ldionne.

Fine for libc++.

Kindly ping.

lebedev.ri retitled this revision from [PowerPC] Rename mftbl to mftb to [benchmark][PowerPC] Rename mftbl to mftb.Nov 3 2020, 12:53 PM

Thanks.
Please rebase if nessesary.
Please add an entry to llvm/utils/benchmark/README.llvm and to libcxx/utils/google-benchmark/README.llvm which contains information about cherry-picked commits that are applied on top of the local copy.

stevewan updated this revision to Diff 302907.Nov 4 2020, 10:46 AM

Add information about the cherry-picked commit and contributor.

lebedev.ri accepted this revision.Nov 4 2020, 10:49 AM

Thank you, please feel free to land this.
There's another copy in test-suite, which is not in the monorepo, might be good to also update it too.

This revision is now accepted and ready to land.Nov 4 2020, 10:49 AM
stevewan updated this revision to Diff 302911.Nov 4 2020, 10:56 AM

Recover overwritten commits.

Thank you, please feel free to land this.
There's another copy in test-suite, which is not in the monorepo, might be good to also update it too.

For records, link to the test-suite patch, https://reviews.llvm.org/D90779.

This revision was landed with ongoing or failed builds.Nov 4 2020, 11:24 AM
This revision was automatically updated to reflect the committed changes.