Page MenuHomePhabricator

[mlir][nfc] Add a func to compute numElements of a shape in Std -> LLVM.
ClosedPublic

Authored by pifon2a on Oct 13 2020, 11:14 AM.

Details

Summary

For some reason the variable cumulativeSizeInBytes in
getCumulativeSizeInBytes was actually storing number of elements. I decided
to fix it and refactor the function a bit.

Diff Detail

Event Timeline

pifon2a created this revision.Oct 13 2020, 11:14 AM
pifon2a requested review of this revision.Oct 13 2020, 11:14 AM
herhut accepted this revision.Oct 13 2020, 11:31 AM
This revision is now accepted and ready to land.Oct 13 2020, 11:31 AM
pifon2a updated this revision to Diff 297931.Oct 13 2020, 12:32 PM

Restore the computation order.

This revision was landed with ongoing or failed builds.Oct 13 2020, 12:41 PM
This revision was automatically updated to reflect the committed changes.