This is an archive of the discontinued LLVM Phabricator instance.

Differential D89284

[clangd] Propagate CollectMainFileRefs to BackgroundIndex
ClosedPublic

Authored by nridge on Oct 12 2020, 6:00 PM.

Details

Reviewers
kadircet
Commits
rGcb3c13fab6be: [clangd] Propagate CollectMainFileRefs to BackgroundIndex
Summary

This appears to have been an omission in D83536.

Diff Detail

Unit TestsFailed

TimeTest
4,240 mswindows > Clang-Unit.DirectoryWatcher/_/DirectoryWatcherTests_exe::DirectoryWatcherTest.AddFiles
3,960 mswindows > Clang-Unit.DirectoryWatcher/_/DirectoryWatcherTests_exe::DirectoryWatcherTest.DeleteFile
4,010 mswindows > Clang-Unit.DirectoryWatcher/_/DirectoryWatcherTests_exe::DirectoryWatcherTest.ModifyFile

Event Timeline

nridge created this revision.Oct 12 2020, 6:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 12 2020, 6:00 PM
Herald added subscribers: cfe-commits, usaxena95, arphaman. · View Herald Transcript
nridge requested review of this revision.Oct 12 2020, 6:00 PM
Herald added subscribers: MaskRay, ilya-biryukov. · View Herald TranscriptOct 12 2020, 6:00 PM
Harbormaster completed remote builds in B74877: Diff 297730.Oct 12 2020, 6:42 PM
nridge added a child revision: D89296: [clangd] Call hierarchy (Protocol layer).Oct 12 2020, 11:32 PM
kadircet accepted this revision.Oct 13 2020, 2:40 AM
This revision is now accepted and ready to land.Oct 13 2020, 2:40 AM
This revision was landed with ongoing or failed builds.Oct 13 2020, 6:20 AM
Closed by commit rGcb3c13fab6be: [clangd] Propagate CollectMainFileRefs to BackgroundIndex (authored by nridge). · Explain Why
This revision was automatically updated to reflect the committed changes.
nridge added a commit: rGcb3c13fab6be: [clangd] Propagate CollectMainFileRefs to BackgroundIndex.
nridge removed a child revision: D89296: [clangd] Call hierarchy (Protocol layer).Oct 18 2020, 11:00 PM

Revision Contents

PathSize
clang-tools-extra/
clangd/
1 line

Diff 297730

clang-tools-extra/clangd/ClangdServer.cpp

Show First 20 Lines • Show All 212 Lines • ▼ Show 20 Lines if (Opts.BackgroundIndex) {
BGOpts.ThreadPoolSize = std::max(Opts.AsyncThreadsCount, 1u); BGOpts.ThreadPoolSize = std::max(Opts.AsyncThreadsCount, 1u);
BGOpts.OnProgress = [Callbacks](BackgroundQueue::Stats S) { BGOpts.OnProgress = [Callbacks](BackgroundQueue::Stats S) {
if (Callbacks) if (Callbacks)
Callbacks->onBackgroundIndexProgress(S); Callbacks->onBackgroundIndexProgress(S);
}; };
BGOpts.ContextProvider = [this](PathRef P) { BGOpts.ContextProvider = [this](PathRef P) {
return createProcessingContext(P); return createProcessingContext(P);
}; };
BGOpts.CollectMainFileRefs = Opts.CollectMainFileRefs;
BackgroundIdx = std::make_unique<BackgroundIndex>( BackgroundIdx = std::make_unique<BackgroundIndex>(
TFS, CDB, TFS, CDB,
BackgroundIndexStorage::createDiskBackedStorageFactory( BackgroundIndexStorage::createDiskBackedStorageFactory(
[&CDB](llvm::StringRef File) { return CDB.getProjectInfo(File); }), [&CDB](llvm::StringRef File) { return CDB.getProjectInfo(File); }),
std::move(BGOpts)); std::move(BGOpts));
AddIndex(BackgroundIdx.get()); AddIndex(BackgroundIdx.get());
} }
if (DynamicIdx) if (DynamicIdx)
▲ Show 20 Lines • Show All 633 Lines • Show Last 20 Lines