This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Fix shared libs build
ClosedPublic

Authored by awarzynski on Oct 9 2020, 2:58 AM.

Download Raw Diff

Details

Reviewers

serge-sans-paille
mehdi_amini

Commits

rGdcd9be43e5c7: [mlir] Fix shared libs build

Summary

Reverts one breaking change introduced in
https://reviews.llvm.org/D88846.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

awarzynski created this revision.Oct 9 2020, 2:58 AM

Herald added a project: Restricted Project. · View Herald TranscriptOct 9 2020, 2:58 AM

Herald added subscribers: tatianashp, msifontes, jurahul and 13 others. · View Herald Transcript

awarzynski requested review of this revision.Oct 9 2020, 2:58 AM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptOct 9 2020, 2:58 AM

awarzynski mentioned this in D88846: [mlir] Improve LLVM shlib support.Oct 9 2020, 3:01 AM

awarzynski added reviewers: serge-sans-paille, mehdi_amini.

Harbormaster completed remote builds in B74551: Diff 297165.Oct 9 2020, 3:12 AM

Sorry for breaking the bot :-/ Did you try this patch with LLVM_LINK_LLVM_DYLIB=ON ?

In D89111#2321679, @serge-sans-paille wrote:

Sorry for breaking the bot :-/

No worries!

Did you try this patch with LLVM_LINK_LLVM_DYLIB=ON ?

Both with and without this change the following config is fine:

cmake -DLLVM_TARGETS_TO_BUILD=host -DLLVM_LINK_LLVM_DYLIB=ON -DCMAKE_BUILD_TYPE=Release -GNinja -DLLVM_ENABLE_PROJECTS="mlir" ../../llvm;

However, this configuration _does_ require this change:

cmake -DLLVM_TARGETS_TO_BUILD=host  -DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=Release -GNinja -DLLVM_ENABLE_PROJECTS="mlir" ../../llvm;

If both config works, that's great!

This revision is now accepted and ready to land.Oct 9 2020, 8:34 AM

Closed by commit rGdcd9be43e5c7: [mlir] Fix shared libs build (authored by awarzynski). · Explain WhyOct 9 2020, 8:39 AM

This revision was automatically updated to reflect the committed changes.

awarzynski added a commit: rGdcd9be43e5c7: [mlir] Fix shared libs build.

awarzynski mentioned this in D103540: [flang] Enabling flang to build with BUILD_SHARED_LIBS=On.Jun 4 2021, 9:42 AM

Revision Contents

Path

Size

mlir/

tools/

mlir-tblgen/

CMakeLists.txt

5 lines

Diff 297242

mlir/tools/mlir-tblgen/CMakeLists.txt

				set(LLVM_LINK_COMPONENTS
				Demangle
				Support
				TableGen
				)

	add_tablegen(mlir-tblgen MLIR			add_tablegen(mlir-tblgen MLIR
	DialectGen.cpp			DialectGen.cpp
	EnumsGen.cpp			EnumsGen.cpp
	LLVMIRConversionGen.cpp			LLVMIRConversionGen.cpp
	LLVMIRIntrinsicGen.cpp			LLVMIRIntrinsicGen.cpp
	mlir-tblgen.cpp			mlir-tblgen.cpp
	OpDefinitionsGen.cpp			OpDefinitionsGen.cpp
	Show All 18 Lines