Page MenuHomePhabricator

[mlir] Fix shared libs build
ClosedPublic

Authored by awarzynski on Oct 9 2020, 2:58 AM.

Details

Summary

Reverts one breaking change introduced in
https://reviews.llvm.org/D88846.

Diff Detail

Event Timeline

awarzynski created this revision.Oct 9 2020, 2:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 9 2020, 2:58 AM
awarzynski requested review of this revision.Oct 9 2020, 2:58 AM

Sorry for breaking the bot :-/ Did you try this patch with LLVM_LINK_LLVM_DYLIB=ON ?

Sorry for breaking the bot :-/

No worries!

Did you try this patch with LLVM_LINK_LLVM_DYLIB=ON ?

Both with and without this change the following config is fine:

cmake -DLLVM_TARGETS_TO_BUILD=host -DLLVM_LINK_LLVM_DYLIB=ON -DCMAKE_BUILD_TYPE=Release -GNinja -DLLVM_ENABLE_PROJECTS="mlir" ../../llvm;

However, this configuration _does_ require this change:

cmake -DLLVM_TARGETS_TO_BUILD=host  -DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=Release -GNinja -DLLVM_ENABLE_PROJECTS="mlir" ../../llvm;
serge-sans-paille accepted this revision.Oct 9 2020, 8:34 AM

If both config works, that's great!

This revision is now accepted and ready to land.Oct 9 2020, 8:34 AM
This revision was automatically updated to reflect the committed changes.