[NFC] Clean up always false variables

[rnk]

Let's add @arsenm. FWIW, this looks good to me: it's dead in tree, no need to keep it.

[arsenm]

Was there anything that ever set these?

[aeubanks]

In D89023#2328364, @arsenm wrote:

Was there anything that ever set these?

Looks like this was added in the very first patch that introduced RegionPass (23c8341c3dfbb9b453cc3857eabc2405207887cf). Nothing ever set it to true there. Looking through the history of RegionPass.h and .cpp, nothing jumps out to me.

llvm/include/llvm/Analysis/RegionPass.h

protected:
   /// Optional passes call this function to check whether the pass should be
   /// skipped. This is the case when optimization bisect is over the limit.
   bool skipRegion(Region &R) const;
 };
 
 /// The pass manager to schedule RegionPasses.
 class RGPassManager : public FunctionPass, public PMDataManager {
   std::deque<Region*> RQ;
-  bool skipThisRegion;
-  bool redoThisRegion;
   RegionInfo *RI;
   Region *CurrentRegion;
 
 public:
   static char ID;
   explicit RGPassManager();
 
   /// Execute all of the passes scheduled for execution.

llvm/lib/Analysis/RegionPass.cpp

 //===----------------------------------------------------------------------===//
 // RGPassManager
 //
 
 char RGPassManager::ID = 0;
 
 RGPassManager::RGPassManager()
   : FunctionPass(ID), PMDataManager() {
-  skipThisRegion = false;
-  redoThisRegion = false;
   RI = nullptr;
   CurrentRegion = nullptr;
 }
 
 // Recurse through all subregions and all regions  into RQ.
 static void addRegionIntoQueue(Region &R, std::deque<Region *> &RQ) {
   RQ.push_back(&R);
   for (const auto &E : R)
for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) {
       Changed |= RP->doInitialization(R, *this);
     }
   }
 
   // Walk Regions
   while (!RQ.empty()) {
 
     CurrentRegion  = RQ.back();
-    skipThisRegion = false;
-    redoThisRegion = false;
 
     // Run all passes on the current Region.
     for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) {
       RegionPass *P = (RegionPass*)getContainedPass(Index);
 
       if (isPassDebuggingExecutionsOrMore()) {
         dumpPassInfo(P, EXECUTION_MSG, ON_REGION_MSG,
                      CurrentRegion->getNameStr());

 #endif
 
         Changed |= LocalChanged;
       }
 
       if (isPassDebuggingExecutionsOrMore()) {
         if (LocalChanged)
           dumpPassInfo(P, MODIFICATION_MSG, ON_REGION_MSG,
-                       skipThisRegion ? "<deleted>" :
                                       CurrentRegion->getNameStr());
         dumpPreservedSet(P);
       }
 
-      if (!skipThisRegion) {
-        // Manually check that this region is still healthy. This is done
-        // instead of relying on RegionInfo::verifyRegion since RegionInfo
-        // is a function pass and it's really expensive to verify every
-        // Region in the function every time. That level of checking can be
-        // enabled with the -verify-region-info option.
-        {
-          TimeRegion PassTimer(getPassTimer(P));
-          CurrentRegion->verifyRegion();
-        }
 
-        // Then call the regular verifyAnalysis functions.
-        verifyPreservedAnalysis(P);
-      }
 
       if (LocalChanged)
         removeNotPreservedAnalysis(P);
       recordAvailableAnalysis(P);
       removeDeadPasses(P,
-                       (!isPassDebuggingExecutionsOrMore() || skipThisRegion) ?
-                       "<deleted>" :  CurrentRegion->getNameStr(),
+                       (!isPassDebuggingExecutionsOrMore())
+                           ? "<deleted>"
+                           : CurrentRegion->getNameStr(),
                        ON_REGION_MSG);
-
-      if (skipThisRegion)
-        // Do not run other passes on this region.
-        break;
-    }
-
-    // If the region was deleted, release all the region passes. This frees up
-    // some memory, and avoids trouble with the pass manager trying to call
-    // verifyAnalysis on them.
-    if (skipThisRegion)
-      for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) {
-        Pass *P = getContainedPass(Index);
-        freePass(P, "<deleted>", ON_REGION_MSG);
-      }
 
     // Pop the region from queue after running all passes.
     RQ.pop_back();
 
-    if (redoThisRegion)
-      RQ.push_back(CurrentRegion);
-
     // Free all region nodes created in region passes.
     RI->clearNodeCache();
   }
 
   // Finalization
   for (unsigned Index = 0; Index < getNumContainedPasses(); ++Index) {
     RegionPass *P = (RegionPass*)getContainedPass(Index);
     Changed |= P->doFinalization();