Another alternative form of D88642 - simpler pairing logic, but more flipping/reversing needed elsewhere instead.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I think I prefer this approach.
llvm/lib/Target/AArch64/AArch64FrameLowering.cpp | ||
---|---|---|
2079 | It's not obvious what "Inc" and "IncrementSign" are supposed to mean. |
llvm/lib/Target/AArch64/AArch64FrameLowering.cpp | ||
---|---|---|
2198 | Both here and at the other call to setObjectAlignment(), maybe add a comment describing what the stack layout actually looks like as a result of the padding? Would help make it clear why the codepaths are separate. |
Comment Actions
Gave some variables a more descriptive name, added more comments about stack object alignment/gaps.
It's not obvious what "Inc" and "IncrementSign" are supposed to mean.