Page MenuHomePhabricator

[AArch64] Match the windows canonical callee saved register order [alternative 3]
ClosedPublic

Authored by mstorsjo on Thu, Oct 1, 10:13 AM.

Details

Summary

Another alternative form of D88642 - simpler pairing logic, but more flipping/reversing needed elsewhere instead.

Diff Detail

Event Timeline

mstorsjo created this revision.Thu, Oct 1, 10:13 AM
mstorsjo requested review of this revision.Thu, Oct 1, 10:13 AM

I think I prefer this approach.

llvm/lib/Target/AArch64/AArch64FrameLowering.cpp
2079

It's not obvious what "Inc" and "IncrementSign" are supposed to mean.

efriedma added inline comments.Thu, Oct 1, 10:46 AM
llvm/lib/Target/AArch64/AArch64FrameLowering.cpp
2198

Both here and at the other call to setObjectAlignment(), maybe add a comment describing what the stack layout actually looks like as a result of the padding? Would help make it clear why the codepaths are separate.

mstorsjo updated this revision to Diff 295651.Thu, Oct 1, 12:48 PM

Gave some variables a more descriptive name, added more comments about stack object alignment/gaps.

This revision is now accepted and ready to land.Thu, Oct 1, 12:56 PM