This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Remove a duplicate call to setHasWinCFI. NFCI.
ClosedPublic

Authored by mstorsjo on Oct 1 2020, 1:15 AM.

Details

Summary

The function already has a cleanup scope that calls the same whenever the function is exited. When reading the code, seeing that this return codepath has an explicit call while other return paths lack it is confusing.

In the hypothetical case of a function having a prologue that set the HasWinCFI flag in the MF, but the epilogue containing no WinCFI instructions, the HasWinCFI flag in the MF would end up reset back to false.

Diff Detail

Event Timeline

mstorsjo created this revision.Oct 1 2020, 1:15 AM
mstorsjo requested review of this revision.Oct 1 2020, 1:15 AM
efriedma accepted this revision.Oct 1 2020, 7:54 AM

LGTM

This revision is now accepted and ready to land.Oct 1 2020, 7:54 AM
This revision was automatically updated to reflect the committed changes.