Page MenuHomePhabricator

[mlir] Update docs referencing OpTrait::Symbol.

Authored by scotttodd on Sep 29 2020, 1:48 PM.


Diff Detail

Event Timeline

scotttodd created this revision.Sep 29 2020, 1:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2020, 1:48 PM
scotttodd requested review of this revision.Sep 29 2020, 1:48 PM
rriddle accepted this revision.Sep 29 2020, 2:19 PM

Thanks for fixing this!


Can you move this to now instead? It isn't really a trait anymore.

This revision is now accepted and ready to land.Sep 29 2020, 2:19 PM
scotttodd updated this revision to Diff 295123.Sep 29 2020, 2:36 PM

Move Symbol docs to and update language.

scotttodd marked an inline comment as done.Sep 29 2020, 2:38 PM
scotttodd added inline comments.

Moved it and tried to match the documentation style in that file with the new section.

BTW, this is my first patch to LLVM/MLIR, so I think I'll need help submitting/merging. Not sure about the "patch does not apply" build failures - I think there are no conflicts...

Arc says " INFO Base commit is not in local repository; trying to fetch." ; seems like you have local changes?

The patch also does not apply on top of master for me.

(you local commit is based of f20918b4b15 apparently)

scotttodd updated this revision to Diff 295166.Sep 29 2020, 8:46 PM

Rebase on master.

(you local commit is based of f20918b4b15 apparently)

I had stacked a second git commit on top of my original commit and ran arc diff --update D88512. I'm following but coming from a git background I don't quite understand the relationship between local commits and what shows up here. I just rebased onto tip of tree, squashed my commits, and updated again. Might be better now?

This revision was automatically updated to reflect the committed changes.