[mlir] LLVM dialect: verify that a direct llvm.call refers to a declared function

[mehdi_amini]

Seems like a subset of https://reviews.llvm.org/D88362 ? Seems like you missed it?

[ftynse]

In D88486#2301321, @mehdi_amini wrote:

Seems like a subset of https://reviews.llvm.org/D88362 ? Seems like you missed it?

Indeed, it has been approved so it no longer shows up on the Phabricator welcome page and the email was buried deep enough. Thanks for fixing!

mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td

let builders = [OpBuilder<
     [{
       LLVMType resultType = func.getType().getFunctionResultType();
       if (!resultType.isVoidTy())
         result.addTypes(resultType);
       result.addAttribute("callee", builder.getSymbolRefAttr(func));
       result.addAttributes(attributes);
       result.addOperands(operands);
     }]>];
-  let verifier = [{
-    if (getNumResults() > 1)
-      return emitOpError("must have 0 or 1 result");
-    return success();
-  }];
+  let verifier = [{ return ::verify(*this); }];
   let parser = [{ return parseCallOp(parser, result); }];
   let printer = [{ printCallOp(p, *this); }];
 }
 def LLVM_ExtractElementOp : LLVM_OneResultOp<"extractelement", [NoSideEffect]>,
                           Arguments<(ins LLVM_AnyVector:$vector,
                                          LLVM_AnyInteger:$position)> {
   string llvmBuilder = [{
     $res = builder.CreateExtractElement($vector, $position);

mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

if (parser.resolveOperand(operands[0], wrappedFuncType, result.operands) ||
       return failure();
 
     result.addTypes(llvmResultType);
   }
 
   return success();
 }
 
+static LogicalResult verify(CallOp op) {
+  if (op.getNumResults() > 1)
+    return op.emitOpError("must have 0 or 1 result");
+
+  if (op.callee().hasValue() &&
+      !SymbolTable::lookupNearestSymbolFrom(op, op.callee().getValue()))
+    return op.emitOpError("calls an undeclared function");
+
+  return success();
+}
+
 //===----------------------------------------------------------------------===//
 // Printing/parsing for LLVM::ExtractElementOp.
 //===----------------------------------------------------------------------===//
 // Expects vector to be of wrapped LLVM vector type and position to be of
 // wrapped LLVM i32 type.
 void LLVM::ExtractElementOp::build(OpBuilder &b, OperationState &result,
                                    Value vector, Value position,
                                    ArrayRef<NamedAttribute> attrs) {

mlir/test/Dialect/LLVMIR/invalid.mlir

 
 func @store_non_ptr_type(%foo : !llvm.float, %bar : !llvm.float) {
   // expected-error@+1 {{expected LLVM pointer type}}
   llvm.store %bar, %foo : !llvm.float
 }
 
 // -----
 
+func @call_undeclared() {
+  // expected-error@+1 {{calls an undeclared function}}
+  llvm.call @undeclared() : () -> ()
+}
+
+// -----
+
 func @call_non_function_type(%callee : !llvm.func<i8 (i8)>, %arg : !llvm.i8) {
   // expected-error@+1 {{expected function type}}
   llvm.call %callee(%arg) : !llvm.func<i8 (i8)>
 }
 
 // -----
 
 func @call_too_many_results(%callee : () -> (i32,i32)) {