Page MenuHomePhabricator

[clang][codegen] Remove the insertion of `correctly-rounded-divide-sqrt-fp-math` fn-attr.
ClosedPublic

Authored by hliao on Sep 28 2020, 8:39 AM.

Details

Summary
  • -cl-fp32-correctly-rounded-divide-sqrt is already handled in a per-instruction manner by annotating the accuracy required. There's no need to add that fn-attr. So far, there's no in-tree backend handling that attr and that OpenCL specific option.
  • In case that out-of-tree backends are broken, this change could be reverted if those backends could not be fixed.

Diff Detail

Event Timeline

hliao created this revision.Sep 28 2020, 8:39 AM
hliao requested review of this revision.Sep 28 2020, 8:39 AM
bader accepted this revision.Sep 28 2020, 10:14 AM
This revision is now accepted and ready to land.Sep 28 2020, 10:14 AM

You might need add [OpenCL] tag to the commit message.