Page MenuHomePhabricator

[mlir] [VectorOps] generalize printing support for integers
ClosedPublic

Authored by aartbik on Sep 25 2020, 3:08 AM.

Details

Summary

This generalizes printing beyond just i1,i32,i64 and also accounts
for signed and unsigned interpretation in the output.

Diff Detail

Event Timeline

aartbik created this revision.Sep 25 2020, 3:08 AM
Herald added a project: Restricted Project. · View Herald Transcript
aartbik requested review of this revision.Sep 25 2020, 3:08 AM
aartbik updated this revision to Diff 294267.Sep 25 2020, 3:41 AM

fixed lint warning on library method name

nicolasvasilache accepted this revision.Sep 25 2020, 4:42 AM
This revision is now accepted and ready to land.Sep 25 2020, 4:42 AM

Can we promote everything to 64 bits to simplify the logic a bit? Otherwise looking good.

Can we promote everything to 64 bits to simplify the logic a bit? Otherwise looking good.

Sounds like a reasonable request, and in line with keeping the support library small.
I will send a follow up CL, also unifying the naming convention in the support lib.