This is an archive of the discontinued LLVM Phabricator instance.

[Suport][cmake] Change LLVM_INTEGRATED_CRT_ALLOC to a path instead of a boolean

Authored by aganea on Sep 14 2020, 6:57 AM.

Diff Detail

Event Timeline

aganea created this revision.Sep 14 2020, 6:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 14 2020, 6:57 AM
aganea requested review of this revision.Sep 14 2020, 6:57 AM
russell.gallop accepted this revision.EditedSep 15 2020, 9:21 AM

One small comment. Apart from that, LGTM.



I think it might make more sense to put all of the new LLVM_INTEGRATED_CRT_ALLOC code further up now, such as here, so it is not under "Define options to control the inclusion..." section which is (almost entirely) boolean options to enable build targets.

This revision is now accepted and ready to land.Sep 15 2020, 9:21 AM
This revision was automatically updated to reflect the committed changes.
aganea marked an inline comment as done.