Projects

User does not belong to any projects.

User Details

User Since
Sep 9 2014, 6:00 AM (414 w, 1 d)

Thu, Aug 11

Noting related review: https://reviews.llvm.org/D115815 which added this variable to support this for other "external projects".

Thu, Aug 11, 6:36 AM · Restricted Project, Restricted Project, Restricted Project

Feb 15 2022

Feb 15 2022, 7:42 AM · Restricted Project, Restricted Project, Restricted Project

Feb 9 2022

russell.gallop updated subscribers of D118550: [Support] Have ThreadPool initialize a TimeTraceProfiler per thread.

(There are visible changes around the name associated with the tracer in lld that someone familiar with this in lld should approve.)

Feb 9 2022, 1:55 AM · Restricted Project, Restricted Project, Restricted Project

Feb 1 2022

alternative approach

Feb 1 2022, 3:12 AM · Restricted Project, Restricted Project, Restricted Project
Feb 1 2022, 3:08 AM · Restricted Project, Restricted Project, Restricted Project

Jan 31 2022

Yeah, I think that's probably a good idea. It took me a while to figure out that initializing the profiler on a per-thread basis was required; it was not at all obvious why my profiler events had started disappearing while I was parallelizing lld. Having it done automatically would've saved me some headache.

Jan 31 2022, 6:03 AM · Restricted Project, Restricted Project, Restricted Project

Jan 31 2022, 1:58 AM · Restricted Project, Restricted Project, Restricted Project

Mar 10 2021

With an additional change from sizeof(buf) to buf.size() this fixes the check-asan and check-ubsan tests.

Mar 10 2021, 1:01 AM · Restricted Project

Mar 9 2021

In D96120#2597877, @kcc wrote:

I am afraid we will have to delete the older (non-standalone) variant entirely.
(And the sooner the better)

Mar 9 2021, 1:54 PM · Restricted Project, Restricted Project

These weren't present with the patch.

I presume you meant weren't present without the patch?

Mar 9 2021, 9:13 AM · Restricted Project

Can someone with a working windows sanitizers try this one out?

Mar 9 2021, 6:00 AM · Restricted Project

Mar 1 2021

russell.gallop added a comment to D96120: [scudo] Port scudo sanitizer to Windows.

Yes, it would need something similar - I tried whipping something together, which after some tweaks seems to work:
Feel free to squash that into your patch (which saves me a bit of effort) :-)

Mar 1 2021, 8:19 AM · Restricted Project, Restricted Project
russell.gallop updated the diff for D96120: [scudo] Port scudo sanitizer to Windows.

Update with suggested changes to MinGW.cpp

Mar 1 2021, 8:16 AM · Restricted Project, Restricted Project

Feb 27 2021

russell.gallop added a comment to D96120: [scudo] Port scudo sanitizer to Windows.

This is intended as a step to porting scudo standalone.

Why this is needed for scudo stadalone?

Feb 27 2021, 1:29 PM · Restricted Project, Restricted Project

Feb 26 2021

russell.gallop added a comment to D96120: [scudo] Port scudo sanitizer to Windows.

As is, this breaks compilation for mingw. With the three modifications I suggest here, it no longer breaks compilation for me - I have no idea if it actually works in mingw configurations though, but not breaking compilation is at least the first step.

Thanks for the information I'll try to run up a mingw environment and check it works.

In case that turns out to be tricky, I might be able to help with that, at least for building a simple test program with it and running it, if you say how it's supposed to be used (building/linking with -fsanitize=scudo?) and how to inspect whether it actually works.

Feb 26 2021, 9:37 AM · Restricted Project, Restricted Project
russell.gallop updated the diff for D96120: [scudo] Port scudo sanitizer to Windows.

Feb 26 2021, 9:06 AM · Restricted Project, Restricted Project

Feb 9 2021

russell.gallop added inline comments to D96133: Allow building with scudo memory allocator on Windows.
Feb 9 2021, 10:00 AM · Restricted Project
russell.gallop added a comment to D96120: [scudo] Port scudo sanitizer to Windows.

A few questions: Does this work on x86 targets?

Feb 9 2021, 4:11 AM · Restricted Project, Restricted Project
russell.gallop added a comment to D96120: [scudo] Port scudo sanitizer to Windows.

As is, this breaks compilation for mingw. With the three modifications I suggest here, it no longer breaks compilation for me - I have no idea if it actually works in mingw configurations though, but not breaking compilation is at least the first step.

Feb 9 2021, 3:43 AM · Restricted Project, Restricted Project

Feb 8 2021

russell.gallop updated the summary of D96120: [scudo] Port scudo sanitizer to Windows.
Feb 8 2021, 2:51 AM · Restricted Project, Restricted Project

Feb 5 2021

russell.gallop added inline comments to D96133: Allow building with scudo memory allocator on Windows.
Feb 5 2021, 9:36 AM · Restricted Project
russell.gallop updated the diff for D96133: Allow building with scudo memory allocator on Windows.

Feb 5 2021, 6:50 AM · Restricted Project

I believe that the MCJIT failures are due to bug https:/bugs.llvm.org/show_bug.cgi?id=24978 rather than a problem in the Scudo port so I have added details of how I hit it to that bugzilla and opened two reviews to get this landed:
https://reviews.llvm.org/D96120 - [scudo] Port scudo sanitizer to Windows
https://reviews.llvm.org/D96133 - Allow building with scudo memory allocator on Windows

Feb 5 2021, 6:40 AM · Restricted Project, Restricted Project, Restricted Project
russell.gallop requested review of D96133: Allow building with scudo memory allocator on Windows.
Feb 5 2021, 6:30 AM · Restricted Project
russell.gallop requested review of D96120: [scudo] Port scudo sanitizer to Windows.
Feb 5 2021, 4:30 AM · Restricted Project, Restricted Project

Feb 3 2021

I've focussed on the test test-global-init-nonzero-sm-pic.ll which fails writing to an address which (I believe) should be in the .data section but isn't.

Feb 3 2021, 9:46 AM · Restricted Project, Restricted Project, Restricted Project

Feb 2 2021

I managed to get this to fail in the debugger (for the cross-module-sm-pic-a.ll test):

Feb 2 2021, 10:00 AM · Restricted Project, Restricted Project, Restricted Project

Remove -fsanitize=scudo support for Windows in LLVM cmake, using LLVM_INTEGRATED_CRT_ALLOC instead.
Remove scudo_cxx from LLVM_INTEGRATED_CRT_ALLOC.

Feb 2 2021, 9:52 AM · Restricted Project, Restricted Project, Restricted Project

Dec 18 2020

Apologies for the delay, I've had other things taking my time.

Dec 18 2020, 9:14 AM · Restricted Project, Restricted Project, Restricted Project

Nov 9 2020

Resigning as reviewer as I also work for Sony.

Nov 9 2020, 2:57 AM · Restricted Project
Nov 9 2020, 2:50 AM · Restricted Project

Nov 5 2020

Nov 5 2020, 3:38 AM · Restricted Project

Oct 28 2020

Apologies for the delay, I've had a few other things on.

Oct 28 2020, 12:38 PM · Restricted Project, Restricted Project, Restricted Project

Sep 23 2020

I'm also in favor, I think this is good direction ahead. It'd be nice if following issues were fixed -- in subsequent patches if you wish:

• Stage1 ninja check-scudo fails many tests for me, see .
Sep 23 2020, 1:29 AM · Restricted Project, Restricted Project, Restricted Project

Sep 22 2020

I'm going to concentrate on the standalone port as I think that's the way forward. If I get that working then can work through the other issues.

Sep 22 2020, 2:38 AM · Restricted Project, Restricted Project, Restricted Project
Sep 22 2020, 1:56 AM · Restricted Project
Sep 22 2020, 1:40 AM · Restricted Project

Sep 17 2020

Sep 17 2020, 9:36 AM · Restricted Project
Sep 17 2020, 9:29 AM · Restricted Project, Restricted Project, Restricted Project

I think that I one point in time I tried thread_local but a compiler (can't remember which one) was complaining about the constructors not being trivial or something to that extent.
This is fairly blurry at this point, so I am sorry if this is not very helpful, but I just want to make sure this would work on all platforms with gcc/clang.

Sep 17 2020, 9:18 AM · Restricted Project

Sep 15 2020

One small comment. Apart from that, LGTM.

Sep 15 2020, 9:21 AM · Restricted Project

If 4.4 TB of virtual pages are mapped in each process (this happens on startup), then we quickly exaust the 48-bit (256 TB) addressable space with 72+ programs running (on a 36-core). Any idea where this 4.4 TB mapping comes from?

The size of the Primary is defined in https://github.com/llvm/llvm-project/blob/master/compiler-rt/lib/scudo/scudo_platform.h#L75
Scudo reserves that size but doesn't commit it, then it incrementally commits when memory is needed within the reserved region.

Sep 15 2020, 9:19 AM · Restricted Project, Restricted Project, Restricted Project

@russell.gallop I see a lots of failing tests when running ninja check-all on a Scudo-enabled build (stage 2). Do you see the same thing on your end?

Sep 15 2020, 9:12 AM · Restricted Project, Restricted Project, Restricted Project

Sep 14 2020

Thanks for working on this @russell.gallop!

I've reproduced your tests, please see below. The only difference is that I've used a ThinLTO build for stage2:

Sep 14 2020, 12:36 PM · Restricted Project, Restricted Project, Restricted Project
Sep 14 2020, 2:14 AM · Restricted Project

Re-upload patch with G LLVM Github Monorepo set.

Sep 14 2020, 1:31 AM · Restricted Project, Restricted Project, Restricted Project

Sep 11 2020

Is there a good sanity check that it is actually using Scudo rather than silently using the standard alloc?

Sep 11 2020, 9:20 AM · Restricted Project, Restricted Project, Restricted Project

Fixup scudo (sanitizer based) to work on Windows.

Sep 11 2020, 9:15 AM · Restricted Project, Restricted Project, Restricted Project

Aug 28 2020

Aug 28 2020, 10:03 AM · Restricted Project, Restricted Project, Restricted Project
russell.gallop added a comment to D86714: Remove leftover REQUIRES: global-isel.

Thanks for catching that.

Aug 28 2020, 2:00 AM · Restricted Project

Aug 27 2020

You marked D42519 as WIP, can you remember what was still TBD?

Aug 27 2020, 9:39 AM · Restricted Project, Restricted Project, Restricted Project
[Test] Tidy up loose ends from LLVM_HAS_GLOBAL_ISEL
Aug 27 2020, 8:37 AM · Restricted Project
russell.gallop updated the diff for D86714: Remove leftover REQUIRES: global-isel.

Fix llvm-config test.

Aug 27 2020, 8:30 AM · Restricted Project

That's awesome! Is it meant to eventually be committed or only be used for comparison purposes?

Aug 27 2020, 7:58 AM · Restricted Project, Restricted Project, Restricted Project
russell.gallop updated the diff for D86714: Remove leftover REQUIRES: global-isel.

I assume something in lit is parsing and recognizing this? Should remove that too?

Aug 27 2020, 7:40 AM · Restricted Project

It's always available now. The requires global-isel is a leftover that should be removed

Aug 27 2020, 7:22 AM · Restricted Project
russell.gallop requested review of D86714: Remove leftover REQUIRES: global-isel.
Aug 27 2020, 7:22 AM · Restricted Project

That's the right fix

Aug 27 2020, 6:33 AM · Restricted Project
russell.gallop updated subscribers of D85199: GlobalISel: Add generic instructions for memory intrinsics.

Hi Matt,

Aug 27 2020, 4:56 AM · Restricted Project
Fix for PS4 bots after 0b7f6cc71a72a85f8a0cbee836a7a8e31876951a

I'd also like to see how they (currently supported allocators) compare vs. SCUDO and vs. tcmalloc3, if someone is willing to port those on Windows.

Aug 27 2020, 3:13 AM · Restricted Project
russell.gallop added a comment to D42519: [scudo] Windows port WIP.

I've applied this to the monorepo and made a few more changes to allow it to build LLVM on Windows here: https://reviews.llvm.org/D86694

Aug 27 2020, 3:07 AM · Restricted Project
Aug 27 2020, 3:05 AM · Restricted Project, Restricted Project, Restricted Project

Aug 4 2020

russell.gallop committed rG98827feddb90: [lit] Add --time-trace-output to lit (authored by russell.gallop).
Aug 4 2020, 6:26 AM · Restricted Project

Jul 31 2020

Thanks for your work on this. I've just tried out this version with rpmalloc (1.4.0) checked out out at the top of llvm-project.

Jul 31 2020, 9:02 AM · Restricted Project
Jul 31 2020, 6:31 AM · Restricted Project
Jul 31 2020, 4:31 AM · Restricted Project
russell.gallop updated the diff for D84931: [lit] Add --time-trace-output to lit.

Jul 31 2020, 4:22 AM · Restricted Project

Jul 30 2020

russell.gallop updated the summary of D84931: [lit] Add --time-trace-output to lit.
Jul 30 2020, 4:06 AM · Restricted Project
russell.gallop requested review of D84931: [lit] Add --time-trace-output to lit.
Jul 30 2020, 4:00 AM · Restricted Project

Jul 28 2020

It looks like is causing one of the debuginfo-tests: llgdb-tests/nrvo-string.cpp to fail, run on Linux. Failure as below. I don't think the debuginfo-tests are run on any bot (but probably should be!). I bisected the failure back to this change.

Jul 28 2020, 2:53 AM · debug-info, Restricted Project, Restricted Project

Jul 23 2020

russell.gallop added a comment to D82379: [docs] Fix TestSuiteGuide.md to mention scipy.

LGTM, thanks for updating the docs!

I guess it would be even better if we would provide the dependencies in a machine-readable way, e..g. https://python-packaging.readthedocs.io/en/latest/dependencies.html

Patches welcome :)

Jul 23 2020, 6:23 AM · Restricted Project
russell.gallop committed rGc798628fbdcc: [docs] Fix TestSuiteGuide.md to mention scipy (authored by russell.gallop).
[docs] Fix TestSuiteGuide.md to mention scipy
Jul 23 2020, 6:22 AM · Restricted Project

Jul 1 2020

I also don't know what exactly the policy around third_party code is, so discussing this on llvm-dev is probably a good idea.

But perhaps one way of side-stepping the whole issue would be to not check in rpmalloc into LLVM, but make the user point at it if they want to use it through a cmake variable, e.g. -DLLVM_USE_RPMALLOC=c:\path\to\rpmalloc (if such a thing is technically practical, I don't know)

Jul 1 2020, 4:49 AM · Restricted Project

Jun 30 2020

I notice that the improvements to rpmalloc for LLVM are still under discussion (https://github.com/mjansson/rpmalloc/issues/150) and targetted at rpmalloc v1.4.1.

Jun 30 2020, 10:18 AM · Restricted Project

Jun 23 2020

Jun 23 2020, 7:25 AM · Restricted Project

Jun 4 2020

Revert "Relands "[YAMLVFSWriter][Test][NFC] Add couple tests" vol. 2"

The test is failing on Windows again: http://45.33.8.238/win/16808/step_11.txt Please take a look and revert for now if it takes a while to investigate.

Jun 4 2020, 7:04 AM · Restricted Project

May 29 2020

This needs be done on a per-target basis, not globally (e.g. you may want to use COMPILER_RT_BUILD_SANITIZERS=OFF for target1 but not target2). Have you tried setting RUNTIMES_\${target}_COMPILER_RT_BUILD_SANITIZERS=OFF? This should be already supported, see for example https://github.com/llvm/llvm-project/blob/master/clang/cmake/caches/Fuchsia-stage2.cmake#L100

May 29 2020, 3:13 AM · Restricted Project

May 28 2020

russell.gallop added a comment to D78454: [clangd] Highlight related control flow..

Hi Sam,

May 28 2020, 7:34 AM · Restricted Project

May 22 2020

May 22 2020, 9:05 AM · Restricted Project

May 15 2020

[ELF] Update release notes and man page for LLD time-trace
May 15 2020, 12:52 AM · Restricted Project, lld

May 14 2020

russell.gallop updated the diff for D79780: [LLD][ELF] Add lld --time-trace to man page and release notes.

Removed excess dashes in man page. Checked with:

May 14 2020, 9:43 AM · Restricted Project, lld
May 14 2020, 2:38 AM · Restricted Project, lld
russell.gallop updated the diff for D79780: [LLD][ELF] Add lld --time-trace to man page and release notes.

Change to double dashes.

May 14 2020, 2:38 AM · Restricted Project, lld

May 13 2020

[DebugInfo] Fix test Fortran-DIModule.ll after 678bd84c4
russell.gallop added a comment to D79484: [DebugInfo] Fortran module DebugInfo support in LLVM.

This breaks tests on Windows: http://45.33.8.238/win/15149/step_11.txt

Please take a look and revert if it takes a while to investigate.

May 13 2020, 7:32 AM · Restricted Project, debug-info

May 12 2020

Should this go into the docs / man page / release notes / etc.?

Probably. I'll take a look.

May 12 2020, 6:57 AM · Restricted Project
May 12 2020, 6:57 AM · Restricted Project, lld

Apr 22 2020

LGTM, with a few small comments.

Apr 22 2020, 1:35 AM · Restricted Project

Apr 15 2020

Apr 15 2020, 3:14 AM · Restricted Project
russell.gallop added a reviewer for D78153: [TimeProfiler] Fix some style issues. NFC: anton-afanasyev.
Apr 15 2020, 3:14 AM · Restricted Project

Apr 14 2020

Would be nice if the test could check that the pid was being set to something but not sure how you could do that (beyond checking that it's a number).

Apr 14 2020, 7:27 AM · Restricted Project

Mar 24 2020

russell.gallop added a comment to D76695: [CMSE] Fix bogus save-temps.c tests.

LGTM, thanks.