- User Since
- Sep 9 2014, 6:00 AM (261 w, 5 d)
Thu, Sep 5
Fri, Aug 30
Realised that this could be done with just an assert (no separate check function) so this is a much smaller patch now. This still mostly hits the assertion with the previous way of calculating duration (duration_cast). I think the extra code in end() may make it slightly less likely that this case happens, but only with assertions enabled.
Fri, Aug 23
Fix some style issues and remove unit test.
Thu, Aug 22
Added structure check on time profile and assertion.
Wed, Aug 21
Tue, Aug 20
Mon, Aug 19
I don't know a lot about the structure of clang but it LGTM from the point of view of the code and traces coming out.
Aug 15 2019
Jul 12 2019
Jul 2 2019
Jun 24 2019
Jun 7 2019
Jun 5 2019
Re-added test cases using variables and added comment. This now tests both formats.
Jun 4 2019
We support non immediate on these because gcc does.
I'll have a look and see if there is a reason why these don't fail in the same way (which would make the test fail in it's current form).
Then the test should be failing? Or is the current form also legal?
Is the compiler missing a check that these parameters are immediates?
I'm not sure what you mean.
May 31 2019
May 30 2019
May 29 2019
https://reviews.llvm.org/D62200 has landed so -fprofile-generate and -fcs-profile-generate both add --dependent-lib (required for this patch to make sense).
May 28 2019
I was going to suggest that maybe what we should do is just embed the basename, i.e. /nodefaultlib:clang_rt.profile-x86_64.lib ...
it looks like passing -no-canonical-prefixes makes this path relative
Hello, this embeds an absolute path into the generated .obj file, which means the output now is no longer deterministic (since it depends on the absolute path to clang_rt.profile-x86_64.lib).
May 22 2019
May 21 2019
1). -fprofile-generate and -fcs-profile-generate need clang_rt.profile adding with --dependent-lib in the driver (like https://reviews.llvm.org/D61742). I'll create a separate review for that.
2). Self hosting with -fprofile-generate hits a crash building CrashRecoveryContext.cpp. I'll try to report this.
Handle -fprofile-generate and -fcs-profile-generate options for self hosting as well.
May 17 2019
May 14 2019
May 10 2019
Prevent adding -dependent-lib on mingw32 and add tests.
May 9 2019
Apr 30 2019
Apr 29 2019
Apr 26 2019
Mar 7 2019
Apr 11 2018
We also see an assertion failure prior to the revert. At r329738:
Jun 8 2017
May 26 2017
Sep 11 2015
I found a number of bugs comparing direct object emission and via assembly with the check_cfc tool. Sean I and spoke about using fuzzing in that area. I expect it would find issues but I haven't done any work on it so no objections if someone wanted to add this to llvm-mc-fuzzer.
Jun 3 2015
Thanks for the review Rafael.
Jun 2 2015
Apr 2 2015
Thanks Rafael. I've fixed the 80 col violations and committed revision 233919.
Apr 1 2015
Fixes for points raised by Rafael.
Fix line endings.
Use -via-file-asm for dash_s_no_change check.