Page MenuHomePhabricator

russell.gallop (Russell Gallop)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 9 2014, 6:00 AM (281 w, 9 h)

Recent Activity

Today

russell.gallop added inline comments to D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).
Tue, Jan 28, 10:11 AM · Restricted Project
russell.gallop updated the diff for D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).
Tue, Jan 28, 10:11 AM · Restricted Project

Yesterday

russell.gallop committed rG77e6bb3cbad2: Re-land [Support] Extend TimeProfiler to support multiple threads (authored by russell.gallop).
Re-land [Support] Extend TimeProfiler to support multiple threads
Mon, Jan 27, 5:08 AM
russell.gallop closed D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).
Mon, Jan 27, 5:08 AM · Restricted Project

Fri, Jan 24

russell.gallop added a comment to D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).

I'm not qualified to comment on the functionality. This seems like it'll be OK with respect to thread_local on Mac OSX. No further comments from me.

Fri, Jan 24, 9:35 AM · Restricted Project
russell.gallop added a comment to D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).

Thanks, added const.

Fri, Jan 24, 9:17 AM · Restricted Project
russell.gallop updated the diff for D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).

Add consts to references in lambda functions.

Fri, Jan 24, 9:17 AM · Restricted Project
russell.gallop added a comment to D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).

Ping. Okay to land new version?

Fri, Jan 24, 7:47 AM · Restricted Project

Thu, Jan 23

russell.gallop committed rG4662f6e1c778: [test] Avoid loop-unroll.c test getting confused by fadd in git revision (authored by russell.gallop).
[test] Avoid loop-unroll.c test getting confused by fadd in git revision
Thu, Jan 23, 1:42 AM
russell.gallop closed D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision.
Thu, Jan 23, 1:42 AM · Restricted Project
russell.gallop added a comment to D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision.

Oh, wow! Might I ask you add the same for fmul? We may get a revision like that next time :).
Thank you!

Thu, Jan 23, 1:33 AM · Restricted Project
russell.gallop updated the diff for D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision.

Update to check for start of metadata.

Thu, Jan 23, 1:26 AM · Restricted Project

Wed, Jan 22

russell.gallop created D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision.
Wed, Jan 22, 1:27 AM · Restricted Project

Tue, Jan 21

russell.gallop created D73123: [CMake] Fixes for including LLVM into another CMake project.
Tue, Jan 21, 10:19 AM · Restricted Project, Restricted Project

Wed, Jan 15

russell.gallop added a comment to D72390: [www] Remove stale text about default c++ standard from cxx_status.html.

Ping. Is this okay to land, or have I missed something? Thanks.

Wed, Jan 15, 3:33 AM · Restricted Project
russell.gallop committed rG884a65af5cee: [Support] Replace Windows __declspec(thread) with thread_local for… (authored by russell.gallop).
[Support] Replace Windows __declspec(thread) with thread_local for…
Wed, Jan 15, 3:24 AM
russell.gallop closed D72399: [Support] Replace Windows __declspec(thread) with thread_local in LLVM_THREAD_LOCAL.
Wed, Jan 15, 3:24 AM · Restricted Project
russell.gallop added a comment to D72399: [Support] Replace Windows __declspec(thread) with thread_local in LLVM_THREAD_LOCAL.
In D72399#1820866, @rnk wrote:

lgtm

I checked that __declspec(thread) and thread_local seem to be functionally equivalent with MSVC.

Wed, Jan 15, 3:15 AM · Restricted Project

Fri, Jan 10

russell.gallop added inline comments to D72399: [Support] Replace Windows __declspec(thread) with thread_local in LLVM_THREAD_LOCAL.
Fri, Jan 10, 5:26 AM · Restricted Project
russell.gallop updated the diff for D72399: [Support] Replace Windows __declspec(thread) with thread_local in LLVM_THREAD_LOCAL.

Fix condition

Fri, Jan 10, 5:26 AM · Restricted Project
russell.gallop added a comment to D72399: [Support] Replace Windows __declspec(thread) with thread_local in LLVM_THREAD_LOCAL.

Sounds good to me - but probably good to get someone who works on the MSVC platform (like @rnk ) to confirm.

Fri, Jan 10, 3:58 AM · Restricted Project
russell.gallop added a comment to D71786: RFC: [Support] On Windows, add optional support for rpmalloc.

Am I the only one who is a little bit uncomfortable with including a replacement to the system allocator in LLVM?

Fri, Jan 10, 3:58 AM · Restricted Project

Thu, Jan 9

russell.gallop added a comment to D71786: RFC: [Support] On Windows, add optional support for rpmalloc.

At first, I configured rpmalloc in the "unlimited" mode because I wanted maximum performance. I now reverted to default rpmalloc flags, and the memory usage has decreased (albeit still higher than the Windows Heap), with no impact on link time (meaning that timings are still the same as in the Summary). Below are "Max" values when linking clang.exe with ThinLTO:

Thu, Jan 9, 8:02 AM · Restricted Project

Wed, Jan 8

russell.gallop added inline comments to D71786: RFC: [Support] On Windows, add optional support for rpmalloc.
Wed, Jan 8, 8:46 AM · Restricted Project
russell.gallop created D72399: [Support] Replace Windows __declspec(thread) with thread_local in LLVM_THREAD_LOCAL.
Wed, Jan 8, 6:53 AM · Restricted Project
russell.gallop created D72390: [www] Remove stale text about default c++ standard from cxx_status.html.
Wed, Jan 8, 2:06 AM · Restricted Project

Tue, Jan 7

russell.gallop added a comment to D71786: RFC: [Support] On Windows, add optional support for rpmalloc.

I would say it's mostly down to application usage patterns. The worst case is probably a gc-like usage where one thread does all allocation and another all deallocation, as this will cause all blocks to cross the thread cache via an atomic pointer CAS and eventually cause larger spans of blocks to traverse the thread caches via the global cache. However, even this scenario will probably be significantly faster than the standard runtime allocator.

I have not had the opportunity to test this on other hardware than single-socket consumer hardware, game consoles and handheld devices, mostly due to me working in that spectrum and being the sole developer of it. It does seem that @aganea has tried it on more service facing hardware, perhaps he can give additional input.

Tue, Jan 7, 7:42 AM · Restricted Project
russell.gallop added a comment to D71786: RFC: [Support] On Windows, add optional support for rpmalloc.

1). This also seems to improve compile time by around 5% for me. Presumably this is due to some other benefit of rpmalloc as (AFAIK) clang.exe does not use multiple threads.

Yes, generally rpmalloc improves single-threaded allocation performance over the default runtime, especially for small block allocations (below 1KiB), enough to warrant using it only for this use case.

Tue, Jan 7, 5:22 AM · Restricted Project
russell.gallop updated the diff for D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).

Add comment to clarify usage of timeTraceProfilerCleanup.

Tue, Jan 7, 4:09 AM · Restricted Project
russell.gallop added inline comments to D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).
Tue, Jan 7, 3:51 AM · Restricted Project
russell.gallop updated the diff for D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).

Fix memory leak.

Tue, Jan 7, 3:23 AM · Restricted Project

Mon, Jan 6

russell.gallop reopened D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).
Mon, Jan 6, 11:24 AM · Restricted Project
russell.gallop updated the diff for D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).

I reverted this at the end of last year MacOS build issues.

Mon, Jan 6, 11:24 AM · Restricted Project
russell.gallop abandoned D71548: Fix time trace multi threaded support with LLVM_ENABLE_THREADS=OFF.

Abandoning this review. Will roll fix for these issues into new version on D71059.

Mon, Jan 6, 8:44 AM · Restricted Project

Fri, Jan 3

russell.gallop added a comment to D71786: RFC: [Support] On Windows, add optional support for rpmalloc.

I have done some performance evaluations here and LLVM_ENABLE_RPMALLOC does seem to improve ThinLTO link times and CPU utilisation during ThinLTO.

Fri, Jan 3, 7:06 AM · Restricted Project
russell.gallop added a comment to D71786: RFC: [Support] On Windows, add optional support for rpmalloc.

It fails creating a library

Could you please run ninja -v, and ensure LLVMSupport.lib appears first on the linker cmd-line? (before other libs).

Fri, Jan 3, 3:42 AM · Restricted Project

Thu, Jan 2

russell.gallop added a comment to D71786: RFC: [Support] On Windows, add optional support for rpmalloc.

Thanks for the patch. I applied it (to 8188c998ffa4d20253444b257402907d2aa74dc2), specified LLVM_ENABLE_RPMALLOC=ON and -DLLVM_USE_CRT_RELEASE=MT and tried to build with MS cl.exe/link.exe. It fails creating a library:

Thu, Jan 2, 7:17 AM · Restricted Project

Dec 24 2019

russell.gallop added inline comments to D71548: Fix time trace multi threaded support with LLVM_ENABLE_THREADS=OFF.
Dec 24 2019, 3:46 AM · Restricted Project
russell.gallop committed rG2e9bfa12ff34: Revert "[Support] Extend TimeProfiler to support multiple threads" (authored by russell.gallop).
Revert "[Support] Extend TimeProfiler to support multiple threads"
Dec 24 2019, 3:39 AM
russell.gallop added a reverting change for rG8ddcd1dc26ba: [Support] Extend TimeProfiler to support multiple threads: rG2e9bfa12ff34: Revert "[Support] Extend TimeProfiler to support multiple threads".
Dec 24 2019, 3:39 AM
russell.gallop added a reverting change for rGf70f18014854: [Support] Try to fix bot failure after 8ddcd1dc26: rG2e9bfa12ff34: Revert "[Support] Extend TimeProfiler to support multiple threads".
Dec 24 2019, 3:38 AM

Dec 23 2019

russell.gallop added inline comments to D71548: Fix time trace multi threaded support with LLVM_ENABLE_THREADS=OFF.
Dec 23 2019, 6:30 AM · Restricted Project
russell.gallop added a comment to D71548: Fix time trace multi threaded support with LLVM_ENABLE_THREADS=OFF.

Ping! Okay to land this? (I moved it back to needs review as this was very different from before).

Dec 23 2019, 4:40 AM · Restricted Project

Dec 18 2019

russell.gallop added a comment to D71548: Fix time trace multi threaded support with LLVM_ENABLE_THREADS=OFF.

@ruiu or @Kai I would like this to go in with D71060. Are you okay with this revised fix?

Dec 18 2019, 2:16 AM · Restricted Project
russell.gallop updated the diff for D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).

Rename scopes as requested.

Dec 18 2019, 2:12 AM · Restricted Project

Dec 17 2019

russell.gallop added inline comments to D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).
Dec 17 2019, 7:58 AM · Restricted Project
russell.gallop updated the diff for D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).

Removed "Merge input sections" scope.
Also moved "ExecuteLinker" to cover longer time period, including initLLVM() etc..

Dec 17 2019, 7:58 AM · Restricted Project
russell.gallop added a comment to D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).

I have a general question about the llvm::TimeTraceScope timeScope("LTO"); trace sites. Shall we just use the container function name if applicable?

Dec 17 2019, 5:42 AM · Restricted Project
russell.gallop requested review of D71548: Fix time trace multi threaded support with LLVM_ENABLE_THREADS=OFF.
Dec 17 2019, 4:35 AM · Restricted Project
russell.gallop updated the diff for D71548: Fix time trace multi threaded support with LLVM_ENABLE_THREADS=OFF.

More specific implementation. Just avoid thread_local when LLVM_ENABLE_THREADS=OFF.

Dec 17 2019, 4:25 AM · Restricted Project
russell.gallop reopened D71548: Fix time trace multi threaded support with LLVM_ENABLE_THREADS=OFF.
Dec 17 2019, 4:25 AM · Restricted Project
russell.gallop added a comment to D71548: Fix time trace multi threaded support with LLVM_ENABLE_THREADS=OFF.

I don't think LLVM_THREAD_LOCAL is correct here. unique_ptr isn't a POD so this doesn't really fit to the use case of` LLVM_THREAD_LOCAL`. Maybe we should have a LLVM_NONTRIVIAL_THREAD_LOCAL. that doesn't fall back to __thread. Or we just use raw pointer here instead of a global unique_ptr (it seems that we anyway use it here just as an annotation to describe memory ownership?).

Dec 17 2019, 2:51 AM · Restricted Project
russell.gallop committed rG531c71118f29: Revert "[Support] Fix time trace multi threaded support with… (authored by russell.gallop).
Revert "[Support] Fix time trace multi threaded support with…
Dec 17 2019, 1:07 AM
russell.gallop added a reverting change for rG2bbcf156acc1: [Support] Fix time trace multi threaded support with LLVM_ENABLE_THREADS=OFF: rG531c71118f29: Revert "[Support] Fix time trace multi threaded support with….
Dec 17 2019, 1:07 AM
russell.gallop committed rG2bbcf156acc1: [Support] Fix time trace multi threaded support with LLVM_ENABLE_THREADS=OFF (authored by russell.gallop).
[Support] Fix time trace multi threaded support with LLVM_ENABLE_THREADS=OFF
Dec 17 2019, 12:48 AM
russell.gallop closed D71548: Fix time trace multi threaded support with LLVM_ENABLE_THREADS=OFF.
Dec 17 2019, 12:48 AM · Restricted Project

Dec 16 2019

russell.gallop updated the diff for D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).

Fix to work with LLVM_ENABLE_THREADS=OFF. In this mode ThinLTO still uses tasks but need to avoid re-initialising the time profiler.

Dec 16 2019, 8:52 AM · Restricted Project
russell.gallop added a comment to D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).

This patch breaks the build on Apple Clang (Mac OSX 10.13.6).

$ ninja clang
[27/2870] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/TimeProfiler.cpp.o
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/TimeProfiler.cpp.o 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++  -DGTEST_HAS_RTTI=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/Support -I/llvm-project/llvm/lib/Support -I/usr/include/libxml2 -Iinclude -I/llvm-project/llvm/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -O2 -g -DNDEBUG   -std=c++14  -fno-exceptions -fno-rtti -MD -MT lib/Support/CMakeFiles/LLVMSupport.dir/TimeProfiler.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/TimeProfiler.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/TimeProfiler.cpp.o -c /llvm-project/llvm/lib/Support/TimeProfiler.cpp
In file included from /llvm-project/llvm/lib/Support/TimeProfiler.cpp:13:
/llvm-project/llvm/include/llvm/Support/TimeProfiler.h:17:8: error: thread-local storage is not supported for the current target
extern thread_local std::unique_ptr<TimeTraceProfiler>
       ^
/llvm-project/llvm/lib/Support/TimeProfiler.cpp:36:1: error: thread-local storage is not supported for the current target
thread_local std::unique_ptr<TimeTraceProfiler> TimeTraceProfilerInstance =
^
2 errors generated.

I guess this is related to the LLVM_ENABLE_THREADS issue mentioned above.

Dec 16 2019, 7:01 AM · Restricted Project
russell.gallop created D71548: Fix time trace multi threaded support with LLVM_ENABLE_THREADS=OFF.
Dec 16 2019, 7:01 AM · Restricted Project
russell.gallop added inline comments to D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).
Dec 16 2019, 3:26 AM · Restricted Project
russell.gallop added a comment to D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).
In D71059#1785471, @Kai wrote:

This PR requires TLS support even if LLVM_ENABLE_THREADS is set to OFF. Is this intended?

Dec 16 2019, 3:25 AM · Restricted Project
russell.gallop updated the diff for D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).

Fix recent review comments.

Dec 16 2019, 3:25 AM · Restricted Project

Dec 12 2019

russell.gallop added a comment to D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).

Thanks for the comments. I believe I've fixed them all now.

Dec 12 2019, 9:09 AM · Restricted Project
russell.gallop updated the diff for D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).

Add test for writing trace to stdout

Dec 12 2019, 9:09 AM · Restricted Project
russell.gallop updated the diff for D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).

Change to appending .time-trace as default name.
Make -time-trace-file a separate option
Use temp names in tests

Dec 12 2019, 8:42 AM · Restricted Project
russell.gallop set the repository for D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2) to rG LLVM Github Monorepo.
Dec 12 2019, 8:42 AM · Restricted Project
russell.gallop committed rGf70f18014854: [Support] Try to fix bot failure after 8ddcd1dc26 (authored by russell.gallop).
[Support] Try to fix bot failure after 8ddcd1dc26
Dec 12 2019, 4:25 AM
russell.gallop committed rG8ddcd1dc26ba: [Support] Extend TimeProfiler to support multiple threads (authored by russell.gallop).
[Support] Extend TimeProfiler to support multiple threads
Dec 12 2019, 4:06 AM
russell.gallop closed D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).
Dec 12 2019, 4:06 AM · Restricted Project

Dec 11 2019

russell.gallop updated the diff for D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).

Removed StringRef("") in several places after D71347.
Added some more time scopes to account for gaps in time trace.
Updated tests for args/detail not always being present.

Dec 11 2019, 9:26 AM · Restricted Project
russell.gallop committed rGdf494f7512b0: [Support] Add TimeTraceScope constructor without detail arg (authored by russell.gallop).
[Support] Add TimeTraceScope constructor without detail arg
Dec 11 2019, 6:36 AM
russell.gallop closed D71347: Add TimeTraceScope constructor without detail arg to simplify code where no detail required.
Dec 11 2019, 6:36 AM · Restricted Project, Restricted Project
russell.gallop created D71347: Add TimeTraceScope constructor without detail arg to simplify code where no detail required.
Dec 11 2019, 5:04 AM · Restricted Project, Restricted Project
russell.gallop added inline comments to D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).
Dec 11 2019, 5:04 AM · Restricted Project
russell.gallop added a comment to D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).

Here are some examples of the output from LLD. One for a llvm-tblgen ThinLTO link (-time-trace-granularity=50000) and a clang Release build (-time-trace-granularity=500). The clang link has some significant gaps in it. I'll see if I can identify where they're from and trace them.

Dec 11 2019, 4:55 AM · Restricted Project
russell.gallop added a comment to D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).

Can you share an example output of lld with this patch?

Dec 11 2019, 2:57 AM · Restricted Project
russell.gallop added inline comments to D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).
Dec 11 2019, 2:56 AM · Restricted Project

Dec 10 2019

russell.gallop updated the diff for D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).

Add tests to patch.

Dec 10 2019, 3:53 AM · Restricted Project
russell.gallop added a comment to D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).

I mean the test like clang/test/Driver/check-time-trace.cpp, but for the multithreaded invocation. Yes, for instance, for ThinLTO (but I see no tests in the D71060).

Dec 10 2019, 3:44 AM · Restricted Project
russell.gallop added a comment to D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).

Btw, is it planned to add test for multithreading?

Dec 10 2019, 2:59 AM · Restricted Project

Dec 5 2019

russell.gallop updated the summary of D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).
Dec 5 2019, 5:17 AM · Restricted Project
russell.gallop created D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).
Dec 5 2019, 5:17 AM · Restricted Project
russell.gallop created D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).
Dec 5 2019, 5:16 AM · Restricted Project

Dec 4 2019

russell.gallop closed D69098: Remove -DLLVM_USE_LINKER from Windows self host bots.

Committed in 061123f05ff0813c36287d2105cb5344d494592b. Closing.

Dec 4 2019, 7:21 AM · Restricted Project
russell.gallop abandoned D69030: [cmake] Suppress unknown argument warning when linking with lld-link.

Agreed that this usage shouldn't be encouraged so abandoning review.

Dec 4 2019, 7:13 AM · Restricted Project

Dec 3 2019

russell.gallop committed rGaedeab7f85ca: [Support] Add ProcName to TimeTraceProfiler (authored by russell.gallop).
[Support] Add ProcName to TimeTraceProfiler
Dec 3 2019, 5:09 AM
russell.gallop closed D70950: Add ProcName to TimeTraceProfiler.
Dec 3 2019, 5:09 AM · Restricted Project, Restricted Project
russell.gallop created D70950: Add ProcName to TimeTraceProfiler.
Dec 3 2019, 3:09 AM · Restricted Project, Restricted Project
russell.gallop committed rGdf943a7a0810: [NFC] Tidy-ups to TimeProfiler.cpp (authored by russell.gallop).
[NFC] Tidy-ups to TimeProfiler.cpp
Dec 3 2019, 1:47 AM
russell.gallop closed D70904: Tidy-ups to TimeProfiler.cpp [NFC].
Dec 3 2019, 1:47 AM · Restricted Project
russell.gallop added a comment to D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation.

Thanks for the updated timings. I have no objection to this going in.

Dec 3 2019, 1:46 AM · Restricted Project, Restricted Project

Dec 2 2019

russell.gallop added a comment to D69043: [RFC] Adding time-trace to LLD?.

I've re-implemented this using thread local time tracing.

Dec 2 2019, 7:22 AM · Restricted Project, Restricted Project
russell.gallop created D70904: Tidy-ups to TimeProfiler.cpp [NFC].
Dec 2 2019, 7:04 AM · Restricted Project

Nov 27 2019

russell.gallop added a comment to D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation.

It looks like the git apply didn't work, but the script continued so this was a duff experiment, please ignore. I'll try to fix this and run it again.

Nov 27 2019, 2:31 AM · Restricted Project, Restricted Project

Nov 26 2019

russell.gallop added a comment to D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation.

So in this case it saved 0.5% of time. Using the previous maths, with 2378 clang-cl jobs, this implies process creation time of 29ms. This was fairly soon after a reboot. Maybe I'm just lucky and none of the process creation problems are affecting me on this system (at this moment).

Nov 26 2019, 9:13 AM · Restricted Project, Restricted Project
russell.gallop added a comment to D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation.

Thanks for the feedback Russell!

Can you possibly try again with /MT? (ie. -DLLVM_USE_CRT_RELEASE=MT)

Nov 26 2019, 8:07 AM · Restricted Project, Restricted Project

Nov 22 2019

russell.gallop added a comment to D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation.

Thanks for this change. I applied this patch (prior to splitting out https://reviews.llvm.org/D70568) and it built and worked okay (I only see one clang-cl in process explorer).

Nov 22 2019, 6:05 AM · Restricted Project, Restricted Project

Nov 18 2019

russell.gallop committed rGaea7578fade2: [NFC] Fix test reserve_global_reg.ll after 2d739f9 (authored by russell.gallop).
[NFC] Fix test reserve_global_reg.ll after 2d739f9
Nov 18 2019, 7:07 AM

Nov 8 2019

russell.gallop committed rG0a8bd77e7741: [cmake] Enable thin lto cache when building with lld-link (authored by russell.gallop).
[cmake] Enable thin lto cache when building with lld-link
Nov 8 2019, 2:49 AM
russell.gallop closed D69941: [cmake] Enable thin lto cache when building with lld-link.
Nov 8 2019, 2:49 AM · Restricted Project