Page MenuHomePhabricator

russell.gallop (Russell Gallop)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 9 2014, 6:00 AM (315 w, 6 d)

Recent Activity

Wed, Sep 23

russell.gallop added a comment to D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).

I'm also in favor, I think this is good direction ahead. It'd be nice if following issues were fixed -- in subsequent patches if you wish:

  • Stage1 ninja check-scudo fails many tests for me, see .
Wed, Sep 23, 1:29 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Sep 22

russell.gallop added a comment to D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).

I'm going to concentrate on the standalone port as I think that's the way forward. If I get that working then can work through the other issues.

Tue, Sep 22, 2:38 AM · Restricted Project, Restricted Project, Restricted Project
russell.gallop accepted D88046: [scudo][standalone] Remove the pthread key from the shared TSD.
Tue, Sep 22, 1:56 AM · Restricted Project
russell.gallop added inline comments to D87420: scudo: Introduce a new mechanism to let Scudo access a platform-specific TLS slot.
Tue, Sep 22, 1:40 AM · Restricted Project

Thu, Sep 17

russell.gallop added inline comments to D87420: scudo: Introduce a new mechanism to let Scudo access a platform-specific TLS slot.
Thu, Sep 17, 9:36 AM · Restricted Project
russell.gallop updated subscribers of D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).
Thu, Sep 17, 9:29 AM · Restricted Project, Restricted Project, Restricted Project
russell.gallop added a comment to D87478: scudo: Remove the THREADLOCAL macro..

I think that I one point in time I tried thread_local but a compiler (can't remember which one) was complaining about the constructors not being trivial or something to that extent.
This is fairly blurry at this point, so I am sorry if this is not very helpful, but I just want to make sure this would work on all platforms with gcc/clang.

Thu, Sep 17, 9:18 AM · Restricted Project

Tue, Sep 15

russell.gallop accepted D87609: [Suport][cmake] Change LLVM_INTEGRATED_CRT_ALLOC to a path instead of a boolean.

One small comment. Apart from that, LGTM.

Tue, Sep 15, 9:21 AM · Restricted Project
russell.gallop added a comment to D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).

If 4.4 TB of virtual pages are mapped in each process (this happens on startup), then we quickly exaust the 48-bit (256 TB) addressable space with 72+ programs running (on a 36-core). Any idea where this 4.4 TB mapping comes from?

The size of the Primary is defined in https://github.com/llvm/llvm-project/blob/master/compiler-rt/lib/scudo/scudo_platform.h#L75
Scudo reserves that size but doesn't commit it, then it incrementally commits when memory is needed within the reserved region.

Tue, Sep 15, 9:19 AM · Restricted Project, Restricted Project, Restricted Project
russell.gallop added a comment to D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).

@russell.gallop I see a lots of failing tests when running ninja check-all on a Scudo-enabled build (stage 2). Do you see the same thing on your end?

Tue, Sep 15, 9:12 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 14

russell.gallop added a comment to D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).

Thanks for working on this @russell.gallop!

I've reproduced your tests, please see below. The only difference is that I've used a ThinLTO build for stage2:

Mon, Sep 14, 12:36 PM · Restricted Project, Restricted Project, Restricted Project
russell.gallop added inline comments to D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.
Mon, Sep 14, 2:14 AM · Restricted Project
russell.gallop updated the diff for D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).

Re-upload patch with G LLVM Github Monorepo set.

Mon, Sep 14, 1:31 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Sep 11

russell.gallop added a comment to D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).

Is there a good sanity check that it is actually using Scudo rather than silently using the standard alloc?

Fri, Sep 11, 9:20 AM · Restricted Project, Restricted Project, Restricted Project
russell.gallop updated the diff for D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).

Fixup scudo (sanitizer based) to work on Windows.

Fri, Sep 11, 9:15 AM · Restricted Project, Restricted Project, Restricted Project

Aug 28 2020

russell.gallop updated the summary of D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).
Aug 28 2020, 10:03 AM · Restricted Project, Restricted Project, Restricted Project
russell.gallop added a comment to D86714: Remove leftover REQUIRES: global-isel.

Thanks for catching that.

Aug 28 2020, 2:00 AM · Restricted Project

Aug 27 2020

russell.gallop added a comment to D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).

You marked D42519 as WIP, can you remember what was still TBD?

Aug 27 2020, 9:39 AM · Restricted Project, Restricted Project, Restricted Project
russell.gallop committed rGc9455d3c5792: [Test] Tidy up loose ends from LLVM_HAS_GLOBAL_ISEL (authored by russell.gallop).
[Test] Tidy up loose ends from LLVM_HAS_GLOBAL_ISEL
Aug 27 2020, 8:37 AM
russell.gallop closed D86714: Remove leftover REQUIRES: global-isel.
Aug 27 2020, 8:37 AM · Restricted Project
russell.gallop updated the diff for D86714: Remove leftover REQUIRES: global-isel.

Fix llvm-config test.

Aug 27 2020, 8:30 AM · Restricted Project
russell.gallop added a comment to D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).

That's awesome! Is it meant to eventually be committed or only be used for comparison purposes?

Aug 27 2020, 7:58 AM · Restricted Project, Restricted Project, Restricted Project
russell.gallop updated the diff for D86714: Remove leftover REQUIRES: global-isel.

I assume something in lit is parsing and recognizing this? Should remove that too?

Aug 27 2020, 7:40 AM · Restricted Project
russell.gallop added a comment to D85199: GlobalISel: Add generic instructions for memory intrinsics.

It's always available now. The requires global-isel is a leftover that should be removed

Aug 27 2020, 7:22 AM · Restricted Project
russell.gallop requested review of D86714: Remove leftover REQUIRES: global-isel.
Aug 27 2020, 7:22 AM · Restricted Project
russell.gallop added a comment to D85199: GlobalISel: Add generic instructions for memory intrinsics.

That's the right fix

Aug 27 2020, 6:33 AM · Restricted Project
russell.gallop updated subscribers of D85199: GlobalISel: Add generic instructions for memory intrinsics.

Hi Matt,

Aug 27 2020, 4:56 AM · Restricted Project
russell.gallop committed rGc17718e0ff26: Fix for PS4 bots after 0b7f6cc71a72a85f8a0cbee836a7a8e31876951a (authored by russell.gallop).
Fix for PS4 bots after 0b7f6cc71a72a85f8a0cbee836a7a8e31876951a
Aug 27 2020, 4:48 AM
russell.gallop added a comment to D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.

I'd also like to see how they (currently supported allocators) compare vs. SCUDO and vs. tcmalloc3, if someone is willing to port those on Windows.

Aug 27 2020, 3:13 AM · Restricted Project
russell.gallop added a comment to D42519: [scudo] Windows port WIP.

I've applied this to the monorepo and made a few more changes to allow it to build LLVM on Windows here: https://reviews.llvm.org/D86694

Aug 27 2020, 3:07 AM · Restricted Project
russell.gallop requested review of D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).
Aug 27 2020, 3:05 AM · Restricted Project, Restricted Project, Restricted Project

Aug 4 2020

russell.gallop committed rG98827feddb90: [lit] Add --time-trace-output to lit (authored by russell.gallop).
[lit] Add --time-trace-output to lit
Aug 4 2020, 6:26 AM
russell.gallop closed D84931: [lit] Add --time-trace-output to lit.
Aug 4 2020, 6:26 AM · Restricted Project

Jul 31 2020

russell.gallop added a comment to D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.

Thanks for your work on this. I've just tried out this version with rpmalloc (1.4.0) checked out out at the top of llvm-project.

Jul 31 2020, 9:02 AM · Restricted Project
russell.gallop added inline comments to D84931: [lit] Add --time-trace-output to lit.
Jul 31 2020, 6:31 AM · Restricted Project
russell.gallop added inline comments to D84931: [lit] Add --time-trace-output to lit.
Jul 31 2020, 4:31 AM · Restricted Project
russell.gallop updated the diff for D84931: [lit] Add --time-trace-output to lit.

Fixed comments and added test.

Jul 31 2020, 4:22 AM · Restricted Project

Jul 30 2020

russell.gallop updated the summary of D84931: [lit] Add --time-trace-output to lit.
Jul 30 2020, 4:06 AM · Restricted Project
russell.gallop requested review of D84931: [lit] Add --time-trace-output to lit.
Jul 30 2020, 4:00 AM · Restricted Project

Jul 28 2020

russell.gallop added a comment to D79147: Switch to using -debug-info-kind=constructor as default (from =limited).

It looks like is causing one of the debuginfo-tests: llgdb-tests/nrvo-string.cpp to fail, run on Linux. Failure as below. I don't think the debuginfo-tests are run on any bot (but probably should be!). I bisected the failure back to this change.

Jul 28 2020, 2:53 AM · debug-info, Restricted Project, Restricted Project

Jul 23 2020

russell.gallop added a comment to D82379: [docs] Fix TestSuiteGuide.md to mention scipy.

LGTM, thanks for updating the docs!

I guess it would be even better if we would provide the dependencies in a machine-readable way, e..g. https://python-packaging.readthedocs.io/en/latest/dependencies.html

Patches welcome :)

Jul 23 2020, 6:23 AM · Restricted Project
russell.gallop committed rGc798628fbdcc: [docs] Fix TestSuiteGuide.md to mention scipy (authored by russell.gallop).
[docs] Fix TestSuiteGuide.md to mention scipy
Jul 23 2020, 6:22 AM
russell.gallop closed D82379: [docs] Fix TestSuiteGuide.md to mention scipy.
Jul 23 2020, 6:22 AM · Restricted Project

Jul 1 2020

russell.gallop added a comment to D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.

I also don't know what exactly the policy around third_party code is, so discussing this on llvm-dev is probably a good idea.

But perhaps one way of side-stepping the whole issue would be to not check in rpmalloc into LLVM, but make the user point at it if they want to use it through a cmake variable, e.g. -DLLVM_USE_RPMALLOC=c:\path\to\rpmalloc (if such a thing is technically practical, I don't know)

Jul 1 2020, 4:49 AM · Restricted Project

Jun 30 2020

russell.gallop added a comment to D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.

I notice that the improvements to rpmalloc for LLVM are still under discussion (https://github.com/mjansson/rpmalloc/issues/150) and targetted at rpmalloc v1.4.1.

Jun 30 2020, 10:18 AM · Restricted Project

Jun 23 2020

russell.gallop created D82379: [docs] Fix TestSuiteGuide.md to mention scipy.
Jun 23 2020, 7:25 AM · Restricted Project

Jun 4 2020

russell.gallop committed rG3dad3907198b: Revert "Relands "[YAMLVFSWriter][Test][NFC] Add couple tests" vol. 2" (authored by russell.gallop).
Revert "Relands "[YAMLVFSWriter][Test][NFC] Add couple tests" vol. 2"
Jun 4 2020, 7:05 AM
russell.gallop added a reverting change for rG30949926f985: Relands "[YAMLVFSWriter][Test][NFC] Add couple tests" vol. 2: rG3dad3907198b: Revert "Relands "[YAMLVFSWriter][Test][NFC] Add couple tests" vol. 2".
Jun 4 2020, 7:05 AM
russell.gallop added a comment to D79552: [YAMLVFSWriter][Tests][NFC] Add couple tests.

The test is failing on Windows again: http://45.33.8.238/win/16808/step_11.txt Please take a look and revert for now if it takes a while to investigate.

Jun 4 2020, 7:04 AM · Restricted Project

May 29 2020

russell.gallop abandoned D80442: [runtimes] Pass COMPILER_RT* through to runtime build.

This needs be done on a per-target basis, not globally (e.g. you may want to use COMPILER_RT_BUILD_SANITIZERS=OFF for target1 but not target2). Have you tried setting RUNTIMES_${target}_COMPILER_RT_BUILD_SANITIZERS=OFF? This should be already supported, see for example https://github.com/llvm/llvm-project/blob/master/clang/cmake/caches/Fuchsia-stage2.cmake#L100

May 29 2020, 3:13 AM · Restricted Project

May 28 2020

russell.gallop added a comment to D78454: [clangd] Highlight related control flow..

Hi Sam,

May 28 2020, 7:34 AM · Restricted Project

May 22 2020

russell.gallop created D80442: [runtimes] Pass COMPILER_RT* through to runtime build.
May 22 2020, 9:05 AM · Restricted Project

May 15 2020

russell.gallop committed rG85bb9b71b7d4: [ELF] Update release notes and man page for LLD time-trace (authored by russell.gallop).
[ELF] Update release notes and man page for LLD time-trace
May 15 2020, 12:53 AM
russell.gallop closed D79780: [LLD][ELF] Add lld --time-trace to man page and release notes.
May 15 2020, 12:52 AM · Restricted Project, lld

May 14 2020

russell.gallop updated the diff for D79780: [LLD][ELF] Add lld --time-trace to man page and release notes.

Removed excess dashes in man page. Checked with:

May 14 2020, 9:43 AM · Restricted Project, lld
russell.gallop added inline comments to D79780: [LLD][ELF] Add lld --time-trace to man page and release notes.
May 14 2020, 2:38 AM · Restricted Project, lld
russell.gallop updated the diff for D79780: [LLD][ELF] Add lld --time-trace to man page and release notes.

Change to double dashes.

May 14 2020, 2:38 AM · Restricted Project, lld

May 13 2020

russell.gallop committed rGa520c89a4768: [DebugInfo] Fix test Fortran-DIModule.ll after 678bd84c4 (authored by russell.gallop).
[DebugInfo] Fix test Fortran-DIModule.ll after 678bd84c4
May 13 2020, 7:33 AM
russell.gallop added a comment to D79484: [DebugInfo] Fortran module DebugInfo support in LLVM.

This breaks tests on Windows: http://45.33.8.238/win/15149/step_11.txt

Please take a look and revert if it takes a while to investigate.

May 13 2020, 7:32 AM · Restricted Project, debug-info

May 12 2020

Herald added a reviewer for D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2): MaskRay.

Should this go into the docs / man page / release notes / etc.?

Probably. I'll take a look.

May 12 2020, 6:57 AM · Restricted Project
russell.gallop created D79780: [LLD][ELF] Add lld --time-trace to man page and release notes.
May 12 2020, 6:57 AM · Restricted Project, lld

Apr 22 2020

russell.gallop accepted D78030: [TimeProfiler] Emit clock synchronization point.

LGTM, with a few small comments.

Apr 22 2020, 1:35 AM · Restricted Project

Apr 15 2020

russell.gallop accepted D78153: [TimeProfiler] Fix some style issues. NFC.

LGTM, with assertion messages adjusted.

Apr 15 2020, 3:14 AM · Restricted Project
russell.gallop added a reviewer for D78153: [TimeProfiler] Fix some style issues. NFC: anton-afanasyev.
Apr 15 2020, 3:14 AM · Restricted Project

Apr 14 2020

russell.gallop accepted D78027: [TimeProfiler] Emit real process ID and thread names.

Would be nice if the test could check that the pid was being set to something but not sure how you could do that (beyond checking that it's a number).

Apr 14 2020, 7:27 AM · Restricted Project

Mar 24 2020

russell.gallop added a comment to D76695: [CMSE] Fix bogus save-temps.c tests.
Mar 24 2020, 9:07 AM
russell.gallop accepted D76695: [CMSE] Fix bogus save-temps.c tests.

LGTM, thanks.

Mar 24 2020, 7:29 AM
russell.gallop committed rG8fa322dd39a8: Increase DIAG_SIZE_DRIVER as we're close to hitting it (authored by russell.gallop).
Increase DIAG_SIZE_DRIVER as we're close to hitting it
Mar 24 2020, 4:48 AM

Feb 12 2020

russell.gallop added a comment to D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).

Should this go into the docs / man page / release notes / etc.?

Feb 12 2020, 3:37 AM · Restricted Project

Feb 10 2020

russell.gallop abandoned D69043: [RFC] Adding time-trace to LLD?.

This was submitted as the sequence of patches:
https://reviews.llvm.org/D70904 - Tidying up in TimeProfiler.cpp
https://reviews.llvm.org/D70950 - Add ProcName to TimeTraceProfiler
https://reviews.llvm.org/D71059 - [LLD][ELF] Add time-trace to ELF LLD (1/2) (multi-thread support in TimeProfiler)
https://reviews.llvm.org/D71060 - [LLD][ELF] Add time-trace to ELF LLD (2/2) (Add time trace to LLD)

Feb 10 2020, 2:11 AM · Restricted Project, Restricted Project

Feb 6 2020

russell.gallop committed rGe7cb37443309: [LLD][ELF] Add time-trace to ELF LLD (authored by russell.gallop).
[LLD][ELF] Add time-trace to ELF LLD
Feb 6 2020, 4:21 AM
russell.gallop closed D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).
Feb 6 2020, 4:21 AM · Restricted Project

Jan 31 2020

russell.gallop added a comment to D70950: Add ProcName to TimeTraceProfiler.
In D70950#1850796, @rnk wrote:

This broke ClangBuildAnalyzer on Windows because it has a very naive check for "clang":
https://github.com/aras-p/ClangBuildAnalyzer/blob/master/src/main.cpp#L148
I was wondering why this wasn't working on Windows anymore. =/

Jan 31 2020, 2:06 AM · Restricted Project, Restricted Project

Jan 29 2020

russell.gallop added a comment to D73639: [LLVM] Wrap extern TLS variable in getter Function.

Additionally it allows Clang versions prior to 10 to compile current trunk.

Jan 29 2020, 9:40 AM · Restricted Project

Jan 28 2020

russell.gallop added inline comments to D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).
Jan 28 2020, 10:11 AM · Restricted Project
russell.gallop updated the diff for D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2).
Jan 28 2020, 10:11 AM · Restricted Project

Jan 27 2020

russell.gallop committed rG77e6bb3cbad2: Re-land [Support] Extend TimeProfiler to support multiple threads (authored by russell.gallop).
Re-land [Support] Extend TimeProfiler to support multiple threads
Jan 27 2020, 5:08 AM
russell.gallop closed D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).
Jan 27 2020, 5:08 AM · Restricted Project

Jan 24 2020

russell.gallop added a comment to D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).

I'm not qualified to comment on the functionality. This seems like it'll be OK with respect to thread_local on Mac OSX. No further comments from me.

Jan 24 2020, 9:35 AM · Restricted Project
russell.gallop added a comment to D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).

Thanks, added const.

Jan 24 2020, 9:17 AM · Restricted Project
russell.gallop updated the diff for D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).

Add consts to references in lambda functions.

Jan 24 2020, 9:17 AM · Restricted Project
russell.gallop added a comment to D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).

Ping. Okay to land new version?

Jan 24 2020, 7:47 AM · Restricted Project

Jan 23 2020

russell.gallop committed rG4662f6e1c778: [test] Avoid loop-unroll.c test getting confused by fadd in git revision (authored by russell.gallop).
[test] Avoid loop-unroll.c test getting confused by fadd in git revision
Jan 23 2020, 1:42 AM
russell.gallop closed D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision.
Jan 23 2020, 1:42 AM · Restricted Project
russell.gallop added a comment to D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision.

Oh, wow! Might I ask you add the same for fmul? We may get a revision like that next time :).
Thank you!

Jan 23 2020, 1:33 AM · Restricted Project
russell.gallop updated the diff for D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision.

Update to check for start of metadata.

Jan 23 2020, 1:26 AM · Restricted Project

Jan 22 2020

russell.gallop created D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision.
Jan 22 2020, 1:27 AM · Restricted Project

Jan 21 2020

russell.gallop created D73123: [CMake] Fixes for including LLVM into another CMake project.
Jan 21 2020, 10:19 AM · Restricted Project, Restricted Project

Jan 15 2020

russell.gallop added a comment to D72390: [www] Remove stale text about default c++ standard from cxx_status.html.

Ping. Is this okay to land, or have I missed something? Thanks.

Jan 15 2020, 3:33 AM · Restricted Project
russell.gallop committed rG884a65af5cee: [Support] Replace Windows __declspec(thread) with thread_local for… (authored by russell.gallop).
[Support] Replace Windows __declspec(thread) with thread_local for…
Jan 15 2020, 3:24 AM
russell.gallop closed D72399: [Support] Replace Windows __declspec(thread) with thread_local in LLVM_THREAD_LOCAL.
Jan 15 2020, 3:24 AM · Restricted Project
russell.gallop added a comment to D72399: [Support] Replace Windows __declspec(thread) with thread_local in LLVM_THREAD_LOCAL.
In D72399#1820866, @rnk wrote:

lgtm

I checked that __declspec(thread) and thread_local seem to be functionally equivalent with MSVC.

Jan 15 2020, 3:15 AM · Restricted Project

Jan 10 2020

russell.gallop added inline comments to D72399: [Support] Replace Windows __declspec(thread) with thread_local in LLVM_THREAD_LOCAL.
Jan 10 2020, 5:26 AM · Restricted Project
russell.gallop updated the diff for D72399: [Support] Replace Windows __declspec(thread) with thread_local in LLVM_THREAD_LOCAL.

Fix condition

Jan 10 2020, 5:26 AM · Restricted Project
russell.gallop added a comment to D72399: [Support] Replace Windows __declspec(thread) with thread_local in LLVM_THREAD_LOCAL.

Sounds good to me - but probably good to get someone who works on the MSVC platform (like @rnk ) to confirm.

Jan 10 2020, 3:58 AM · Restricted Project
russell.gallop added a comment to D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.

Am I the only one who is a little bit uncomfortable with including a replacement to the system allocator in LLVM?

Jan 10 2020, 3:58 AM · Restricted Project

Jan 9 2020

russell.gallop added a comment to D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.

At first, I configured rpmalloc in the "unlimited" mode because I wanted maximum performance. I now reverted to default rpmalloc flags, and the memory usage has decreased (albeit still higher than the Windows Heap), with no impact on link time (meaning that timings are still the same as in the Summary). Below are "Max" values when linking clang.exe with ThinLTO:

Jan 9 2020, 8:02 AM · Restricted Project

Jan 8 2020

russell.gallop added inline comments to D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}.
Jan 8 2020, 8:46 AM · Restricted Project
russell.gallop created D72399: [Support] Replace Windows __declspec(thread) with thread_local in LLVM_THREAD_LOCAL.
Jan 8 2020, 6:53 AM · Restricted Project
russell.gallop created D72390: [www] Remove stale text about default c++ standard from cxx_status.html.
Jan 8 2020, 2:06 AM · Restricted Project