Page MenuHomePhabricator

russell.gallop (Russell Gallop)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 9 2014, 6:00 AM (254 w, 9 h)

Recent Activity

Fri, Jul 12

russell.gallop committed rG614a78c15a05: Revert "[JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from… (authored by russell.gallop).
Revert "[JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from…
Fri, Jul 12, 8:19 AM
russell.gallop added a reverting change for rG9c0391b36a76: [JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from parsed…: rG614a78c15a05: Revert "[JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from….
Fri, Jul 12, 8:19 AM
russell.gallop committed rGde54e2c4df98: Revert "[clangd] Implement typeHierarchy/resolve for subtypes" (authored by russell.gallop).
Revert "[clangd] Implement typeHierarchy/resolve for subtypes"
Fri, Jul 12, 6:37 AM
russell.gallop added a reverting change for rG5b9484e559d4: [clangd] Implement typeHierarchy/resolve for subtypes: rGde54e2c4df98: Revert "[clangd] Implement typeHierarchy/resolve for subtypes".
Fri, Jul 12, 6:37 AM

Tue, Jul 2

russell.gallop added a comment to D62063: CMake changes to get Windows self-host with PGO working.

Update: https://bugs.llvm.org/show_bug.cgi?id=41279 has been fixed by https://reviews.llvm.org/D62700.

Tue, Jul 2, 9:58 AM · Restricted Project

Mon, Jun 24

russell.gallop added inline comments to D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks.
Mon, Jun 24, 4:12 AM · Restricted Project, Restricted Project

Jun 7 2019

russell.gallop committed rG4bcba163b1b8: [X86][test] Add test cases using immediates to builtins-x86.c (authored by russell.gallop).
[X86][test] Add test cases using immediates to builtins-x86.c
Jun 7 2019, 2:54 AM

Jun 5 2019

russell.gallop updated the diff for D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC.

Re-added test cases using variables and added comment. This now tests both formats.

Jun 5 2019, 5:52 AM · Restricted Project, Restricted Project

Jun 4 2019

russell.gallop added a comment to D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC.

We support non immediate on these because gcc does.

Jun 4 2019, 10:39 AM · Restricted Project, Restricted Project
russell.gallop added a comment to D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC.

I'll have a look and see if there is a reason why these don't fail in the same way (which would make the test fail in it's current form).

Jun 4 2019, 10:39 AM · Restricted Project, Restricted Project
russell.gallop added a comment to D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC.

Then the test should be failing? Or is the current form also legal?

Jun 4 2019, 9:54 AM · Restricted Project, Restricted Project
russell.gallop added a comment to D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC.

Is the compiler missing a check that these parameters are immediates?

Jun 4 2019, 7:03 AM · Restricted Project, Restricted Project
russell.gallop added a comment to D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC.

I'm not sure what you mean.

Jun 4 2019, 5:28 AM · Restricted Project, Restricted Project
russell.gallop created D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC.
Jun 4 2019, 3:50 AM · Restricted Project, Restricted Project

May 31 2019

russell.gallop committed rG802c9b59d5c5: ftime-trace: Trace loop passes (authored by russell.gallop).
ftime-trace: Trace loop passes
May 31 2019, 3:13 AM

May 30 2019

russell.gallop created D62666: ftime-trace: Trace loop passes.
May 30 2019, 8:15 AM · Restricted Project

May 29 2019

russell.gallop added a comment to D62063: CMake changes to get Windows self-host with PGO working.

https://reviews.llvm.org/D62200 has landed so -fprofile-generate and -fcs-profile-generate both add --dependent-lib (required for this patch to make sense).

May 29 2019, 4:58 AM · Restricted Project

May 28 2019

russell.gallop added a comment to D61742: [Driver][Windows] Add dependent lib argument for profile instr generate.

I was going to suggest that maybe what we should do is just embed the basename, i.e. /nodefaultlib:clang_rt.profile-x86_64.lib ...

May 28 2019, 10:49 AM · Restricted Project
russell.gallop added a comment to D61742: [Driver][Windows] Add dependent lib argument for profile instr generate.

it looks like passing -no-canonical-prefixes makes this path relative

May 28 2019, 8:42 AM · Restricted Project
russell.gallop updated subscribers of D61742: [Driver][Windows] Add dependent lib argument for profile instr generate.

Hello, this embeds an absolute path into the generated .obj file, which means the output now is no longer deterministic (since it depends on the absolute path to clang_rt.profile-x86_64.lib).

May 28 2019, 6:46 AM · Restricted Project

May 22 2019

russell.gallop committed rGfd22d7f8611f: Revert r361148 "[Syntax] Introduce TokenBuffer, start clangToolingSyntax… (authored by russell.gallop).
Revert r361148 "[Syntax] Introduce TokenBuffer, start clangToolingSyntax…
May 22 2019, 5:51 AM
russell.gallop committed rG529141e4ad33: Mark tests from r361278 as unsupported on Windows. (authored by russell.gallop).
Mark tests from r361278 as unsupported on Windows.
May 22 2019, 5:07 AM
russell.gallop committed rG72fea1d2580b: [Driver][Windows] Add dependent lib argument for -fprofile-generate and -fcs… (authored by russell.gallop).
[Driver][Windows] Add dependent lib argument for -fprofile-generate and -fcs…
May 22 2019, 3:05 AM

May 21 2019

russell.gallop added a reviewer for D62200: [Driver][Windows] Add dependent lib argument for -fprofile-generate and -fcs-profile-generate: xur.
May 21 2019, 8:07 AM · Restricted Project, Restricted Project
russell.gallop added a comment to D62063: CMake changes to get Windows self-host with PGO working.

1). -fprofile-generate and -fcs-profile-generate need clang_rt.profile adding with --dependent-lib in the driver (like https://reviews.llvm.org/D61742). I'll create a separate review for that.

May 21 2019, 8:07 AM · Restricted Project
russell.gallop created D62200: [Driver][Windows] Add dependent lib argument for -fprofile-generate and -fcs-profile-generate.
May 21 2019, 8:02 AM · Restricted Project, Restricted Project
russell.gallop added a comment to D62063: CMake changes to get Windows self-host with PGO working.

2). Self hosting with -fprofile-generate hits a crash building CrashRecoveryContext.cpp. I'll try to report this.

May 21 2019, 7:16 AM · Restricted Project
russell.gallop updated the diff for D62063: CMake changes to get Windows self-host with PGO working.

Handle -fprofile-generate and -fcs-profile-generate options for self hosting as well.

May 21 2019, 5:55 AM · Restricted Project
russell.gallop added inline comments to D62063: CMake changes to get Windows self-host with PGO working.
May 21 2019, 3:05 AM · Restricted Project

May 17 2019

russell.gallop committed rG3a02b12439f8: Fix tests from r361013 on X86 bots. (authored by russell.gallop).
Fix tests from r361013 on X86 bots.
May 17 2019, 8:37 AM
russell.gallop created D62063: CMake changes to get Windows self-host with PGO working.
May 17 2019, 6:40 AM · Restricted Project

May 14 2019

russell.gallop committed rG7a9ccf89f238: [Driver][Windows] Add dependent lib argument for profile instr generate (authored by russell.gallop).
[Driver][Windows] Add dependent lib argument for profile instr generate
May 14 2019, 7:02 AM

May 10 2019

russell.gallop added a comment to D61742: [Driver][Windows] Add dependent lib argument for profile instr generate.
In D61742#1497259, @rnk wrote:

Thanks, I would like to do this for the sanitizers as well, since this is a constant pain point for users

May 10 2019, 7:31 AM · Restricted Project
russell.gallop updated the diff for D61742: [Driver][Windows] Add dependent lib argument for profile instr generate.

Prevent adding -dependent-lib on mingw32 and add tests.

May 10 2019, 7:30 AM · Restricted Project

May 9 2019

russell.gallop created D61742: [Driver][Windows] Add dependent lib argument for profile instr generate.
May 9 2019, 9:51 AM · Restricted Project

Apr 30 2019

russell.gallop committed rG9b3acea16c9c: Add llvm-profdata to LLVM_TOOLCHAIN_TOOLS (authored by russell.gallop).
Add llvm-profdata to LLVM_TOOLCHAIN_TOOLS
Apr 30 2019, 8:34 AM
russell.gallop created D61317: Add llvm-profdata to LLVM_TOOLCHAIN_TOOLS.
Apr 30 2019, 8:22 AM · Restricted Project
russell.gallop committed rGa7c2e580c7a6: Fix inconsistency in calculating DIAG_START_ values. (authored by russell.gallop).
Fix inconsistency in calculating DIAG_START_ values.
Apr 30 2019, 5:52 AM
russell.gallop committed rGf7e1fe563a07: [cmake] Fix error message on simulated VS version check (authored by russell.gallop).
[cmake] Fix error message on simulated VS version check
Apr 30 2019, 5:39 AM

Apr 29 2019

russell.gallop created D61264: Fix inconsistency in calculating DIAG_START values.
Apr 29 2019, 7:44 AM · Restricted Project, Restricted Project
russell.gallop committed rGd8212edf6840: vs integration: Use llvm-lib for librarian (authored by russell.gallop).
vs integration: Use llvm-lib for librarian
Apr 29 2019, 3:10 AM

Apr 26 2019

russell.gallop created D61193: vs integration: Use llvm-lib for librarian.
Apr 26 2019, 8:24 AM · Restricted Project
russell.gallop created D61188: [cmake] Fix error message in simulated VS version check.
Apr 26 2019, 7:27 AM · Restricted Project

Mar 7 2019

Herald added a project to D56799: [NFC] Factor out + document build requirements: Restricted Project.
Mar 7 2019, 7:57 AM · Restricted Project

Apr 11 2018

russell.gallop added a comment to D43578: -ftime-report switch support in Clang.

We also see an assertion failure prior to the revert. At r329738:

Apr 11 2018, 5:24 AM

Jun 8 2017

russell.gallop added a comment to D33591: Test to increase coverage of InstCombinePHI.cpp isSafeAndProfitableToSinkLoad().

Ping

Jun 8 2017, 10:32 AM

May 26 2017

russell.gallop created D33591: Test to increase coverage of InstCombinePHI.cpp isSafeAndProfitableToSinkLoad().
May 26 2017, 3:44 AM

Sep 11 2015

russell.gallop added a comment to D12723: llvm-mc-fuzzer: A fuzzing tool for the MC layer..

I found a number of bugs comparing direct object emission and via assembly with the check_cfc tool. Sean I and spoke about using fuzzing in that area. I expect it would find issues but I haven't done any work on it so no objections if someone wanted to add this to llvm-mc-fuzzer.

Sep 11 2015, 2:32 AM

Jun 3 2015

russell.gallop closed D10188: [utils] Add exact check to check_cfc.py dash_s_no_change.

Thanks for the review Rafael.

Jun 3 2015, 7:43 AM
russell.gallop accepted D10188: [utils] Add exact check to check_cfc.py dash_s_no_change.
Jun 3 2015, 7:43 AM

Jun 2 2015

russell.gallop retitled D10188: [utils] Add exact check to check_cfc.py dash_s_no_change from to [utils] Add exact check to check_cfc.py dash_s_no_change.
Jun 2 2015, 9:40 AM
russell.gallop retitled D10183: [utils] Improvements to check_cfc.py to work better with build systems from to [utils] Improvements to check_cfc.py to work better with build systems.
Jun 2 2015, 5:58 AM

Apr 2 2015

russell.gallop added a comment to D8723: Check Compile Flow Consistency tool (check_cfc.py).

Thanks Rafael. I've fixed the 80 col violations and committed revision 233919.

Apr 2 2015, 8:05 AM

Apr 1 2015

russell.gallop updated the diff for D8723: Check Compile Flow Consistency tool (check_cfc.py).

Fixes for points raised by Rafael.

Apr 1 2015, 10:11 AM
russell.gallop added inline comments to D8723: Check Compile Flow Consistency tool (check_cfc.py).
Apr 1 2015, 9:57 AM
russell.gallop updated the diff for D8723: Check Compile Flow Consistency tool (check_cfc.py).

Fix line endings.

Apr 1 2015, 7:04 AM
russell.gallop updated the diff for D8723: Check Compile Flow Consistency tool (check_cfc.py).

Use -via-file-asm for dash_s_no_change check.

Apr 1 2015, 6:55 AM

Mar 31 2015

russell.gallop retitled D8723: Check Compile Flow Consistency tool (check_cfc.py) from to Check Compile Flow Consistency tool (check_cfc.py).
Mar 31 2015, 9:07 AM

Oct 22 2014

russell.gallop accepted D4901: Basic JUnit XML support for llvm-lit.

This would be very useful to us. I tried this patch and it basically works with our CI server too.

Oct 22 2014, 3:33 AM