Page MenuHomePhabricator

[compiler-rt] Replace INLINE with inline
ClosedPublic

Authored by krytarowski on Sat, Sep 12, 10:02 AM.

Details

Summary

This fixes the clash with BSD headers.

Diff Detail

Event Timeline

krytarowski created this revision.Sat, Sep 12, 10:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptSat, Sep 12, 10:02 AM
Herald added subscribers: Restricted Project, jfb, atanasyan and 4 others. · View Herald Transcript
krytarowski requested review of this revision.Sat, Sep 12, 10:02 AM

I've verified that this symbol has unlikely any clashes with 3rd party software now. https://grep.app/search?q=ATTR_INLINE&case=true&words=true

I prefer we use just "inline"

I prefer we use just "inline"

That changes the behaviour of the always_inline ones.

krytarowski retitled this revision from [compiler-rt] Rename INLINE to ATTR_INLINE to [compiler-rt] Replace INLINE with inline.

I prefer we use just "inline"

Done.

I prefer we use just "inline"

That changes the behaviour of the always_inline ones.

I've preserved this semantics.

vitalybuka accepted this revision.Wed, Sep 16, 2:05 PM

Can you please clang format it as well

compiler-rt/lib/msan/tests/msan_test.cpp
142

it's test only scope, but please use something else
e.g. ALWAYS_INLINE

This revision is now accepted and ready to land.Wed, Sep 16, 2:05 PM

Can you please clang format it as well

Actually.. no. The changes are very invasive and I recommend to run clang-format independently on the compiler-rt files to fixup the style.

I defer it to others.

This revision was landed with ongoing or failed builds.Thu, Sep 17, 7:24 AM
This revision was automatically updated to reflect the committed changes.