[flang] Fix analyzed form of type-bound assignment

[tskeith]

Summary

In the analyzed form of type-bound assignment, the binding name was
used where it should have been the subprogram name.

[klausler]

Should you check that compilation-time resolution applies to monomorphic objects and NON_OVERRIDABLE bindings, but *not* to overridable bindings of polymorphic objects?

[tskeith]

In D87411#2264251, @klausler wrote:

Should you check that compilation-time resolution applies to monomorphic objects and NON_OVERRIDABLE bindings, but *not* to overridable bindings of polymorphic objects?

You're right. Analyzed calls have the same problem but functions are correct so I will try to use that code in all cases. That's a much bigger change so I will make a new revision for it.

flang/lib/Semantics/expression.cpp

if (const Symbol * symbol{scope.FindSymbol(oprName)}) {
     }
   }
   for (std::size_t passIndex{0}; passIndex < actuals_.size(); ++passIndex) {
     if (const Symbol * specific{FindBoundOp(oprName, passIndex)}) {
       proc = specific;
     }
   }
   if (proc) {
+    if (const auto *binding{proc->detailsIf<semantics::ProcBindingDetails>()}) {
+      proc = &binding->symbol();
+    }
     ActualArguments actualsCopy{actuals_};
     actualsCopy[1]->Parenthesize();
     return ProcedureRef{ProcedureDesignator{*proc}, std::move(actualsCopy)};
   } else {
     return std::nullopt;
   }
 }
 

flang/test/Parser/defined-ops.f90

+! RUN: %f18 -funparse %s 2>&1 | FileCheck %s
+
+! Check that the analyzed form of a type-bound defined operator or assignment
+! uses the resolved subprogram.
+
+module m
+  type :: t
+  contains
+    procedure :: assign
+    procedure :: add
+    generic :: assignment(=) => assign
+    generic :: operator(+) => add
+  end type
+contains
+  subroutine assign(x, y)
+    class(t), intent(out) :: x
+    class(t), intent(in) :: y
+  end
+  type(t) pure function add(x, y)
+    class(t), intent(in) :: x
+    integer, intent(in) :: y
+  end
+end
+
+use m
+type(t) :: x, y
+!CHECK: CALL assign(x,add(y,1_4))
+x = y + 1
+end