This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Pass nofpexcept flag to custom lowered constrained ops
ClosedPublic

Authored by qiucf on Sep 9 2020, 9:11 AM.

Details

Summary

This is a follow-up of D86605. For strict DAG FP node, if its FP exception behavior metadata is ignore, it should have nofpexcept flag. But during custom lowering, this flag isn't passed down. This is also seen on X86 target.

Diff Detail

Event Timeline

qiucf created this revision.Sep 9 2020, 9:11 AM
qiucf requested review of this revision.Sep 9 2020, 9:11 AM
uweigand accepted this revision.Sep 15 2020, 9:39 AM

This LGTM, thanks!

llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
1681

Well, the comment also refers to the non-strict FADD, so it might still be relevant?

This revision is now accepted and ready to land.Sep 15 2020, 9:39 AM