This is a follow-up of D86605. For strict DAG FP node, if its FP exception behavior metadata is ignore, it should have nofpexcept flag. But during custom lowering, this flag isn't passed down. This is also seen on X86 target.
Details
Details
- Reviewers
uweigand steven.zhang jsji nemanjai - Group Reviewers
Restricted Project - Commits
- rG1d782c29872c: [PowerPC] Pass nofpexcept flag to custom lowered constrained ops
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
This LGTM, thanks!
llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp | ||
---|---|---|
1681 | Well, the comment also refers to the non-strict FADD, so it might still be relevant? |
Well, the comment also refers to the non-strict FADD, so it might still be relevant?