This is an archive of the discontinued LLVM Phabricator instance.

Differential D86943

[ms] [llvm-ml] Add support for line continuations in MASM
AbandonedPublic

Authored by epastor on Sep 1 2020, 7:59 AM.

Details

Reviewers
None
Summary

Add support for the line continuation character (\)

Diff Detail

Revision Contents

PathSize
llvm/
lib/
MC/
MCParser/
8 lines
test/
tools/
llvm-ml/
17 lines

Diff 289237

llvm/lib/MC/MCParser/MasmParser.cpp

Show First 20 Lines • Show All 1,088 Lines • ▼ Show 20 Linesconst AsmToken &MasmParser::Lex() {
// Parse comments here to be deferred until end of next statement. // Parse comments here to be deferred until end of next statement.
while (tok->is(AsmToken::Comment)) { while (tok->is(AsmToken::Comment)) {
if (MAI.preserveAsmComments()) if (MAI.preserveAsmComments())
Out.addExplicitComment(Twine(tok->getString())); Out.addExplicitComment(Twine(tok->getString()));
tok = &Lexer.Lex(); tok = &Lexer.Lex();
} }
// Recognize and bypass line continuations.
while (tok->is(AsmToken::BackSlash) &&
Lexer.peekTok().is(AsmToken::EndOfStatement)) {
// Eat both the backslash and the end of statement.
Lexer.Lex();
tok = &Lexer.Lex();
}
if (tok->is(AsmToken::Eof)) { if (tok->is(AsmToken::Eof)) {
// If this is the end of an included file, pop the parent file off the // If this is the end of an included file, pop the parent file off the
// include stack. // include stack.
SMLoc ParentIncludeLoc = SrcMgr.getParentIncludeLoc(CurBuffer); SMLoc ParentIncludeLoc = SrcMgr.getParentIncludeLoc(CurBuffer);
if (ParentIncludeLoc != SMLoc()) { if (ParentIncludeLoc != SMLoc()) {
jumpToLoc(ParentIncludeLoc); jumpToLoc(ParentIncludeLoc);
return Lex(); return Lex();
} }
▲ Show 20 Lines • Show All 5,751 Lines • Show Last 20 Lines

llvm/test/tools/llvm-ml/line_continuations.test

  • This file was added.
# RUN: llvm-ml -filetype=asm %s | FileCheck %s
.code
t1:
mov eax, \
ebx
# CHECK: t1:
# CHECK-NEXT: mov eax, ebx
t2:
mov eax, [ebx + \
1]
# CHECK: t2:
# CHECK-NEXT: mov eax, dword ptr [ebx + 1]
END