[Attributor][NFC] Fix dependency type in AAUndefinedBehaviorImpl::updateImpl

[okura]

Summary

This patch fixes wrong dependency type in AAUB.

[jdoerfert]

llvm/lib/Transforms/IPO/AttributorAttributes.cpp

2034

If we only use known values you don't even need to track the dependence. here and above.

2077

clang-format the patch, also as above.

[okura]

• fix dependence
• fix formatting

[okura]

llvm/lib/Transforms/IPO/AttributorAttributes.cpp

2077

Something was wrong with Automatic formatting, sorry.

[jdoerfert]

LGTM. Make sure there are no test changes

llvm/lib/Transforms/IPO/AttributorAttributes.cpp

auto InspectCallSiteForUB = [&](Instruction &I) {
         if (idx >= Callee->arg_size())
           break;
         Value *ArgVal = CB.getArgOperand(idx);
         if (!ArgVal || !ArgVal->getType()->isPointerTy())
           continue;
         IRPosition CalleeArgumentIRP = IRPosition::callsite_argument(CB, idx);
         if (!CalleeArgumentIRP.hasAttr({Attribute::NoUndef}))
           continue;
-        auto &NonNullAA = A.getAAFor<AANonNull>(*this, CalleeArgumentIRP);
+        auto &NonNullAA = A.getAAFor<AANonNull>(*this, CalleeArgumentIRP,
+                                                /* TrackDependence */ true,
+                                                DepClassTy::OPTIONAL);
         if (!NonNullAA.isKnownNonNull())
           continue;
-        const auto &ValueSimplifyAA =
-            A.getAAFor<AAValueSimplify>(*this, IRPosition::value(*ArgVal));
+        const auto &ValueSimplifyAA = A.getAAFor<AAValueSimplify>(
+            *this, IRPosition::value(*ArgVal), /* TrackDependence */ true,
+            DepClassTy::OPTIONAL);
         Optional<Value *> SimplifiedVal =
             ValueSimplifyAA.getAssumedSimplifiedValue(A);
 
         if (!ValueSimplifyAA.isKnown())
           continue;
         // Here, we handle three cases.
         //   (1) Not having a value means it is dead. (we can replace the value
         //       with undef)
auto InspectReturnInstForUB =
           //       such values are ignored in
           //       checkForAllReturnedValuesAndReturnedInsts.
           bool FoundUB = false;
           if (isa<UndefValue>(V)) {
             FoundUB = true;
           } else {
             if (isa<ConstantPointerNull>(V)) {
               auto &NonNullAA = A.getAAFor<AANonNull>(
-                  *this, IRPosition::returned(*getAnchorScope()));
+                  *this, IRPosition::returned(*getAnchorScope()), /* TrackDependence */ true, DepClassTy::OPTIONAL);
               if (NonNullAA.isKnownNonNull())
                 FoundUB = true;
             }
           }
 
           if (FoundUB)
             for (ReturnInst *RI : RetInsts)
               KnownUBInsts.insert(RI);